<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">That might have been there from before when we might have used system headers for the mach-o stuff. That was a way long time ago. We now use LLVM's headers for everything so it should be safe.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 14, 2018, at 11:29 AM, Greg Clayton <<a href="mailto:clayborg@gmail.com" class="">clayborg@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">That shouldn't be there. Lets remove it and see how things go.<div class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Mar 14, 2018, at 10:30 AM, Pavel Labath <<a href="mailto:labath@google.com" class="">labath@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Take a look at #ifdef __APPLE__ around ObjectFileMachO in SystemInitializerCommon.cpp.<div class=""><br class=""></div><div class="">I tried removing that, but that led to a bunch of undefined symbol errors (because of other stuff that was ifdefed out). It could be this is just a matter of removing enough ifdefs, but I haven't tried following through on that (so I don't know whether we'll run into some code including system headers or such...).</div></div><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Wed, 14 Mar 2018 at 17:20, Greg Clayton via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">What part is ifdef'ed? Mach core files should be available on any platform?<br class="">
<br class="">
> On Mar 14, 2018, at 7:16 AM, Jonas Devlieghere via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Author: jdevlieghere<br class="">
> Date: Wed Mar 14 07:16:23 2018<br class="">
> New Revision: 327512<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=327512&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=327512&view=rev</a><br class="">
> Log:<br class="">
> [test] Disable TestMachCore everywhere except on Darwin<br class="">
><br class="">
> Apparently the parser is wrapped inside ifdef's so the logic isn't<br class="">
> available on non-Darwin platforms.<br class="">
><br class="">
> Should fix build bot failure:<br class="">
> <a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20463" rel="noreferrer" target="_blank" class="">http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20463</a><br class="">
><br class="">
> Modified:<br class="">
> lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py<br class="">
><br class="">
> Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py?rev=327512&r1=327511&r2=327512&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py?rev=327512&r1=327511&r2=327512&view=diff</a><br class="">
> ==============================================================================<br class="">
> --- lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py (original)<br class="">
> +++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py Wed Mar 14 07:16:23 2018<br class="">
> @@ -26,6 +26,7 @@ class MachCoreTestCase(TestBase):<br class="">
> lldb.DBG.SetSelectedPlatform(self._initial_platform)<br class="">
> super(MachCoreTestCase, self).tearDown()<br class="">
><br class="">
> + @skipUnlessDarwin<br class="">
> def test_selected_thread(self):<br class="">
> """Test that the right thread is selected after a core is loaded."""<br class="">
> # Create core form YAML.<br class="">
><br class="">
><br class="">
> _______________________________________________<br class="">
> lldb-commits mailing list<br class="">
> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="">
<br class="">
_______________________________________________<br class="">
lldb-commits mailing list<br class="">
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank" class="">lldb-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></div></blockquote></div><br class=""></body></html>