<div dir="ltr"><a href="http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4609/">http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4609/</a>  (after the revert) - the same 4 failures or am I missing smth ?<br><div><br></div><div>Thanks, </div><div>Alexander</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 30, 2018 at 8:16 PM, Davide Italiano <span dir="ltr"><<a href="mailto:dccitaliano@gmail.com" target="_blank">dccitaliano@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I went ahead for now and reverted in the hope this makes the bot green (again).<br>
<br>
Committing to <a href="https://llvm.org/svn/llvm-project/lldb/trunk" rel="noreferrer" target="_blank">https://llvm.org/svn/llvm-<wbr>project/lldb/trunk</a> ...<br>
commit f5d7ce2552c2003379bdbe78737f12<wbr>dd50832b0d<br>
Author: Davide Italiano <<a href="mailto:ditaliano@apple.com">ditaliano@apple.com</a>><br>
Date:   Tue Jan 30 20:14:32 2018 -0800<br>
<br>
    Revert "[lldb] Enable debugging of binaries with mixed<br>
(splitted/regular) dwarf"<br>
<br>
    It might have caused some instability on the bots.<br>
<br>
 delete mode 100644<br>
packages/Python/lldbsuite/<wbr>test/linux/mix-dwo-and-<wbr>regular-objects/Makefile<br>
 delete mode 100644<br>
packages/Python/lldbsuite/<wbr>test/linux/mix-dwo-and-<wbr>regular-objects/<wbr>TestMixedDwarfBinary.py<br>
 delete mode 100644<br>
packages/Python/lldbsuite/<wbr>test/linux/mix-dwo-and-<wbr>regular-objects/a.c<br>
 delete mode 100644<br>
packages/Python/lldbsuite/<wbr>test/linux/mix-dwo-and-<wbr>regular-objects/b.c<br>
<br>
<br>
If the bots stay red, you can recommit (or I'll recommit on your behalf).<br>
<br>
Thanks,<br>
<br>
--<br>
Davide<br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, Jan 30, 2018 at 5:03 PM, Davide Italiano <<a href="mailto:dccitaliano@gmail.com">dccitaliano@gmail.com</a>> wrote:<br>
> On Tue, Jan 30, 2018 at 3:45 PM, Alexander Shaposhnikov via<br>
> lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
>> Author: alexshap<br>
>> Date: Tue Jan 30 15:45:20 2018<br>
>> New Revision: 323832<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=323832&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=323832&view=rev</a><br>
>> Log:<br>
>> [lldb] Enable debugging of binaries with mixed (splitted/regular) dwarf<br>
>><br>
>> Initialize the default value of SymbolFileDWARF uuid with<br>
>> the appropriately shifted DW_INVALID_OFFSET constant.<br>
>> This change fixes the collision in the computation of DIE uid<br>
>> (inside DIERef::GetUID) and incorrect CompileUnit lookup<br>
>> (because of the misleading cu_offset value).<br>
>><br>
>> Test plan: make check-lldb<br>
>><br>
><br>
> This commit seems to have caused some failures on the bots.<br>
><br>
> <a href="http://lab.llvm.org:8080/green/view/LLDB/job/lldb-xcode/4605/" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/<wbr>green/view/LLDB/job/lldb-<wbr>xcode/4605/</a><br>
><br>
> Can you please take a look? (and revert in case you're not able to<br>
> figure out what's going on)<br>
><br>
> --<br>
> Davide<br>
</div></div></blockquote></div><br></div>