<div dir="ltr">The comments were automatically added a long time ago when I tried to run IWYU on LLDB source code.  I don't think you need to maintain them.</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Jan 20, 2018 at 2:25 PM Raphael Isemann via Phabricator via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">teemperor created this revision.<br>
teemperor added a reviewer: aprantl.<br>
<br>
This patch adds missing includes to the LLDB headers inside `include/` as a first step of building LLDB's source with C++ modules. Includes in lldb seem to be commented if the reason for the include is not obvious (`// for addr_t`), so I tried to keep the same style here. It also fixes this single `stds::` typo.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D42340" rel="noreferrer" target="_blank">https://reviews.llvm.org/D42340</a><br>
<br>
Files:<br>
  include/lldb/Core/LoadedModuleInfoList.h<br>
  include/lldb/Core/ThreadSafeDenseSet.h<br>
  include/lldb/Core/ThreadSafeValue.h<br>
  include/lldb/DataFormatters/VectorIterator.h<br>
  include/lldb/Target/ProcessStructReader.h<br>
  include/lldb/Utility/AnsiTerminal.h<br>
  include/lldb/Utility/SharedCluster.h<br>
<br>
<br>
Index: include/lldb/Utility/SharedCluster.h<br>
===================================================================<br>
--- include/lldb/Utility/SharedCluster.h<br>
+++ include/lldb/Utility/SharedCluster.h<br>
@@ -15,6 +15,8 @@<br>
<br>
 #include "llvm/ADT/SmallPtrSet.h"<br>
<br>
+#include <mutex><br>
+<br>
 namespace lldb_private {<br>
<br>
 namespace imp {<br>
Index: include/lldb/Utility/AnsiTerminal.h<br>
===================================================================<br>
--- include/lldb/Utility/AnsiTerminal.h<br>
+++ include/lldb/Utility/AnsiTerminal.h<br>
@@ -50,6 +50,7 @@<br>
 #define ANSI_1_CTRL(ctrl1) "\033["##ctrl1 ANSI_ESC_END<br>
 #define ANSI_2_CTRL(ctrl1, ctrl2) "\033["##ctrl1 ";"##ctrl2 ANSI_ESC_END<br>
<br>
+#include "llvm/ADT/ArrayRef.h"<br>
 #include "llvm/ADT/STLExtras.h"<br>
 #include "llvm/ADT/StringRef.h"<br>
<br>
Index: include/lldb/Target/ProcessStructReader.h<br>
===================================================================<br>
--- include/lldb/Target/ProcessStructReader.h<br>
+++ include/lldb/Target/ProcessStructReader.h<br>
@@ -16,6 +16,7 @@<br>
 #include "lldb/Symbol/CompilerType.h"<br>
 #include "lldb/Target/Process.h"<br>
 #include "lldb/Utility/ConstString.h"<br>
+#include "lldb/Utility/DataBufferHeap.h"<br>
 #include "lldb/Utility/DataExtractor.h"<br>
 #include "lldb/Utility/Status.h"<br>
<br>
Index: include/lldb/DataFormatters/VectorIterator.h<br>
===================================================================<br>
--- include/lldb/DataFormatters/VectorIterator.h<br>
+++ include/lldb/DataFormatters/VectorIterator.h<br>
@@ -13,6 +13,7 @@<br>
<br>
 #include "lldb/lldb-forward.h"<br>
<br>
+#include "lldb/DataFormatters/TypeSynthetic.h" // for SyntheticChildrenFrontEnd<br>
 #include "lldb/Target/ExecutionContext.h"<br>
 #include "lldb/Utility/ConstString.h"<br>
<br>
Index: include/lldb/Core/ThreadSafeValue.h<br>
===================================================================<br>
--- include/lldb/Core/ThreadSafeValue.h<br>
+++ include/lldb/Core/ThreadSafeValue.h<br>
@@ -17,6 +17,7 @@<br>
<br>
 // Other libraries and framework includes<br>
 // Project includes<br>
+#include "lldb/lldb-defines.h" // for DISALLOW_COPY_AND_ASSIGN<br>
<br>
 namespace lldb_private {<br>
<br>
Index: include/lldb/Core/ThreadSafeDenseSet.h<br>
===================================================================<br>
--- include/lldb/Core/ThreadSafeDenseSet.h<br>
+++ include/lldb/Core/ThreadSafeDenseSet.h<br>
@@ -46,7 +46,7 @@<br>
   }<br>
<br>
   void Clear() {<br>
-    stds::lock_guard<_MutexType> guard(m_mutex);<br>
+    std::lock_guard<_MutexType> guard(m_mutex);<br>
     m_set.clear();<br>
   }<br>
<br>
Index: include/lldb/Core/LoadedModuleInfoList.h<br>
===================================================================<br>
--- include/lldb/Core/LoadedModuleInfoList.h<br>
+++ include/lldb/Core/LoadedModuleInfoList.h<br>
@@ -13,10 +13,13 @@<br>
 // C Includes<br>
<br>
 // C++ Includes<br>
+#include <cassert><br>
 #include <vector><br>
<br>
 // Other libraries and framework includes<br>
+#include "lldb/lldb-defines.h" // for LLDB_INVALID_ADDRESS<br>
 #include "lldb/lldb-private-forward.h"<br>
+#include "lldb/lldb-types.h" // for addr_t<br>
<br>
 namespace lldb_private {<br>
 class LoadedModuleInfoList {<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>