Write a unit test and make a class that inherits from it so it can access the protected member<br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 4, 2018 at 6:54 PM Davide Italiano via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@Pavel, is there an easy way of testing this? m_core is a protected<br>
member of ArchSpec so we can't set it willy-nilly, but still I'd like<br>
to have some regression testing for the change. I'll take a look early<br>
tomorrow, but throwing this here in case you have ideas.<br>
<br>
Thanks!<br>
<br>
--<br>
Davide<br>
<br>
On Thu, Jan 4, 2018 at 6:50 PM, Davide Italiano via lldb-commits<br>
<<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
> Author: davide<br>
> Date: Thu Jan  4 18:50:24 2018<br>
> New Revision: 321856<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=321856&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=321856&view=rev</a><br>
> Log:<br>
> [ArchSpec] Don't consider Unknown MachO64 as invalid.<br>
><br>
> Even without a proper arch we can access line tables, etc..<br>
><br>
> <rdar://problem/35778442><br>
><br>
> Modified:<br>
>     lldb/trunk/source/Utility/ArchSpec.cpp<br>
><br>
> Modified: lldb/trunk/source/Utility/ArchSpec.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/ArchSpec.cpp?rev=321856&r1=321855&r2=321856&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/ArchSpec.cpp?rev=321856&r1=321855&r2=321856&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/source/Utility/ArchSpec.cpp (original)<br>
> +++ lldb/trunk/source/Utility/ArchSpec.cpp Thu Jan  4 18:50:24 2018<br>
> @@ -890,7 +890,12 @@ void ArchSpec::MergeFrom(const ArchSpec<br>
>      GetTriple().setOS(other.GetTriple().getOS());<br>
>    if (GetTriple().getArch() == llvm::Triple::UnknownArch) {<br>
>      GetTriple().setArch(other.GetTriple().getArch());<br>
> -    UpdateCore();<br>
> +<br>
> +    // MachO unknown64 isn't really invalid as the debugger can<br>
> +    // still obtain information from the binary, e.g. line tables.<br>
> +    // As such, we don't update the core here.<br>
> +    if (other.GetCore() != eCore_uknownMach64)<br>
> +      UpdateCore();<br>
>    }<br>
>    if (GetTriple().getEnvironment() == llvm::Triple::UnknownEnvironment &&<br>
>        !TripleVendorWasSpecified()) {<br>
><br>
><br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>