<div dir="ltr">Long term it would be nice if we could get all these register definitions automatically generated with llvm-tblgen.  That's a big undertaking, though.</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 11, 2017 at 7:27 PM Vedant Kumar via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vedantk<br>
Date: Mon Dec 11 19:27:13 2017<br>
New Revision: 320456<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=320456&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=320456&view=rev</a><br>
Log:<br>
Avoid module import in a textual header, NFC<br>
<br>
This unbreaks the lldb modules build (-DLLVM_ENABLE_MODULES=On).<br>
<br>
Modified:<br>
    lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h<br>
<br>
Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h?rev=320456&r1=320455&r2=320456&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h?rev=320456&r1=320455&r2=320456&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h (original)<br>
+++ lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_x86_64.h Mon Dec 11 19:27:13 2017<br>
@@ -7,11 +7,8 @@<br>
 //<br>
 //===----------------------------------------------------------------------===//<br>
<br>
-#include "llvm/Support/Compiler.h"<br>
-#include <cstddef><br>
-#include <cstdint><br>
-<br>
-// Project includes<br>
+// This file is meant to be textually included. Do not #include modular<br>
+// headers here.<br>
<br>
 // Computes the offset of the given GPR in the user data area.<br>
 #define GPR_OFFSET(regname) (LLVM_EXTENSION offsetof(GPR, regname))<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>