<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Please do add this as that is the best solution. If no other plug-ins currently support it, it is fine to just stub out the virtual function in SymbolFile::FindTypesByRegex(...) to return Error("unsupported") and we can implement it in the regex search later for DWARF and other plug-ins.<div class=""><br class=""></div><div class="">Greg</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 11, 2017, at 1:40 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">SymbolFile does not have a method for searching by regex. There is a FindFunctions and FindGlobalVariables that allows searching by regex, but not one for types. That said, one could be added to the base class, yes. That does seem like a better long term solution.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Dec 11, 2017 at 1:37 PM Greg Clayton via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">clayborg added a comment.<br class="">
<br class="">
We should have a dedicated API that actually searches for types using a lldb_private::RegularExpression. Why do we even try to create a regular expression in SymbolFilePDB::FindTypes()? Was it used in testing? No API in LLDB currently expects this and all other API in LLDB has a separate function call that uses lldb_private::RegularExpression. We can add one if needed to the lldb_private::SymbolFile API. I don't like API that magically tries to look at something and tries to compile a regular expression on each invocation. Can we change this?<br class="">
<br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://reviews.llvm.org/D41086" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D41086</a><br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>