<div dir="ltr">That said, it does seem to make more sense as something you would do in the main lldb executable, and not in library code.</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Dec 2, 2017 at 12:26 PM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm curious why it's not working as it's supposed to work on these platforms.  When it does work, it's quite helpful</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Dec 2, 2017 at 12:24 PM Davide Italiano <<a href="mailto:dccitaliano@gmail.com" target="_blank">dccitaliano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Maybe we should remove this feature altogether?<br>
<br>
On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham via lldb-commits<br>
<<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
> Author: jingham<br>
> Date: Fri Dec  1 16:11:18 2017<br>
> New Revision: 319598<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=319598&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=319598&view=rev</a><br>
> Log:<br>
> Don't use llvm::EnablePrettyStackTrace on macOS.<br>
><br>
> LLDB.framework gets loaded into Xcode and other<br>
> frameworks, and this is inserting a signal handler into<br>
> the process even when lldb isn't used.  I have a bunch<br>
> of reports of this SignalHandler blowing out the stack,<br>
> which renders crash reports for the crash useless.<br>
><br>
> And in any case libraries really shouldn't be installing<br>
> signal handlers.<br>
><br>
> I only turned this off for APPLE platforms, I'll let<br>
> the maintainers of other platforms decide what policy<br>
> they want to have w.r.t. this.<br>
><br>
> Modified:<br>
>     lldb/trunk/source/Initialization/SystemInitializerCommon.cpp<br>
><br>
> Modified: lldb/trunk/source/Initialization/SystemInitializerCommon.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Initialization/SystemInitializerCommon.cpp?rev=319598&r1=319597&r2=319598&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Initialization/SystemInitializerCommon.cpp?rev=319598&r1=319597&r2=319598&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/source/Initialization/SystemInitializerCommon.cpp (original)<br>
> +++ lldb/trunk/source/Initialization/SystemInitializerCommon.cpp Fri Dec  1 16:11:18 2017<br>
> @@ -69,7 +69,9 @@ void SystemInitializerCommon::Initialize<br>
>    }<br>
>  #endif<br>
><br>
> +#if not defined(__APPLE__)<br>
>    llvm::EnablePrettyStackTrace();<br>
> +#endif<br>
>    Log::Initialize();<br>
>    HostInfo::Initialize();<br>
>    static Timer::Category func_cat(LLVM_PRETTY_FUNCTION);<br>
><br>
><br>
> _______________________________________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div></blockquote></div>