Super awesome. When you do move it to Utility, can you run the deps python script to see if any cmake dependencies can be updated?<br><div class="gmail_quote"><div dir="ltr">On Fri, Nov 10, 2017 at 4:02 AM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath created this revision.<br>
<br>
In <a href="https://reviews.llvm.org/D39387" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39387</a>, I was quick to jump to conclusion that ArchSpec has no<br>
external dependencies. It turns there still was one call to<br>
HostInfo::GetArchitecture left -- for implementing the "systemArch32"<br>
architecture and friends.<br>
<br>
Since GetAugmentedArchSpec is the place we handle these "incomplete"<br>
triples that don't specify os or vendor and "systemArch" looks very much<br>
like an incomplete triple, I move its handling there.<br>
<br>
After this ArchSpec *really* does not have external dependencies, and<br>
I'd like to move it to the Utility module as a follow-up.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39896" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39896</a><br>
<br>
Files:<br>
include/lldb/Host/HostInfoBase.h<br>
source/Core/ArchSpec.cpp<br>
source/Host/common/HostInfoBase.cpp<br>
source/Target/Platform.cpp<br>
unittests/Host/HostInfoTest.cpp<br>
<br>
</blockquote></div>