<div dir="ltr"><div>There have been a few suggestions that I could just use a script to solve this "problem" -- poor startup performance of clangdiag.</div><div><br></div><div>However, this patch was not submitted to solve a particular problem. It was submitted in response to Jim's suggestion:</div><div><br></div><div><span style="color:rgb(80,0,80);font-size:12.8px">On Mon, Oct 23, 2017 at 6:25 PM, Jim Ingham </span><span dir="ltr" style="color:rgb(80,0,80);font-size:12.8px"><<a href="mailto:jingham@apple.com" target="_blank">jingham@apple.com</a>></span><span style="color:rgb(80,0,80);font-size:12.8px"> <wbr>wrote:</span><br style="color:rgb(80,0,80);font-size:12.8px"><blockquote class="gmail_quote" style="color:rgb(80,0,80);font-size:12.8px;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Yeah, that would be easy to implement from the command line, maybe add a --file-is-regex flag or something.<br><br>From the SB API it would be better to have something like:<br><br>SBFileList SBTarget.GetFileListMatchingRe<wbr>gex("regex")<br><br>Please file an enhancement request for these of hack'em in if you're so motivated.<br></blockquote><div><br></div><div>clangdiag was only provided as a motivating example.</div><div><br></div><div>As for the contention that this would be a little used option, I'd argue the opposite. </div><div><br></div><div>I use regular expressions all the time, and I'm sure I'm not alone. Once uses are given the choice of providing multiple '-f' and/or '-s' options compare to a single, more powerful '-z' or '-Z' option, I'd bet most of them would start using the new options exclusively. I certainly would.</div></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 30, 2017 at 10:03 PM, Don Hinton <span dir="ltr"><<a href="mailto:hintonda@gmail.com" target="_blank">hintonda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'll add tests if it looks like it'll be accepted, but based on the initial response, that doesn't seem likely.<div><br></div><div>However, it was a good exercise and addressed the issues raised. </div><div><br></div><div>thanks again for all the feedback...</div><span class="HOEnZb"><font color="#888888"><div>don</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 30, 2017 at 9:44 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Asking again, but why can’t this be done in th the script for clangdiag? For example, there’s no tests for any of this in this patch. And it seems likely that it will be rarely used anyway. So I’m still not convinced the option-pollution and increased long term code maintenance burden of this underutilized codepath is worth the benefit.<br><br>Can you see if manually scanning for these files in python and then setting breakpoints on the right set of files solves the problem?<div class="m_65520219598673787HOEnZb"><div class="m_65520219598673787h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 30, 2017 at 9:00 PM Don Hinton via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hintonda updated this revision to Diff 120933.<br>
hintonda added a comment.<br>
<br>
- Remove prefix and add options.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39436" rel="noreferrer" target="_blank">https://reviews.llvm.org/D3943<wbr>6</a><br>
<br>
Files:<br>
include/lldb/Utility/FileSpec.<wbr>h<br>
source/Commands/CommandObjectB<wbr>reakpoint.cpp<br>
source/Utility/FileSpec.cpp<br>
<br>
</blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>