<div dir="ltr">This changes nothing except for 32bit Windows, which used to not be able to benefit from ABISysV_i386 but can use it now. The ABI support is tested independently from Windows itself.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 26, 2017 at 10:25 AM Davide Italiano <<a href="mailto:dccitaliano@gmail.com">dccitaliano@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer via lldb-commits<br>
<<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br>
> Author: sas<br>
> Date: Thu Oct 26 10:04:20 2017<br>
> New Revision: 316673<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=316673&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=316673&view=rev</a><br>
> Log:<br>
> Allow SysV-i386 ABI on everything other than Apple targets<br>
><br>
> Summary:<br>
> This matches other SysV ABIs that are different on Apple and non-Apple targets,<br>
> like `ABISysV_arm.cpp` for instance.<br>
><br>
> Reviewers: clayborg, emaste<br>
><br>
> Subscribers: aemerson, kristof.beyls, lldb-commits<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D39335" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39335</a><br>
><br>
> Modified:<br>
>     lldb/trunk/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp<br>
><br>
> Modified: lldb/trunk/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp?rev=316673&r1=316672&r2=316673&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp?rev=316673&r1=316672&r2=316673&view=diff</a><br>
> ==============================================================================<br>
> --- lldb/trunk/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp (original)<br>
> +++ lldb/trunk/source/Plugins/ABI/SysV-i386/ABISysV_i386.cpp Thu Oct 26 10:04:20 2017<br>
> @@ -205,11 +205,12 @@ ABISysV_i386::GetRegisterInfoArray(uint3<br>
>  ABISP<br>
>  ABISysV_i386::CreateInstance(lldb::ProcessSP process_sp, const ArchSpec &arch) {<br>
>    static ABISP g_abi_sp;<br>
> -  if ((arch.GetTriple().getArch() == llvm::Triple::x86) &&<br>
> -      (arch.GetTriple().isOSLinux() || arch.GetTriple().isOSFreeBSD())) {<br>
> -    if (!g_abi_sp)<br>
> -      g_abi_sp.reset(new ABISysV_i386(process_sp));<br>
> -    return g_abi_sp;<br>
> +  if (arch.GetTriple().getVendor() != llvm::Triple::Apple) {<br>
> +    if (arch.GetTriple().getArch() == llvm::Triple::x86) {<br>
> +      if (!g_abi_sp)<br>
> +        g_abi_sp.reset(new ABISysV_i386(process_sp));<br>
> +      return g_abi_sp;<br>
> +    }<br>
>    }<br>
>    return ABISP();<br>
>  }<br>
><br>
<br>
This seems to change a fairly fundamental function for lldb-i386.<br>
I think we should have an unit-test for this. Sorry for being<br>
pedantic, I promise I'll stop after this one.<br>
<br>
Thanks,<br>
<br>
--<br>
Davide<br>
</blockquote></div><div dir="ltr">-- <br></div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <br>Stephane Sezer</div></div>