Can you run the analyze deps script before and after this patch, and update the cmake files if any deps are no longer necessary?<br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 26, 2017 at 8:24 AM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath created this revision.<br>
Herald added subscribers: mgorny, kubamracek.<br>
<br>
It had a dependency on StringConvert and file reading code, which is not<br>
in Utility. I've replaced that code by equivalent llvm operations.<br>
<br>
I've added a unit test to demonstrate that parsing a file still works.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D34625" rel="noreferrer" target="_blank">https://reviews.llvm.org/D34625</a><br>
<br>
Files:<br>
  include/lldb/Breakpoint/Breakpoint.h<br>
  include/lldb/Breakpoint/BreakpointOptions.h<br>
  include/lldb/Core/Event.h<br>
  include/lldb/Core/SearchFilter.h<br>
  include/lldb/Core/StructuredData.h<br>
  include/lldb/Core/StructuredDataImpl.h<br>
  include/lldb/Core/TraceOptions.h<br>
  include/lldb/DataFormatters/TypeSummary.h<br>
  include/lldb/DataFormatters/TypeSynthetic.h<br>
  include/lldb/Host/XML.h<br>
  include/lldb/Interpreter/ScriptInterpreter.h<br>
  include/lldb/Target/InstrumentationRuntime.h<br>
  include/lldb/Target/InstrumentationRuntimeStopInfo.h<br>
  include/lldb/Target/Process.h<br>
  include/lldb/Target/StopInfo.h<br>
  include/lldb/Target/StructuredDataPlugin.h<br>
  include/lldb/Target/SystemRuntime.h<br>
  include/lldb/Target/Thread.h<br>
  include/lldb/Target/ThreadPlanPython.h<br>
  include/lldb/Utility/JSON.h<br>
  include/lldb/Utility/StructuredData.h<br>
  source/API/SBStructuredData.cpp<br>
  source/API/SBThread.cpp<br>
  source/API/SBThreadPlan.cpp<br>
  source/Core/CMakeLists.txt<br>
  source/Core/FormatEntity.cpp<br>
  source/Core/StructuredData.cpp<br>
  source/Host/macosx/Host.mm<br>
  source/Host/windows/Host.cpp<br>
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h<br>
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h<br>
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h<br>
  source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.h<br>
  source/Plugins/InstrumentationRuntime/MainThreadChecker/MainThreadCheckerRuntime.h<br>
  source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.h<br>
  source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.h<br>
  source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp<br>
  source/Plugins/OperatingSystem/Python/OperatingSystemPython.h<br>
  source/Plugins/Process/Utility/DynamicRegisterInfo.cpp<br>
  source/Plugins/Process/Utility/DynamicRegisterInfo.h<br>
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h<br>
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp<br>
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.h<br>
  source/Plugins/Process/gdb-remote/ThreadGDBRemote.h<br>
  source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h<br>
  source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h<br>
  source/Target/Platform.cpp<br>
  source/Target/ThreadSpec.cpp<br>
  source/Utility/CMakeLists.txt<br>
  source/Utility/JSON.cpp<br>
  source/Utility/StructuredData.cpp<br>
  unittests/Core/CMakeLists.txt<br>
  unittests/Core/StructuredDataTest.cpp<br>
  unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp<br>
  unittests/Utility/CMakeLists.txt<br>
  unittests/Utility/Inputs/StructuredData-basic.json<br>
  unittests/Utility/StructuredDataTest.cpp<br>
  unittests/tools/lldb-server/tests/MessageObjects.cpp<br>
<br>
</blockquote></div>