No objections here<br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 23, 2017 at 5:48 AM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath created this revision.<br>
Herald added a subscriber: mgorny.<br>
<br>
The new UndefinedBehaviorSanitizer plugin was breaking file path length<br>
limits, because it's (fairly long name) appears multiple times in the<br>
path. Cmake ends up putting the object file at path<br>
tools/lldb/source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/CMakeFiles/lldbPluginInstrumentationRuntimeUndefinedBehaviorSanitizer.dir/UndefinedBehaviorSanitizerRuntime.cpp.obj<br>
which is 191 characters long and very dangerously close to the 260<br>
character path limit on windows systems (also, just the include line for<br>
that file was breaking the 80 character line limit).<br>
<br>
This renames the sanitizer plugins to use shorter names (asan, ubsan,<br>
tsan). I think this will still be quite understandable to everyone as<br>
those are the names everyone uses to refer to them anyway.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D34553" rel="noreferrer" target="_blank">https://reviews.llvm.org/D34553</a><br>
<br>
Files:<br>
  source/API/SystemInitializerFull.cpp<br>
  source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.cpp<br>
  source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.h<br>
  source/Plugins/InstrumentationRuntime/ASan/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp<br>
  source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.h<br>
  source/Plugins/InstrumentationRuntime/AddressSanitizer/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/TSan/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.cpp<br>
  source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.h<br>
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp<br>
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.h<br>
  source/Plugins/InstrumentationRuntime/UBSan/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp<br>
  source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.h<br>
  source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/CMakeLists.txt<br>
  source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/UndefinedBehaviorSanitizerRuntime.cpp<br>
  source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/UndefinedBehaviorSanitizerRuntime.h<br>
<br>
</blockquote></div>