<div dir="ltr">Note that even simpler would be<div><br></div><div>```</div><div>return llvm::find_if(col, in_range_predicate) != col.end();</div><div>```</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 8, 2017 at 4:50 PM Davide Italiano via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Thu Jun  8 18:49:56 2017<br>
New Revision: 305035<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=305035&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=305035&view=rev</a><br>
Log:<br>
[VMRange] Simplify a couple of member functions. NFCI.<br>
<br>
Modified:<br>
    lldb/trunk/source/Utility/VMRange.cpp<br>
<br>
Modified: lldb/trunk/source/Utility/VMRange.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/VMRange.cpp?rev=305035&r1=305034&r2=305035&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/VMRange.cpp?rev=305035&r1=305034&r2=305035&view=diff</a><br>
==============================================================================<br>
--- lldb/trunk/source/Utility/VMRange.cpp (original)<br>
+++ lldb/trunk/source/Utility/VMRange.cpp Thu Jun  8 18:49:56 2017<br>
@@ -25,23 +25,15 @@ using namespace lldb_private;<br>
 bool VMRange::ContainsValue(const VMRange::collection &coll,<br>
                             lldb::addr_t value) {<br>
   ValueInRangeUnaryPredicate in_range_predicate(value);<br>
-  VMRange::const_iterator pos;<br>
   VMRange::const_iterator end = coll.end();<br>
-  pos = std::find_if(coll.begin(), end, in_range_predicate);<br>
-  if (pos != end)<br>
-    return true;<br>
-  return false;<br>
+  return std::find_if(coll.begin(), end, in_range_predicate) != end;<br>
 }<br>
<br>
 bool VMRange::ContainsRange(const VMRange::collection &coll,<br>
                             const VMRange &range) {<br>
   RangeInRangeUnaryPredicate in_range_predicate(range);<br>
-  VMRange::const_iterator pos;<br>
   VMRange::const_iterator end = coll.end();<br>
-  pos = std::find_if(coll.begin(), end, in_range_predicate);<br>
-  if (pos != end)<br>
-    return true;<br>
-  return false;<br>
+  return std::find_if(coll.begin(), end, in_range_predicate) != end;<br>
 }<br>
<br>
 size_t VMRange::FindRangeIndexThatContainsValue(const VMRange::collection &coll,<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>