<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; } @font-face { font-family: "Cambria Math"; } @font-face { font-family: Calibri; } @font-face { font-family: Consolas; } p.MsoNormal, li.MsoNormal, div.MsoNormal { margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; } a:link, span.MsoHyperlink { color: rgb(5, 99, 193); text-decoration: underline; } a:visited, span.MsoHyperlinkFollowed { color: rgb(149, 79, 114); text-decoration: underline; } p.msonormal0, li.msonormal0, div.msonormal0 { margin-right: 0in; margin-left: 0in; font-size: 12pt; font-family: "Times New Roman", serif; } span.EmailStyle18 { font-family: Calibri, sans-serif; color: windowtext; } .MsoChpDefault { font-size: 10pt; font-family: Calibri, sans-serif; } @page WordSection1 { margin: 56.7pt 42.5pt 56.7pt 85.05pt; } div.WordSection1 { }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p></p>
<div>It looks ok to me. Please put the differences of .eh_frame and</div>
<div>.debug_frame that you described below in code comments too.</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Abid<br>
</div>
<p><br>
</p>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> lldb-commits <lldb-commits-bounces@lists.llvm.org> on behalf of Tatyana Krasnukha via lldb-commits <lldb-commits@lists.llvm.org><br>
<b>Sent:</b> Thursday, May 18, 2017 9:37 PM<br>
<b>To:</b> lldb-commits@lists.llvm.org<br>
<b>Subject:</b> [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section</font>
<div> </div>
</div>
<div>
<div class="WordSection1">
<p class="MsoNormal">Fix FDE indexing while scan debug_info section.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">There are some <span style="color:black">differences between eh_frame and debug_frame formats that are not considered by
</span><span style="font-size:9.5pt; font-family:Consolas; color:#2B91AF">DWARFCallFrameInfo</span><span style="font-size:9.5pt; font-family:Consolas; color:black">::GetFDEIndex</span><span style="color:black">.</span></p>
<p class="MsoNormal"><span style="color:black">An FDE entry contains </span>CIE_pointer
<span style="color:black">in debug_frame in same place as cie_id in eh_frame. As described in
<a href="http://www.dwarfstd.org/doc/dwarf-2.0.0.pdf">dwarf standard</a> (section 6.4.1),</span></p>
<p class="MsoNormal">CIE_pointer is an “offset into the .debug_frame section”. So, variable cie_offset should be equal
<span style="color:black">cie_id for debug_frame.</span></p>
<p class="MsoNormal"><span style="color:black">FDE entries with zeroth CIE pointer (which is actually placed in
</span>cie_id variable<span style="color:black">) shouldn’t be ignored also.</span></p>
<p class="MsoNormal"><span style="color:black"> </span></p>
<p class="MsoNormal"><span style="color:black">I had same issue as described here
<a href="http://lists.llvm.org/pipermail/lldb-dev/2014-October/005520.html">http://lists.llvm.org/pipermail/lldb-dev/2014-October/005520.html</a> , and these changes have fixed it for me (with "m_is_eh_frame" set to false, of course).
</span></p>
<p class="MsoNormal"><span style="font-family:"Courier New""> </span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Arial",sans-serif">Tatyana Krasnukha</span></b></p>
<p class="MsoNormal"><span style="font-size:9.0pt; font-family:"Arial",sans-serif">Software Engineer, Sr. I, Solutions Group, Synopsys Inc.</span></p>
<p class="MsoNormal"><span style="font-size:9.0pt; font-family:"Arial",sans-serif">w +7.812.408.7463 | m +7 981 757-4491 |
</span><a href="mailto:tatyana@synopsys.com"><span style="font-size:9.0pt; font-family:"Arial",sans-serif; color:blue">tatyana@synopsys.com</span></a><span style="font-size:9.0pt; font-family:"Arial",sans-serif"></span></p>
<p class="MsoNormal"> </p>
</div>
</div>
</div>
</body>
</html>