<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
p.msonormal00, li.msonormal00, div.msonormal00
{mso-style-name:msonormal0;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
p.msochpdefault, li.msochpdefault, div.msochpdefault
{mso-style-name:msochpdefault;
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
span.emailstyle18
{mso-style-name:emailstyle18;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:56.7pt 42.5pt 56.7pt 85.05pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Done. I have also added a little change which allow to use debug_info section when eh_frame is absent. This case really can take place on some platforms.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Tatyana<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Abid, Hafiz [mailto:Hafiz_Abid@mentor.com] <br>
<b>Sent:</b> Tuesday, 23 May, 2017 3:31 PM<br>
<b>To:</b> Tatyana Krasnukha <Tatyana.Krasnukha@synopsys.com>; lldb-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">It looks ok to me. Please put the differences of .eh_frame and<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">.debug_frame that you described below in code comments too.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Thanks,<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">Abid<o:p></o:p></span></p>
</div>
<p><span style="font-family:"Calibri",sans-serif;color:black"><o:p> </o:p></span></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span style="font-size:12.0pt;color:#212121">
<hr size="2" width="98%" align="center">
</span></div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> lldb-commits <<a href="mailto:lldb-commits-bounces@lists.llvm.org">lldb-commits-bounces@lists.llvm.org</a>> on behalf of Tatyana Krasnukha via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>><br>
<b>Sent:</b> Thursday, May 18, 2017 9:37 PM<br>
<b>To:</b> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<b>Subject:</b> [Lldb-commits] Patch for fixing FDE indexing when scan debug_info section</span><span style="font-size:12.0pt;color:#212121">
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#212121"> <o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="color:#212121">Fix FDE indexing while scan debug_info section.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#212121"> <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#212121">There are some </span><span style="color:black">differences between eh_frame and debug_frame formats that are not considered by
</span><span style="font-size:9.5pt;font-family:Consolas;color:#2B91AF">DWARFCallFrameInfo</span><span style="font-size:9.5pt;font-family:Consolas;color:black">::GetFDEIndex</span><span style="color:black">.</span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">An FDE entry contains </span><span style="color:#212121">CIE_pointer
</span><span style="color:black">in debug_frame in same place as cie_id in eh_frame. As described in
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__www.dwarfstd.org_doc_dwarf-2D2.0.0.pdf&d=DwMFAw&c=DPL6_X_6JkXFx7AXWqB0tg&r=yfnu24japkhNGh-WqJObHXmH3mINtC_2FO828lrNpM0&m=6bXYUUYhGtSz4V-aPy_DuviU1kYtmn9rHUU-2aIGDzE&s=kMPV12z6OBKSq3lC8HgNgMkv23SamtORaFALS-I-Vts&e=">
dwarf standard</a> (section 6.4.1),</span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#212121">CIE_pointer is an “offset into the .debug_frame section”. So, variable cie_offset should be equal
</span><span style="color:black">cie_id for debug_frame.</span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">FDE entries with zeroth CIE pointer (which is actually placed in
</span><span style="color:#212121">cie_id variable</span><span style="color:black">) shouldn’t be ignored also.</span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black"> </span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:black">I had same issue as described here
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_pipermail_lldb-2Ddev_2014-2DOctober_005520.html&d=DwMFAw&c=DPL6_X_6JkXFx7AXWqB0tg&r=yfnu24japkhNGh-WqJObHXmH3mINtC_2FO828lrNpM0&m=6bXYUUYhGtSz4V-aPy_DuviU1kYtmn9rHUU-2aIGDzE&s=7NGym3Cx6gVwlzBRE44Zm6Teee6tMi9Iq-BTRMjM6Pc&e=">
http://lists.llvm.org/pipermail/lldb-dev/2014-October/005520.html</a> , and these changes have fixed it for me (with "m_is_eh_frame" set to false, of course).
</span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Courier New";color:#212121"> </span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Arial",sans-serif;color:#212121">Tatyana Krasnukha</span></b><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Arial",sans-serif;color:#212121">Software Engineer, Sr. I, Solutions Group, Synopsys Inc.</span><span style="color:#212121"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Arial",sans-serif;color:#212121">w +7.812.408.7463 | m +7 981 757-4491 |
</span><span style="color:#212121"><a href="mailto:tatyana@synopsys.com"><span style="font-size:9.0pt;font-family:"Arial",sans-serif;color:blue">tatyana@synopsys.com</span></a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#212121"> <o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>