<div dir="ltr">labath is in Europe, so he will probably not see this until tonight.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 10, 2017 at 3:31 PM Jonathan Roelofs via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jroelofs added a comment.<br class="gmail_msg">
<br class="gmail_msg">
In <a href="https://reviews.llvm.org/D30844#698294" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30844#698294</a>, @zturner wrote:<br class="gmail_msg">
<br class="gmail_msg">
> The test suite is full of flakiness, but as long as it's the same before and after your change, it doesn't seem like anything is broken.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Results are pretty much the same, with 1 or 2 twinkling tests (couldn't say which ones it is though: I'm not at all familiar with lldb's test harness).<br class="gmail_msg">
<br class="gmail_msg">
Before:<br class="gmail_msg">
<br class="gmail_msg">
  ===================<br class="gmail_msg">
  Test Result Summary<br class="gmail_msg">
  ===================<br class="gmail_msg">
  Test Methods:       1897<br class="gmail_msg">
  Reruns:               14<br class="gmail_msg">
  Success:             877<br class="gmail_msg">
  Expected Failure:    109<br class="gmail_msg">
  Failure:             306<br class="gmail_msg">
  Error:                21<br class="gmail_msg">
  Exceptional Exit:      0<br class="gmail_msg">
  Unexpected Success:   15<br class="gmail_msg">
  Skip:                568<br class="gmail_msg">
  Timeout:               1<br class="gmail_msg">
  Expected Timeout:      0<br class="gmail_msg">
<br class="gmail_msg">
After:<br class="gmail_msg">
<br class="gmail_msg">
  ===================<br class="gmail_msg">
  Test Result Summary<br class="gmail_msg">
  ===================<br class="gmail_msg">
  Test Methods:       1897<br class="gmail_msg">
  Reruns:               14<br class="gmail_msg">
  Success:             876<br class="gmail_msg">
  Expected Failure:    108<br class="gmail_msg">
  Failure:             307<br class="gmail_msg">
  Error:                21<br class="gmail_msg">
  Exceptional Exit:      0<br class="gmail_msg">
  Unexpected Success:   16<br class="gmail_msg">
  Skip:                568<br class="gmail_msg">
  Timeout:               1<br class="gmail_msg">
  Expected Timeout:      0<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30844" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30844</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>