Yes it was a debug build <br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 8, 2017 at 2:45 AM Pavel Labath <<a href="mailto:labath@google.com">labath@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I've tried it out not and it works -- I think it's good to go then.<br class="gmail_msg">
<br class="gmail_msg">
The unit tests, was that a debug build by any chance? I think we are<br class="gmail_msg">
missing some dependency there which shows up only on debug builds, but<br class="gmail_msg">
I haven't dug into that yet.<br class="gmail_msg">
<br class="gmail_msg">
On 7 March 2017 at 22:28, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
> I can run build TargetTests though (I guess it doesn't depend on editline),<br class="gmail_msg">
> and that one passes.<br class="gmail_msg">
><br class="gmail_msg">
> On Tue, Mar 7, 2017 at 2:26 PM Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> =============<br class="gmail_msg">
>> Issue Details<br class="gmail_msg">
>> =============<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_and_run_command_dwarf<br class="gmail_msg">
>> (lang/c/register_variables/TestRegisterVariables.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_and_run_command_dwo<br class="gmail_msg">
>> (lang/c/register_variables/TestRegisterVariables.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_dwarf<br class="gmail_msg">
>> (functionalities/thread/exit_during_break/TestExitDuringBreak.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_dwo<br class="gmail_msg">
>> (functionalities/thread/exit_during_break/TestExitDuringBreak.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_lldbmi_gdb_set_target_async_off<br class="gmail_msg">
>> (tools/lldb-mi/TestMiGdbSetShow.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_lldbmi_process_output<br class="gmail_msg">
>> (tools/lldb-mi/syntax/TestMiSyntax.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_lldbmi_settings_set_target_run_args_after<br class="gmail_msg">
>> (tools/lldb-mi/interpreter/TestMiInterpreterExec.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_multiple_debuggers_dwarf<br class="gmail_msg">
>> (api/multiple-debuggers/TestMultipleDebuggers.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_process_interrupt_dwo<br class="gmail_msg">
>> (functionalities/thread/state/TestThreadStates.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwarf<br class="gmail_msg">
>> (api/multithreaded/TestMultithreaded.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwo<br class="gmail_msg">
>> (api/multithreaded/TestMultithreaded.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_with_dwarf (lang/cpp/printf/TestPrintf.py)<br class="gmail_msg">
>> UNEXPECTED SUCCESS: test_with_dwo (lang/cpp/printf/TestPrintf.py)<br class="gmail_msg">
>><br class="gmail_msg">
>> ===================<br class="gmail_msg">
>> Test Result Summary<br class="gmail_msg">
>> ===================<br class="gmail_msg">
>> Test Methods: 1905<br class="gmail_msg">
>> Reruns: 0<br class="gmail_msg">
>> Success: 1203<br class="gmail_msg">
>> Expected Failure: 117<br class="gmail_msg">
>> Failure: 0<br class="gmail_msg">
>> Error: 0<br class="gmail_msg">
>> Exceptional Exit: 0<br class="gmail_msg">
>> Unexpected Success: 13<br class="gmail_msg">
>> Skip: 572<br class="gmail_msg">
>> Timeout: 0<br class="gmail_msg">
>> Expected Timeout: 0<br class="gmail_msg">
>><br class="gmail_msg">
>> I can't seem to run unittests because I'm getting undefined references to<br class="gmail_msg">
>> editline which I haven't dug into, but the regular tests pass.<br class="gmail_msg">
>><br class="gmail_msg">
>> On Tue, Mar 7, 2017 at 1:47 PM Pavel Labath via Phabricator<br class="gmail_msg">
>> <<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br class="gmail_msg">
>>><br class="gmail_msg">
>>> labath accepted this revision.<br class="gmail_msg">
>>> labath added a comment.<br class="gmail_msg">
>>> This revision is now accepted and ready to land.<br class="gmail_msg">
>>><br class="gmail_msg">
>>> OK, let's give this another shot. (I haven't tried it on linux yet, so if<br class="gmail_msg">
>>> you haven't either then let's wait until tomorrow, or maybe @eugene could<br class="gmail_msg">
>>> try it out (?)). I don't think we need to be worried about symlink overwrite<br class="gmail_msg">
>>> in the ModuleCache test.<br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
>>> ================<br class="gmail_msg">
>>> Comment at: llvm/include/llvm/Support/FileSystem.h:500<br class="gmail_msg">
>>> +/// @param result Set to true if \a path is a directory (after following<br class="gmail_msg">
>>> +/// symlinks, false if it is not. Undefined otherwise.<br class="gmail_msg">
>>> /// @returns errc::success if result has been successfully set,<br class="gmail_msg">
>>> otherwise a<br class="gmail_msg">
>>> ----------------<br class="gmail_msg">
>>> missing closing paren here<br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
>>> <a href="https://reviews.llvm.org/D30698" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30698</a><br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
>>><br class="gmail_msg">
><br class="gmail_msg">
</blockquote></div>