<div dir="ltr"><div>=============</div><div>Issue Details</div><div>=============</div><div>UNEXPECTED SUCCESS: test_and_run_command_dwarf (lang/c/register_variables/TestRegisterVariables.py)</div><div>UNEXPECTED SUCCESS: test_and_run_command_dwo (lang/c/register_variables/TestRegisterVariables.py)</div><div>UNEXPECTED SUCCESS: test_dwarf (functionalities/thread/exit_during_break/TestExitDuringBreak.py)</div><div>UNEXPECTED SUCCESS: test_dwo (functionalities/thread/exit_during_break/TestExitDuringBreak.py)</div><div>UNEXPECTED SUCCESS: test_lldbmi_gdb_set_target_async_off (tools/lldb-mi/TestMiGdbSetShow.py)</div><div>UNEXPECTED SUCCESS: test_lldbmi_process_output (tools/lldb-mi/syntax/TestMiSyntax.py)</div><div>UNEXPECTED SUCCESS: test_lldbmi_settings_set_target_run_args_after (tools/lldb-mi/interpreter/TestMiInterpreterExec.py)</div><div>UNEXPECTED SUCCESS: test_multiple_debuggers_dwarf (api/multiple-debuggers/TestMultipleDebuggers.py)</div><div>UNEXPECTED SUCCESS: test_process_interrupt_dwo (functionalities/thread/state/TestThreadStates.py)</div><div>UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwarf (api/multithreaded/TestMultithreaded.py)</div><div>UNEXPECTED SUCCESS: test_sb_api_listener_resume_dwo (api/multithreaded/TestMultithreaded.py)</div><div>UNEXPECTED SUCCESS: test_with_dwarf (lang/cpp/printf/TestPrintf.py)</div><div>UNEXPECTED SUCCESS: test_with_dwo (lang/cpp/printf/TestPrintf.py)</div><div><br></div><div>===================</div><div>Test Result Summary</div><div>===================</div><div>Test Methods:       1905</div><div>Reruns:                0</div><div>Success:            1203</div><div>Expected Failure:    117</div><div>Failure:               0</div><div>Error:                 0</div><div>Exceptional Exit:      0</div><div>Unexpected Success:   13</div><div>Skip:                572</div><div>Timeout:               0</div><div>Expected Timeout:      0</div><div><br></div><div>I can't seem to run unittests because I'm getting undefined references to editline which I haven't dug into, but the regular tests pass.</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 7, 2017 at 1:47 PM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath accepted this revision.<br class="gmail_msg">
labath added a comment.<br class="gmail_msg">
This revision is now accepted and ready to land.<br class="gmail_msg">
<br class="gmail_msg">
OK, let's give this another shot. (I haven't tried it on linux yet, so if you haven't either then let's wait until tomorrow, or maybe @eugene could try it out (?)). I don't think we need to be worried about symlink overwrite in the ModuleCache test.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: llvm/include/llvm/Support/FileSystem.h:500<br class="gmail_msg">
+/// @param result Set to true if \a path is a directory (after following<br class="gmail_msg">
+///               symlinks, false if it is not. Undefined otherwise.<br class="gmail_msg">
 /// @returns errc::success if result has been successfully set, otherwise a<br class="gmail_msg">
----------------<br class="gmail_msg">
missing closing paren here<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30698" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30698</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>