<div dir="ltr">I usually do this, like when I'm changing #includes I do grep / replace. In this case it was a little tricky because a name liked Dump is so common that if my code doesn't compile it, I might not catch it. (Granted, I should have caught DumpHexBytes, not sure how I missed that one).</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 3, 2017 at 4:45 PM Jim Ingham <<a href="mailto:jingham@apple.com">jingham@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'll get this working, but in the future when you are making changes of this sort please chase down all the instances of functions you are changing, even in files you aren't building locally. There might be a use that your conversion doesn't handle, and you don't want to find that out after you've gone a ways down a particular path.<br class="gmail_msg">
<br class="gmail_msg">
Jim<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
> On Mar 3, 2017, at 4:34 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> Is that still failing? Extractor.dump(...) should be replaced by DumpDataExtractor(Extractor, ...) and then everything will work<br class="gmail_msg">
><br class="gmail_msg">
> On Fri, Mar 3, 2017 at 4:29 PM Tim Hammerquist <<a href="mailto:thammerquist@apple.com" class="gmail_msg" target="_blank">thammerquist@apple.com</a>> wrote:<br class="gmail_msg">
> Hi Zachary!<br class="gmail_msg">
><br class="gmail_msg">
> Thank you for your prompt attention!<br class="gmail_msg">
><br class="gmail_msg">
> I notice you added DumpHexBytes() back, but Dump() is still missing. Was Dump() slated for a later patch?<br class="gmail_msg">
><br class="gmail_msg">
> -Tim<br class="gmail_msg">
><br class="gmail_msg">
>> On 3 Mar 2017, at 15:48, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> Yea, it was a static method of DataExtractor before. I noticed the same thing when i saw it wasn't using any methods of DataExtractor. Oops! Anyway since this is no less weird than before I'll leave it this way for now until we figure out something better.<br class="gmail_msg">
>><br class="gmail_msg">
>> On Fri, Mar 3, 2017 at 3:46 PM Jim Ingham <<a href="mailto:jingham@apple.com" class="gmail_msg" target="_blank">jingham@apple.com</a>> wrote:<br class="gmail_msg">
>> Yeah, looks like you need to keep DumpHexBytes in DumpDataExtractor. That's a little weird because it doesn't actually take a DataExtractor, but...<br class="gmail_msg">
>><br class="gmail_msg">
>> Jim<br class="gmail_msg">
>><br class="gmail_msg">
>> > On Mar 3, 2017, at 3:45 PM, Zachary Turner via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > I can fix that, I didn't see it in my tests because it doesn't compile that file on Windows. I'll get a fix in shortly.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > On Fri, Mar 3, 2017 at 3:38 PM Tim Hammerquist <<a href="mailto:thammerquist@apple.com" class="gmail_msg" target="_blank">thammerquist@apple.com</a>> wrote:<br class="gmail_msg">
>> > Sure, Zachary. I try to step in when I can.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > Now that you mention it, your r296910 (DumpDataExtractor) patch is breaking building CommunicationKDP.cpp in MacOSX-Kernel. Namely, the removal of Dump/DumpHexBytes from DataExtractor. I've coordinated with the Apple LLDB team on how they want to follow up on that, but they might want to reach out to you about it.<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > -Tim<br class="gmail_msg">
>> ><br class="gmail_msg">
>> >> On 3 Mar 2017, at 15:33, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> Thanks Tim!<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> I have a few more file moves coming up as well, sorry for the trouble!<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> On Fri, Mar 3, 2017 at 3:29 PM Tim Hammerquist via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
>> >> Author: penryu<br class="gmail_msg">
>> >> Date: Fri Mar 3 17:17:29 2017<br class="gmail_msg">
>> >> New Revision: 296925<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296925&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=296925&view=rev</a><br class="gmail_msg">
>> >> Log:<br class="gmail_msg">
>> >> Fix Darwin failures introduced in r296909<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> Modified:<br class="gmail_msg">
>> >> lldb/trunk/lldb.xcodeproj/project.pbxproj<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj<br class="gmail_msg">
>> >> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925&r1=296924&r2=296925&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/lldb.xcodeproj/project.pbxproj?rev=296925&r1=296924&r2=296925&view=diff</a><br class="gmail_msg">
>> >> ==============================================================================<br class="gmail_msg">
>> >> --- lldb/trunk/lldb.xcodeproj/project.pbxproj (original)<br class="gmail_msg">
>> >> +++ lldb/trunk/lldb.xcodeproj/project.pbxproj Fri Mar 3 17:17:29 2017<br class="gmail_msg">
>> >> @@ -2052,7 +2052,7 @@<br class="gmail_msg">
>> >> 26BC7D6310F1B77400F91463 /* FileSpecList.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = FileSpecList.h; path = include/lldb/Core/FileSpecList.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7D6510F1B77400F91463 /* IOStreamMacros.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = IOStreamMacros.h; path = include/lldb/Core/IOStreamMacros.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7D6710F1B77400F91463 /* Listener.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Listener.h; path = include/lldb/Core/Listener.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> - 26BC7D6810F1B77400F91463 /* Log.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Log.h; path = include/lldb/Core/Log.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> + 26BC7D6810F1B77400F91463 /* Log.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Log.h; path = include/lldb/Utility/Log.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7D6910F1B77400F91463 /* Mangled.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Mangled.h; path = include/lldb/Core/Mangled.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7D6A10F1B77400F91463 /* Module.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Module.h; path = include/lldb/Core/Module.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7D6B10F1B77400F91463 /* ModuleChild.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = ModuleChild.h; path = include/lldb/Core/ModuleChild.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> @@ -2139,7 +2139,7 @@<br class="gmail_msg">
>> >> 26BC7E7910F1B85900F91463 /* Event.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Event.cpp; path = source/Core/Event.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7E7B10F1B85900F91463 /* FileSpecList.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = FileSpecList.cpp; path = source/Core/FileSpecList.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7E7E10F1B85900F91463 /* Listener.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Listener.cpp; path = source/Core/Listener.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> - 26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Log.cpp; path = source/Core/Log.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> + 26BC7E7F10F1B85900F91463 /* Log.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Log.cpp; path = source/Utility/Log.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7E8010F1B85900F91463 /* Mangled.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Mangled.cpp; path = source/Core/Mangled.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7E8110F1B85900F91463 /* Module.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Module.cpp; path = source/Core/Module.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 26BC7E8210F1B85900F91463 /* ModuleChild.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = ModuleChild.cpp; path = source/Core/ModuleChild.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> @@ -2335,8 +2335,8 @@<br class="gmail_msg">
>> >> 33E5E8411A672A240024ED68 /* StringConvert.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = StringConvert.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 33E5E8451A6736D30024ED68 /* StringConvert.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = StringConvert.h; path = include/lldb/Host/StringConvert.h; sourceTree = SOURCE_ROOT; };<br class="gmail_msg">
>> >> 3F5E8AF31A40D4A500A73232 /* PipeBase.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = PipeBase.h; path = include/lldb/Host/PipeBase.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> - 3F8160A51AB9F7DD001DA9DF /* Logging.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Logging.cpp; path = source/Core/Logging.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> - 3F8160A71AB9F809001DA9DF /* Logging.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = Logging.h; path = include/lldb/Core/Logging.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> + 3F8160A51AB9F7DD001DA9DF /* Logging.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Logging.cpp; path = source/Utility/Logging.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> + 3F8160A71AB9F809001DA9DF /* Logging.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = Logging.h; path = include/lldb/Utility/Logging.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 3F8169181ABA2419001DA9DF /* NameMatches.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = NameMatches.cpp; path = source/Utility/NameMatches.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 3F81691C1ABA242B001DA9DF /* NameMatches.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = NameMatches.h; path = include/lldb/Utility/NameMatches.h; sourceTree = "<group>"; };<br class="gmail_msg">
>> >> 3F81692A1ABB7A16001DA9DF /* SystemInitializerFull.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = SystemInitializerFull.cpp; path = source/API/SystemInitializerFull.cpp; sourceTree = "<group>"; };<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> _______________________________________________<br class="gmail_msg">
>> >> lldb-commits mailing list<br class="gmail_msg">
>> >> <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
>> >> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
>> ><br class="gmail_msg">
>> > _______________________________________________<br class="gmail_msg">
>> > lldb-commits mailing list<br class="gmail_msg">
>> > <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
>> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
>><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>