<div dir="ltr">lgtm <br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 1, 2017 at 4:26 PM Jason Majors via Phabricator via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jmajors created this revision.<br class="gmail_msg">
<br class="gmail_msg">
It does not change members or call non-const members.<br class="gmail_msg">
HostInfo::GetArchitecture() returns a const object ref (maybe others?),<br class="gmail_msg">
which can't access the non-const function.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30515" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30515</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  include/lldb/Core/ArchSpec.h<br class="gmail_msg">
  source/Core/ArchSpec.cpp<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: source/Core/ArchSpec.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- source/Core/ArchSpec.cpp<br class="gmail_msg">
+++ source/Core/ArchSpec.cpp<br class="gmail_msg">
@@ -657,7 +657,7 @@<br class="gmail_msg">
   SetFlags(flag);<br class="gmail_msg">
 }<br class="gmail_msg">
<br class="gmail_msg">
-std::string ArchSpec::GetClangTargetCPU() {<br class="gmail_msg">
+std::string ArchSpec::GetClangTargetCPU() const {<br class="gmail_msg">
   std::string cpu;<br class="gmail_msg">
   const llvm::Triple::ArchType machine = GetMachine();<br class="gmail_msg">
<br class="gmail_msg">
Index: include/lldb/Core/ArchSpec.h<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- include/lldb/Core/ArchSpec.h<br class="gmail_msg">
+++ include/lldb/Core/ArchSpec.h<br class="gmail_msg">
@@ -307,7 +307,7 @@<br class="gmail_msg">
   /// @return A string representing target CPU for the current<br class="gmail_msg">
   ///         architecture.<br class="gmail_msg">
   //------------------------------------------------------------------<br class="gmail_msg">
-  std::string GetClangTargetCPU();<br class="gmail_msg">
+  std::string GetClangTargetCPU() const;<br class="gmail_msg">
<br class="gmail_msg">
   //------------------------------------------------------------------<br class="gmail_msg">
   /// Return a string representing target application ABI.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>