<div>Sorry about that, it's often frustrating to check every single buildbot that was failing because 99% of the time they fail for exactly the same reason, and when one is fixed all of them get fixed.  In this case i used <a href="http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/5417" class="gmail_msg" target="_blank">http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/5417</a> as evidence that the change was good, but in hindsight this one doesn't run tests, so that was my mistake.<br class="gmail_msg"></div><div><br></div><div>Regarding the tests, i ran all of UtilityTests but not the whole test suite.  Again my mistake, was trying to cut corners and it backfired :(</div><div><br></div><div><br></div><div><br></div><div><div class="gmail_quote gmail_msg"><div class="gmail_msg">On Fri, Feb 17, 2017 at 2:35 AM Pavel Labath <<a href="mailto:labath@google.com" class="gmail_msg" target="_blank">labath@google.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Zach,<br class="gmail_msg">
<br class="gmail_msg">
after you think you've fixed the build, could you check back on the<br class="gmail_msg">
buildbot to make sure that it actually fixes things? In this case you<br class="gmail_msg">
would've seen that after the build is fixed, the next thing it runs<br class="gmail_msg">
into is about a dozen test failures.<br class="gmail_msg">
<br class="gmail_msg">
In fact, this breakage was something that would have been already<br class="gmail_msg">
caught by running the unit tests on windows, which leads me to believe<br class="gmail_msg">
you didn't run them before submission.<br class="gmail_msg">
<br class="gmail_msg">
Thanks,<br class="gmail_msg">
pl<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
2017-02-16 20:15 GMT+00:00 Zachary Turner via lldb-commits<br class="gmail_msg">
<<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>>:<br class="gmail_msg">
> Author: zturner<br class="gmail_msg">
> Date: Thu Feb 16 14:15:26 2017<br class="gmail_msg">
> New Revision: 295369<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=295369&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=295369&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> Fix build<br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>     lldb/trunk/source/Utility/VASprintf.cpp<br class="gmail_msg">
>     lldb/trunk/unittests/Utility/VASprintfTest.cpp<br class="gmail_msg">
><br class="gmail_msg">
> Modified: lldb/trunk/source/Utility/VASprintf.cpp<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/VASprintf.cpp?rev=295369&r1=295368&r2=295369&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/VASprintf.cpp?rev=295369&r1=295368&r2=295369&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- lldb/trunk/source/Utility/VASprintf.cpp (original)<br class="gmail_msg">
> +++ lldb/trunk/source/Utility/VASprintf.cpp Thu Feb 16 14:15:26 2017<br class="gmail_msg">
> @@ -7,7 +7,7 @@<br class="gmail_msg">
>  //<br class="gmail_msg">
>  //===----------------------------------------------------------------------===//<br class="gmail_msg">
><br class="gmail_msg">
> -#include "lldb/Utility/VASprintf.h"<br class="gmail_msg">
> +#include "lldb/Utility/VASPrintf.h"<br class="gmail_msg">
><br class="gmail_msg">
>  #include "llvm/ADT/SmallString.h"<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Modified: lldb/trunk/unittests/Utility/VASprintfTest.cpp<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/VASprintfTest.cpp?rev=295369&r1=295368&r2=295369&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/VASprintfTest.cpp?rev=295369&r1=295368&r2=295369&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- lldb/trunk/unittests/Utility/VASprintfTest.cpp (original)<br class="gmail_msg">
> +++ lldb/trunk/unittests/Utility/VASprintfTest.cpp Thu Feb 16 14:15:26 2017<br class="gmail_msg">
> @@ -7,7 +7,7 @@<br class="gmail_msg">
>  //<br class="gmail_msg">
>  //===----------------------------------------------------------------------===//<br class="gmail_msg">
><br class="gmail_msg">
> -#include "lldb/Utility/VASprintf.h"<br class="gmail_msg">
> +#include "lldb/Utility/VASPrintf.h"<br class="gmail_msg">
>  #include "llvm/ADT/SmallString.h"<br class="gmail_msg">
><br class="gmail_msg">
>  #include "gtest/gtest.h"<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> lldb-commits mailing list<br class="gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div></div>