<div dir="ltr">Compiles on Windows, I will watch the bots to see if anything breaks on Linux/ OSX.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Feb 3, 2017 at 3:03 PM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath accepted this revision.<br class="gmail_msg">
labath added a comment.<br class="gmail_msg">
This revision is now accepted and ready to land.<br class="gmail_msg">
<br class="gmail_msg">
looks good, just make sure it compiles.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lldb/include/lldb/Core/Log.h:18<br class="gmail_msg">
 #include "lldb/Utility/ConstString.h"<br class="gmail_msg">
+#include "lldb/Utility/Error.h"<br class="gmail_msg">
 #include "lldb/lldb-private.h"<br class="gmail_msg">
----------------<br class="gmail_msg">
This is also unnecessary.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lldb/include/lldb/Utility/Error.h:14<br class="gmail_msg">
<br class="gmail_msg">
+#include "llvm/ADT/StringRef.h"<br class="gmail_msg">
+#include "llvm/ADT/Twine.h"<br class="gmail_msg">
----------------<br class="gmail_msg">
All these includes are now unnecessary :)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lldb/source/Host/common/Host.cpp:911<br class="gmail_msg">
           eErrorTypePOSIX);<br class="gmail_msg">
-      if (log && (error.Fail() || log))<br class="gmail_msg">
-        error.PutToLog(log,<br class="gmail_msg">
----------------<br class="gmail_msg">
lol :)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lldb/source/Host/common/Host.cpp:952<br class="gmail_msg">
+      if (error.Fail())<br class="gmail_msg">
+        LLDB_LOG_ERROR(<br class="gmail_msg">
+            log, error, "posix_spawn_file_actions_addopen (action={0}, "<br class="gmail_msg">
----------------<br class="gmail_msg">
looks like you forgot this one.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D29514" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29514</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>