<div dir="ltr">Derp. Thanks for catching that!</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Feb 1, 2017 at 2:41 PM Jason Molenda <<a href="mailto:jmolenda@apple.com">jmolenda@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You need some break;s.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
-const char *lldb_private::GetVoteAsCString(Vote vote) {<br class="gmail_msg">
- switch (vote) {<br class="gmail_msg">
- case eVoteNo:<br class="gmail_msg">
- return "no";<br class="gmail_msg">
- case eVoteNoOpinion:<br class="gmail_msg">
- return "no opinion";<br class="gmail_msg">
- case eVoteYes:<br class="gmail_msg">
- return "yes";<br class="gmail_msg">
- }<br class="gmail_msg">
- return "invalid";<br class="gmail_msg">
-}<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
+template <> struct format_provider<lldb_private::Vote> {<br class="gmail_msg">
+ static void format(const lldb_private::Vote &V, llvm::raw_ostream &Stream,<br class="gmail_msg">
+ StringRef Style) {<br class="gmail_msg">
+ switch (V) {<br class="gmail_msg">
+ case lldb_private::eVoteNo:<br class="gmail_msg">
+ Stream << "no";<br class="gmail_msg">
+ case lldb_private::eVoteNoOpinion:<br class="gmail_msg">
+ Stream << "no opinion";<br class="gmail_msg">
+ case lldb_private::eVoteYes:<br class="gmail_msg">
+ Stream << "yes";<br class="gmail_msg">
+ }<br class="gmail_msg">
+ Stream << "invalid";<br class="gmail_msg">
+ }<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
> On Feb 1, 2017, at 2:33 PM, Zachary Turner via Phabricator via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> zturner created this revision.<br class="gmail_msg">
> Herald added subscribers: mgorny, nemanjai, srhines, danalbert, emaste.<br class="gmail_msg">
><br class="gmail_msg">
> NFC here, this only moves `ConstString`, `Error`, `RegularExpression`, `Stream`, and `StreamString` from `Core` to `Utility`. The CL is large because these headers are included in many places, so it required updating every include to point to the new location.<br class="gmail_msg">
><br class="gmail_msg">
> This change isn't very controversial, but it will require an update of the Xcode project. We can do that now so that I can submit this in one large patch, or I can just go in with this and someone can fix up the Xcode project later. LMK what is preferred.<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> <a href="https://reviews.llvm.org/D29427" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29427</a><br class="gmail_msg">
><br class="gmail_msg">
> Files:<br class="gmail_msg">
> lldb/include/lldb/Breakpoint/BreakpointResolver.h<br class="gmail_msg">
> lldb/include/lldb/Breakpoint/BreakpointResolverFileRegex.h<br class="gmail_msg">
> lldb/include/lldb/Core/AddressResolver.h<br class="gmail_msg">
> lldb/include/lldb/Core/AddressResolverName.h<br class="gmail_msg">
> lldb/include/lldb/Core/ArchSpec.h<br class="gmail_msg">
> lldb/include/lldb/Core/Broadcaster.h<br class="gmail_msg">
> lldb/include/lldb/Core/Communication.h<br class="gmail_msg">
> lldb/include/lldb/Core/ConstString.h<br class="gmail_msg">
> lldb/include/lldb/Core/DataBufferMemoryMap.h<br class="gmail_msg">
> lldb/include/lldb/Core/Error.h<br class="gmail_msg">
> lldb/include/lldb/Core/Event.h<br class="gmail_msg">
> lldb/include/lldb/Core/FormatEntity.h<br class="gmail_msg">
> lldb/include/lldb/Core/IOHandler.h<br class="gmail_msg">
> lldb/include/lldb/Core/Log.h<br class="gmail_msg">
> lldb/include/lldb/Core/Mangled.h<br class="gmail_msg">
> lldb/include/lldb/Core/MappedHash.h<br class="gmail_msg">
> lldb/include/lldb/Core/ModuleSpec.h<br class="gmail_msg">
> lldb/include/lldb/Core/RegularExpression.h<br class="gmail_msg">
> lldb/include/lldb/Core/Section.h<br class="gmail_msg">
> lldb/include/lldb/Core/Stream.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamAsynchronousIO.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamBuffer.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamCallback.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamFile.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamGDBRemote.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamString.h<br class="gmail_msg">
> lldb/include/lldb/Core/StreamTee.h<br class="gmail_msg">
> lldb/include/lldb/Core/StructuredData.h<br class="gmail_msg">
> lldb/include/lldb/Core/UniqueCStringMap.h<br class="gmail_msg">
> lldb/include/lldb/Core/UserSettingsController.h<br class="gmail_msg">
> lldb/include/lldb/Core/Value.h<br class="gmail_msg">
> lldb/include/lldb/Core/ValueObject.h<br class="gmail_msg">
> lldb/include/lldb/DataFormatters/DataVisualization.h<br class="gmail_msg">
> lldb/include/lldb/DataFormatters/FormatCache.h<br class="gmail_msg">
> lldb/include/lldb/DataFormatters/FormattersContainer.h<br class="gmail_msg">
> lldb/include/lldb/DataFormatters/TypeSummary.h<br class="gmail_msg">
> lldb/include/lldb/DataFormatters/VectorIterator.h<br class="gmail_msg">
> lldb/include/lldb/Expression/DWARFExpression.h<br class="gmail_msg">
> lldb/include/lldb/Expression/ExpressionParser.h<br class="gmail_msg">
> lldb/include/lldb/Expression/ExpressionVariable.h<br class="gmail_msg">
> lldb/include/lldb/Expression/IRInterpreter.h<br class="gmail_msg">
> lldb/include/lldb/Expression/Materializer.h<br class="gmail_msg">
> lldb/include/lldb/Host/FileCache.h<br class="gmail_msg">
> lldb/include/lldb/Host/FileSpec.h<br class="gmail_msg">
> lldb/include/lldb/Host/FileSystem.h<br class="gmail_msg">
> lldb/include/lldb/Host/HostNativeProcessBase.h<br class="gmail_msg">
> lldb/include/lldb/Host/HostNativeThreadBase.h<br class="gmail_msg">
> lldb/include/lldb/Host/HostThread.h<br class="gmail_msg">
> lldb/include/lldb/Host/LockFileBase.h<br class="gmail_msg">
> lldb/include/lldb/Host/MainLoopBase.h<br class="gmail_msg">
> lldb/include/lldb/Host/PipeBase.h<br class="gmail_msg">
> lldb/include/lldb/Host/Socket.h<br class="gmail_msg">
> lldb/include/lldb/Host/ThreadLauncher.h<br class="gmail_msg">
> lldb/include/lldb/Host/XML.h<br class="gmail_msg">
> lldb/include/lldb/Host/common/NativeBreakpointList.h<br class="gmail_msg">
> lldb/include/lldb/Host/common/NativeProcessProtocol.h<br class="gmail_msg">
> lldb/include/lldb/Host/common/NativeWatchpointList.h<br class="gmail_msg">
> lldb/include/lldb/Host/posix/HostProcessPosix.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/Args.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/CommandCompletions.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/CommandHistory.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/CommandObjectRegexCommand.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/CommandReturnObject.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/OptionGroupPlatform.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/OptionValue.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/OptionValueEnumeration.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/OptionValueProperties.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/OptionValueRegex.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/Property.h<br class="gmail_msg">
> lldb/include/lldb/Interpreter/ScriptInterpreter.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/Block.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/ClangASTContext.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/CompileUnit.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/CompilerDecl.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/CompilerDeclContext.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/DebugMacros.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/GoASTContext.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/JavaASTContext.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/OCamlASTContext.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/Type.h<br class="gmail_msg">
> lldb/include/lldb/Symbol/UnwindPlan.h<br class="gmail_msg">
> lldb/include/lldb/Target/ABI.h<br class="gmail_msg">
> lldb/include/lldb/Target/DynamicLoader.h<br class="gmail_msg">
> lldb/include/lldb/Target/MemoryRegionInfo.h<br class="gmail_msg">
> lldb/include/lldb/Target/PathMappingList.h<br class="gmail_msg">
> lldb/include/lldb/Target/Platform.h<br class="gmail_msg">
> lldb/include/lldb/Target/Process.h<br class="gmail_msg">
> lldb/include/lldb/Target/QueueItem.h<br class="gmail_msg">
> lldb/include/lldb/Target/StackFrame.h<br class="gmail_msg">
> lldb/include/lldb/Target/SystemRuntime.h<br class="gmail_msg">
> lldb/include/lldb/Target/UnixSignals.h<br class="gmail_msg">
> lldb/include/lldb/Utility/ConstString.h<br class="gmail_msg">
> lldb/include/lldb/Utility/Error.h<br class="gmail_msg">
> lldb/include/lldb/Utility/JSON.h<br class="gmail_msg">
> lldb/include/lldb/Utility/ProcessStructReader.h<br class="gmail_msg">
> lldb/include/lldb/Utility/RegularExpression.h<br class="gmail_msg">
> lldb/include/lldb/Utility/Stream.h<br class="gmail_msg">
> lldb/include/lldb/Utility/StreamString.h<br class="gmail_msg">
> lldb/include/lldb/Utility/StreamTee.h<br class="gmail_msg">
> lldb/source/API/SBAddress.cpp<br class="gmail_msg">
> lldb/source/API/SBBreakpoint.cpp<br class="gmail_msg">
> lldb/source/API/SBBreakpointLocation.cpp<br class="gmail_msg">
> lldb/source/API/SBCommandReturnObject.cpp<br class="gmail_msg">
> lldb/source/API/SBData.cpp<br class="gmail_msg">
> lldb/source/API/SBDeclaration.cpp<br class="gmail_msg">
> lldb/source/API/SBError.cpp<br class="gmail_msg">
> lldb/source/API/SBEvent.cpp<br class="gmail_msg">
> lldb/source/API/SBFileSpec.cpp<br class="gmail_msg">
> lldb/source/API/SBFileSpecList.cpp<br class="gmail_msg">
> lldb/source/API/SBFrame.cpp<br class="gmail_msg">
> lldb/source/API/SBInstructionList.cpp<br class="gmail_msg">
> lldb/source/API/SBLineEntry.cpp<br class="gmail_msg">
> lldb/source/API/SBListener.cpp<br class="gmail_msg">
> lldb/source/API/SBMemoryRegionInfo.cpp<br class="gmail_msg">
> lldb/source/API/SBModule.cpp<br class="gmail_msg">
> lldb/source/API/SBModuleSpec.cpp<br class="gmail_msg">
> lldb/source/API/SBPlatform.cpp<br class="gmail_msg">
> lldb/source/API/SBProcess.cpp<br class="gmail_msg">
> lldb/source/API/SBSection.cpp<br class="gmail_msg">
> lldb/source/API/SBSourceManager.cpp<br class="gmail_msg">
> lldb/source/API/SBStream.cpp<br class="gmail_msg">
> lldb/source/API/SBStructuredData.cpp<br class="gmail_msg">
> lldb/source/API/SBTarget.cpp<br class="gmail_msg">
> lldb/source/API/SBThread.cpp<br class="gmail_msg">
> lldb/source/API/SBThreadPlan.cpp<br class="gmail_msg">
> lldb/source/API/SBType.cpp<br class="gmail_msg">
> lldb/source/API/SBTypeEnumMember.cpp<br class="gmail_msg">
> lldb/source/API/SBValue.cpp<br class="gmail_msg">
> lldb/source/API/SBWatchpoint.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/Breakpoint.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointID.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointLocation.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointOptions.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointResolver.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointResolverAddress.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointResolverFileLine.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointResolverName.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointSite.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/BreakpointSiteList.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/Watchpoint.cpp<br class="gmail_msg">
> lldb/source/Breakpoint/WatchpointOptions.cpp<br class="gmail_msg">
> lldb/source/Commands/CommandObjectBreakpoint.cpp<br class="gmail_msg">
> lldb/source/Commands/CommandObjectFrame.cpp<br class="gmail_msg">
> lldb/source/Commands/CommandObjectLog.cpp<br class="gmail_msg">
> lldb/source/Commands/CommandObjectMemory.cpp<br class="gmail_msg">
> lldb/source/Commands/CommandObjectType.cpp<br class="gmail_msg">
> lldb/source/Commands/CommandObjectWatchpoint.cpp<br class="gmail_msg">
> lldb/source/Core/AddressRange.cpp<br class="gmail_msg">
> lldb/source/Core/AddressResolver.cpp<br class="gmail_msg">
> lldb/source/Core/AddressResolverFileLine.cpp<br class="gmail_msg">
> lldb/source/Core/AddressResolverName.cpp<br class="gmail_msg">
> lldb/source/Core/ArchSpec.cpp<br class="gmail_msg">
> lldb/source/Core/Baton.cpp<br class="gmail_msg">
> lldb/source/Core/Broadcaster.cpp<br class="gmail_msg">
> lldb/source/Core/CMakeLists.txt<br class="gmail_msg">
> lldb/source/Core/ConstString.cpp<br class="gmail_msg">
> lldb/source/Core/DataBufferMemoryMap.cpp<br class="gmail_msg">
> lldb/source/Core/DataExtractor.cpp<br class="gmail_msg">
> lldb/source/Core/Debugger.cpp<br class="gmail_msg">
> lldb/source/Core/Disassembler.cpp<br class="gmail_msg">
> lldb/source/Core/EmulateInstruction.cpp<br class="gmail_msg">
> lldb/source/Core/Error.cpp<br class="gmail_msg">
> lldb/source/Core/Event.cpp<br class="gmail_msg">
> lldb/source/Core/FileLineResolver.cpp<br class="gmail_msg">
> lldb/source/Core/FileSpecList.cpp<br class="gmail_msg">
> lldb/source/Core/FormatEntity.cpp<br class="gmail_msg">
> lldb/source/Core/History.cpp<br class="gmail_msg">
> lldb/source/Core/Listener.cpp<br class="gmail_msg">
> lldb/source/Core/Log.cpp<br class="gmail_msg">
> lldb/source/Core/Mangled.cpp<br class="gmail_msg">
> lldb/source/Core/Module.cpp<br class="gmail_msg">
> lldb/source/Core/Opcode.cpp<br class="gmail_msg">
> lldb/source/Core/PluginManager.cpp<br class="gmail_msg">
> lldb/source/Core/RegisterValue.cpp<br class="gmail_msg">
> lldb/source/Core/RegularExpression.cpp<br class="gmail_msg">
> lldb/source/Core/Scalar.cpp<br class="gmail_msg">
> lldb/source/Core/SourceManager.cpp<br class="gmail_msg">
> lldb/source/Core/Stream.cpp<br class="gmail_msg">
> lldb/source/Core/StreamFile.cpp<br class="gmail_msg">
> lldb/source/Core/StreamString.cpp<br class="gmail_msg">
> lldb/source/Core/StringList.cpp<br class="gmail_msg">
> lldb/source/Core/StructuredData.cpp<br class="gmail_msg">
> lldb/source/Core/Timer.cpp<br class="gmail_msg">
> lldb/source/Core/UUID.cpp<br class="gmail_msg">
> lldb/source/Core/UserID.cpp<br class="gmail_msg">
> lldb/source/Core/UserSettingsController.cpp<br class="gmail_msg">
> lldb/source/Core/VMRange.cpp<br class="gmail_msg">
> lldb/source/Core/Value.cpp<br class="gmail_msg">
> lldb/source/Core/ValueObject.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/CXXFunctionPointer.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/FormattersHelpers.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/StringPrinter.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/TypeFormat.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/TypeSummary.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/TypeSynthetic.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/TypeValidator.cpp<br class="gmail_msg">
> lldb/source/DataFormatters/ValueObjectPrinter.cpp<br class="gmail_msg">
> lldb/source/Expression/DWARFExpression.cpp<br class="gmail_msg">
> lldb/source/Expression/DiagnosticManager.cpp<br class="gmail_msg">
> lldb/source/Expression/ExpressionSourceCode.cpp<br class="gmail_msg">
> lldb/source/Expression/IRDynamicChecks.cpp<br class="gmail_msg">
> lldb/source/Expression/IRInterpreter.cpp<br class="gmail_msg">
> lldb/source/Expression/IRMemoryMap.cpp<br class="gmail_msg">
> lldb/source/Expression/LLVMUserExpression.cpp<br class="gmail_msg">
> lldb/source/Expression/UserExpression.cpp<br class="gmail_msg">
> lldb/source/Expression/UtilityFunction.cpp<br class="gmail_msg">
> lldb/source/Host/common/Editline.cpp<br class="gmail_msg">
> lldb/source/Host/common/File.cpp<br class="gmail_msg">
> lldb/source/Host/common/FileSpec.cpp<br class="gmail_msg">
> lldb/source/Host/common/Host.cpp<br class="gmail_msg">
> lldb/source/Host/common/HostInfoBase.cpp<br class="gmail_msg">
> lldb/source/Host/common/MonitoringProcessLauncher.cpp<br class="gmail_msg">
> lldb/source/Host/common/NativeBreakpoint.cpp<br class="gmail_msg">
> lldb/source/Host/common/Socket.cpp<br class="gmail_msg">
> lldb/source/Host/common/SoftwareBreakpoint.cpp<br class="gmail_msg">
> lldb/source/Host/common/Symbols.cpp<br class="gmail_msg">
> lldb/source/Host/common/ThisThread.cpp<br class="gmail_msg">
> lldb/source/Host/freebsd/Host.cpp<br class="gmail_msg">
> lldb/source/Host/linux/Host.cpp<br class="gmail_msg">
> lldb/source/Host/macosx/Symbols.cpp<br class="gmail_msg">
> lldb/source/Host/netbsd/Host.cpp<br class="gmail_msg">
> lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp<br class="gmail_msg">
> lldb/source/Host/posix/FileSystem.cpp<br class="gmail_msg">
> lldb/source/Host/posix/HostThreadPosix.cpp<br class="gmail_msg">
> lldb/source/Host/posix/MainLoopPosix.cpp<br class="gmail_msg">
> lldb/source/Host/windows/ConnectionGenericFileWindows.cpp<br class="gmail_msg">
> lldb/source/Host/windows/Host.cpp<br class="gmail_msg">
> lldb/source/Host/windows/HostThreadWindows.cpp<br class="gmail_msg">
> lldb/source/Host/windows/ThisThread.cpp<br class="gmail_msg">
> lldb/source/Interpreter/Args.cpp<br class="gmail_msg">
> lldb/source/Interpreter/CommandAlias.cpp<br class="gmail_msg">
> lldb/source/Interpreter/CommandInterpreter.cpp<br class="gmail_msg">
> lldb/source/Interpreter/CommandReturnObject.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionGroupVariable.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueArray.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueBoolean.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueChar.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueFileSpecLIst.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueFormat.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueFormatEntity.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueLanguage.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValuePathMappings.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueProperties.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueRegex.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueSInt64.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueString.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueUInt64.cpp<br class="gmail_msg">
> lldb/source/Interpreter/OptionValueUUID.cpp<br class="gmail_msg">
> lldb/source/Interpreter/Options.cpp<br class="gmail_msg">
> (272 more files...)<br class="gmail_msg">
><br class="gmail_msg">
> <D29427.86722.patch>_______________________________________________<br class="gmail_msg">
> lldb-commits mailing list<br class="gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>