<div>LGTM.</div><div><br></div><div>Jim and I also thought this test was incredibly brittle. You really want assembly or something that guarantees that variables will be in registers.</div><div><br><div class="gmail_quote"><div>On Fri, Jan 13, 2017 at 1:43 AM Pavel Labath via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath accepted this revision.<br class="gmail_msg"><br>labath added a comme<br class="gmail_msg"><br>This revision is now accepted and ready to land.<br class="gmail_msg"><br><br class="gmail_msg"><br>Seems reasonable. Maybe add a comment explaining why is that macro defined.<br class="gmail_msg"><br><br class="gmail_msg"><br>This test is incredibly brittle. I think we should find a better way to test the feature, but I don't really have a good idea so far...<br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br><a href="https://reviews.llvm.org/D28666" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28666</a><br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br></blockquote></div></div>