<div dir="ltr">Ah, thanks - r291204 should hopefully do it, otherwise I might need some help. I'm assuming I'm not actually building this code - think I just ended up touching it after doing a bunch of manual cleanup then resorting to sed - so possibly ended up touching code that isn't building in my configuration.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jan 5, 2017 at 5:02 PM Tim Hammerquist <<a href="mailto:penryu@gmail.com">penryu@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Green Dragon build <<a href="http://lab.llvm.org:8080/green/job/lldb_build_test/23854/" class="gmail_msg" target="_blank">http://lab.llvm.org:8080/green/job/lldb_build_test/23854/</a>> failed with this commit with the error:<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><span style="color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap" class="gmail_msg">CompileC build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o source/DNBDataRef.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
cd "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver"
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libc++ -Wno-trigraphs -fpascal-strings -Os -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Wunreachable-code -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DLLDB_DEBUGSERVER_RELEASE -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.9 -g -fvisibility=hidden -fvisibility-inlines-hidden -Wno-sign-conversion -Wno-infinite-recursion -Wno-move -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/debugserver.hmap -Isource -I../../source -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources -I../../include -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/Release/include -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources/x86_64 -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources -F/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/Release -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/PrivateFrameworks -Wparentheses -DDT_VARIANT_ -DHAVE_LIBZ=1 -DLLDB_USE_OS_LOG=0 -MMD -MT dependencies -MF /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.d --serialize-diagnostics /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.dia -c /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp -o /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o
</span><a id="m_8745681702356306361gmail--117921462749ba4694-19c4-4d7e-bec5-911270d8a58c" style="box-sizing:border-box;word-wrap:break-word;color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap;display:block" class="gmail_msg"></a><span title="Compile Error" style="box-sizing:border-box;font-family:monospace;font-size:13px;white-space:pre-wrap;color:white;background-color:red" class="gmail_msg">/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:123:5: error: use of undeclared identifier 'llvm_unreachable'
</span><span style="color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap" class="gmail_msg"> llvm_unreachable("GetMax32 unhandled case!");
^
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:144:5: error: use of undeclared identifier 'llvm_unreachable'
llvm_unreachable("GetMax64 unhandled case!");
^
2 errors generated.</span><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Thu, Jan 5, 2017 at 4:38 PM, David Blaikie via lldb-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br class="gmail_msg">
Date: Thu Jan 5 18:38:06 2017<br class="gmail_msg">
New Revision: 291198<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=291198&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=291198&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Make lldb -Werror clean for -Wstring-conversion<br class="gmail_msg">
<br class="gmail_msg">
Also found/fixed one bug identified by this warning in<br class="gmail_msg">
RenderScriptx86ABIFixups.cpp where a string literal was being used in an<br class="gmail_msg">
effort to provide a name for an instruction/register, but was instead<br class="gmail_msg">
being passed as the bool 'isVolatile' parameter.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
lldb/trunk/include/lldb/Core/MappedHash.h<br class="gmail_msg">
lldb/trunk/source/Core/DataEncoder.cpp<br class="gmail_msg">
lldb/trunk/source/Core/ValueObjectMemory.cpp<br class="gmail_msg">
lldb/trunk/source/Expression/IRInterpreter.cpp<br class="gmail_msg">
lldb/trunk/source/Host/windows/EditLineWin.cpp<br class="gmail_msg">
lldb/trunk/source/Interpreter/OptionValueProperties.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp<br class="gmail_msg">
lldb/trunk/source/Symbol/ClangASTContext.cpp<br class="gmail_msg">
lldb/trunk/source/Symbol/Type.cpp<br class="gmail_msg">
lldb/trunk/source/Target/ABI.cpp<br class="gmail_msg">
lldb/trunk/source/Target/Platform.cpp<br class="gmail_msg">
lldb/trunk/source/Target/StackFrameList.cpp<br class="gmail_msg">
lldb/trunk/tools/debugserver/source/DNBDataRef.cpp<br class="gmail_msg">
lldb/trunk/tools/driver/Platform.cpp<br class="gmail_msg">
lldb/trunk/tools/lldb-perf/lib/Results.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/include/lldb/Core/MappedHash.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/MappedHash.h?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/MappedHash.h?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/include/lldb/Core/MappedHash.h (original)<br class="gmail_msg">
+++ lldb/trunk/include/lldb/Core/MappedHash.h Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -52,8 +52,7 @@ public:<br class="gmail_msg">
default:<br class="gmail_msg">
break;<br class="gmail_msg">
}<br class="gmail_msg">
- assert(!"Invalid hash function index");<br class="gmail_msg">
- return 0;<br class="gmail_msg">
+ llvm_unreachable("Invalid hash function index");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
static const uint32_t HASH_MAGIC = 0x48415348u;<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Core/DataEncoder.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataEncoder.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataEncoder.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Core/DataEncoder.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Core/DataEncoder.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -258,8 +258,7 @@ uint32_t DataEncoder::PutMaxU64(uint32_t<br class="gmail_msg">
case 8:<br class="gmail_msg">
return PutU64(offset, value);<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"GetMax64 unhandled case!");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("GetMax64 unhandled case!");<br class="gmail_msg">
}<br class="gmail_msg">
return UINT32_MAX;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Core/ValueObjectMemory.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectMemory.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectMemory.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Core/ValueObjectMemory.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Core/ValueObjectMemory.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -165,8 +165,7 @@ bool ValueObjectMemory::UpdateValue() {<br class="gmail_msg">
<br class="gmail_msg">
switch (value_type) {<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Unhandled expression result value kind...");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unhandled expression result value kind...");<br class="gmail_msg">
<br class="gmail_msg">
case Value::eValueTypeScalar:<br class="gmail_msg">
// The variable value is in the Scalar value inside the m_value.<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Expression/IRInterpreter.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRInterpreter.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRInterpreter.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Expression/IRInterpreter.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Expression/IRInterpreter.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -1602,25 +1602,23 @@ bool IRInterpreter::Interpret(llvm::Modu<br class="gmail_msg">
lldb::addr_t addr = tmp_op.ULongLong();<br class="gmail_msg">
size_t dataSize = 0;<br class="gmail_msg">
<br class="gmail_msg">
- if (execution_unit.GetAllocSize(addr, dataSize)) {<br class="gmail_msg">
- // Create the required buffer<br class="gmail_msg">
- rawArgs[i].size = dataSize;<br class="gmail_msg">
- rawArgs[i].data_ap.reset(new uint8_t[dataSize + 1]);<br class="gmail_msg">
+ bool Success = execution_unit.GetAllocSize(addr, dataSize);<br class="gmail_msg">
+ (void)Success;<br class="gmail_msg">
+ assert(Success &&<br class="gmail_msg">
+ "unable to locate host data for transfer to device");<br class="gmail_msg">
+ // Create the required buffer<br class="gmail_msg">
+ rawArgs[i].size = dataSize;<br class="gmail_msg">
+ rawArgs[i].data_ap.reset(new uint8_t[dataSize + 1]);<br class="gmail_msg">
<br class="gmail_msg">
- // Read string from host memory<br class="gmail_msg">
- execution_unit.ReadMemory(rawArgs[i].data_ap.get(), addr, dataSize,<br class="gmail_msg">
- error);<br class="gmail_msg">
- if (error.Fail()) {<br class="gmail_msg">
- assert(!"we have failed to read the string from memory");<br class="gmail_msg">
- return false;<br class="gmail_msg">
- }<br class="gmail_msg">
- // Add null terminator<br class="gmail_msg">
- rawArgs[i].data_ap[dataSize] = '\0';<br class="gmail_msg">
- rawArgs[i].type = lldb_private::ABI::CallArgument::HostPointer;<br class="gmail_msg">
- } else {<br class="gmail_msg">
- assert(!"unable to locate host data for transfer to device");<br class="gmail_msg">
- return false;<br class="gmail_msg">
- }<br class="gmail_msg">
+ // Read string from host memory<br class="gmail_msg">
+ execution_unit.ReadMemory(rawArgs[i].data_ap.get(), addr, dataSize,<br class="gmail_msg">
+ error);<br class="gmail_msg">
+ assert(!error.Fail() &&<br class="gmail_msg">
+ "we have failed to read the string from memory");<br class="gmail_msg">
+<br class="gmail_msg">
+ // Add null terminator<br class="gmail_msg">
+ rawArgs[i].data_ap[dataSize] = '\0';<br class="gmail_msg">
+ rawArgs[i].type = lldb_private::ABI::CallArgument::HostPointer;<br class="gmail_msg">
} else /* if ( arg_ty->isPointerTy() ) */<br class="gmail_msg">
{<br class="gmail_msg">
rawArgs[i].type = lldb_private::ABI::CallArgument::TargetValue;<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/windows/EditLineWin.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/windows/EditLineWin.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/windows/EditLineWin.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/windows/EditLineWin.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/windows/EditLineWin.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -285,11 +285,10 @@ void el_end(EditLine *el) {<br class="gmail_msg">
// assert( !"Not implemented!" );<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-void el_reset(EditLine *) { assert(!"Not implemented!"); }<br class="gmail_msg">
+void el_reset(EditLine *) { llvm_unreachable("Not implemented!"); }<br class="gmail_msg">
<br class="gmail_msg">
int el_getc(EditLine *, char *) {<br class="gmail_msg">
- assert(!"Not implemented!");<br class="gmail_msg">
- return 0;<br class="gmail_msg">
+ llvm_unreachable("Not implemented!");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
void el_push(EditLine *, const char *) {}<br class="gmail_msg">
@@ -297,8 +296,7 @@ void el_push(EditLine *, const char *) {<br class="gmail_msg">
void el_beep(EditLine *) { Beep(1000, 500); }<br class="gmail_msg">
<br class="gmail_msg">
int el_parse(EditLine *, int, const char **) {<br class="gmail_msg">
- assert(!"Not implemented!");<br class="gmail_msg">
- return 0;<br class="gmail_msg">
+ llvm_unreachable("Not implemented!");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
int el_get(EditLine *el, int code, ...) {<br class="gmail_msg">
@@ -311,7 +309,7 @@ int el_get(EditLine *el, int code, ...)<br class="gmail_msg">
*dout = clientData;<br class="gmail_msg">
} break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Not implemented!");<br class="gmail_msg">
+ llvm_unreachable("Not implemented!");<br class="gmail_msg">
}<br class="gmail_msg">
return 0;<br class="gmail_msg">
}<br class="gmail_msg">
@@ -322,7 +320,7 @@ int el_source(EditLine *el, const char *<br class="gmail_msg">
return 0;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-void el_resize(EditLine *) { assert(!"Not implemented!"); }<br class="gmail_msg">
+void el_resize(EditLine *) { llvm_unreachable("Not implemented!"); }<br class="gmail_msg">
<br class="gmail_msg">
const LineInfo *el_line(EditLine *el) { return 0; }<br class="gmail_msg">
<br class="gmail_msg">
@@ -331,7 +329,7 @@ int el_insertstr(EditLine *, const char<br class="gmail_msg">
return 0;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-void el_deletestr(EditLine *, int) { assert(!"Not implemented!"); }<br class="gmail_msg">
+void el_deletestr(EditLine *, int) { llvm_unreachable("Not implemented!"); }<br class="gmail_msg">
<br class="gmail_msg">
History *history_init(void) {<br class="gmail_msg">
// return dummy handle<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Interpreter/OptionValueProperties.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionValueProperties.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionValueProperties.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Interpreter/OptionValueProperties.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Interpreter/OptionValueProperties.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -584,8 +584,7 @@ Error OptionValueProperties::DumpPropert<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
lldb::OptionValueSP OptionValueProperties::DeepCopy() const {<br class="gmail_msg">
- assert(!"this shouldn't happen");<br class="gmail_msg">
- return lldb::OptionValueSP();<br class="gmail_msg">
+ llvm_unreachable("this shouldn't happen");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
const Property *OptionValueProperties::GetPropertyAtPath(<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -196,8 +196,8 @@ bool fixupX86StructRetCalls(llvm::Module<br class="gmail_msg">
llvm::AllocaInst *new_func_ptr =<br class="gmail_msg">
new llvm::AllocaInst(new_func_ptr_type, "new_func_ptr", call_inst);<br class="gmail_msg">
// store the new_func_cast to the newly allocated space<br class="gmail_msg">
- (void)new llvm::StoreInst(new_func_cast, new_func_ptr,<br class="gmail_msg">
- "new_func_ptr_load_cast", call_inst);<br class="gmail_msg">
+ (new llvm::StoreInst(new_func_cast, new_func_ptr, call_inst))<br class="gmail_msg">
+ ->setName("new_func_ptr_load_cast");<br class="gmail_msg">
// load the new function address ready for a jump<br class="gmail_msg">
llvm::LoadInst *new_func_addr_load =<br class="gmail_msg">
new llvm::LoadInst(new_func_ptr, "load_func_pointer", call_inst);<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -480,8 +480,7 @@ Error ProcessKDP::DoResume() {<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
// The only valid thread resume states are listed above<br class="gmail_msg">
- assert(!"invalid thread resume state");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("invalid thread resume state");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -116,8 +116,7 @@ ThreadKDP::CreateRegisterContextForFrame<br class="gmail_msg">
new RegisterContextKDP_x86_64(*this, concrete_frame_idx));<br class="gmail_msg">
break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Add CPU type support in KDP");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Add CPU type support in KDP");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
} else {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -167,7 +167,7 @@ DynamicRegisterInfo::SetRegisterInfo(con<br class="gmail_msg">
reg_info.byte_offset =<br class="gmail_msg">
containing_reg_info->byte_offset + msbyte;<br class="gmail_msg">
} else {<br class="gmail_msg">
- assert(!"Invalid byte order");<br class="gmail_msg">
+ llvm_unreachable("Invalid byte order");<br class="gmail_msg">
}<br class="gmail_msg">
} else {<br class="gmail_msg">
if (msbit > max_bit)<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -1053,8 +1053,7 @@ bool RegisterContextLLDB::ReadRegisterVa<br class="gmail_msg">
case UnwindLLDB::RegisterLocation::eRegisterNotSaved:<br class="gmail_msg">
break;<br class="gmail_msg">
case UnwindLLDB::RegisterLocation::eRegisterSavedAtHostMemoryLocation:<br class="gmail_msg">
- assert("FIXME debugger inferior function call unwind");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("FIXME debugger inferior function call unwind");<br class="gmail_msg">
case UnwindLLDB::RegisterLocation::eRegisterSavedAtMemoryLocation: {<br class="gmail_msg">
Error error(ReadRegisterValueFromMemory(<br class="gmail_msg">
reg_info, regloc.location.target_memory_location, reg_info->byte_size,<br class="gmail_msg">
@@ -1062,8 +1061,7 @@ bool RegisterContextLLDB::ReadRegisterVa<br class="gmail_msg">
success = error.Success();<br class="gmail_msg">
} break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert("Unknown RegisterLocation type.");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unknown RegisterLocation type.");<br class="gmail_msg">
}<br class="gmail_msg">
return success;<br class="gmail_msg">
}<br class="gmail_msg">
@@ -1097,8 +1095,7 @@ bool RegisterContextLLDB::WriteRegisterV<br class="gmail_msg">
case UnwindLLDB::RegisterLocation::eRegisterNotSaved:<br class="gmail_msg">
break;<br class="gmail_msg">
case UnwindLLDB::RegisterLocation::eRegisterSavedAtHostMemoryLocation:<br class="gmail_msg">
- assert("FIXME debugger inferior function call unwind");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("FIXME debugger inferior function call unwind");<br class="gmail_msg">
case UnwindLLDB::RegisterLocation::eRegisterSavedAtMemoryLocation: {<br class="gmail_msg">
Error error(WriteRegisterValueToMemory(<br class="gmail_msg">
reg_info, regloc.location.target_memory_location, reg_info->byte_size,<br class="gmail_msg">
@@ -1106,8 +1103,7 @@ bool RegisterContextLLDB::WriteRegisterV<br class="gmail_msg">
success = error.Success();<br class="gmail_msg">
} break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert("Unknown RegisterLocation type.");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unknown RegisterLocation type.");<br class="gmail_msg">
}<br class="gmail_msg">
return success;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -2599,10 +2599,7 @@ size_t GDBRemoteCommunicationClient::Get<br class="gmail_msg">
thread_ids.push_back(1);<br class="gmail_msg">
}<br class="gmail_msg">
} else {<br class="gmail_msg">
-#if defined(LLDB_CONFIGURATION_DEBUG)<br class="gmail_msg">
-// assert(!"ProcessGDBRemote::UpdateThreadList() failed due to not getting the<br class="gmail_msg">
-// sequence mutex");<br class="gmail_msg">
-#else<br class="gmail_msg">
+#if !defined(LLDB_CONFIGURATION_DEBUG)<br class="gmail_msg">
Log *log(ProcessGDBRemoteLog::GetLogIfAnyCategoryIsSet(GDBR_LOG_PROCESS |<br class="gmail_msg">
GDBR_LOG_PACKETS));<br class="gmail_msg">
if (log)<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -1599,12 +1599,7 @@ StructuredData::ArraySP ScriptInterprete<br class="gmail_msg">
// as the underlying typedef for uint* types, size_t, off_t and other values<br class="gmail_msg">
// change.<br class="gmail_msg">
<br class="gmail_msg">
-template <typename T> const char *GetPythonValueFormatString(T t) {<br class="gmail_msg">
- assert(!"Unhandled type passed to GetPythonValueFormatString(T), make a "<br class="gmail_msg">
- "specialization of GetPythonValueFormatString() to support this "<br class="gmail_msg">
- "type.");<br class="gmail_msg">
- return nullptr;<br class="gmail_msg">
-}<br class="gmail_msg">
+template <typename T> const char *GetPythonValueFormatString(T t) = delete;<br class="gmail_msg">
template <> const char *GetPythonValueFormatString(char *) { return "s"; }<br class="gmail_msg">
template <> const char *GetPythonValueFormatString(char) { return "b"; }<br class="gmail_msg">
template <> const char *GetPythonValueFormatString(unsigned char) {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -65,8 +65,7 @@ bool DWARFDebugRanges::Extract(SymbolFil<br class="gmail_msg">
break;<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"DWARFRangeList::Extract() unsupported address size.");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("DWARFRangeList::Extract() unsupported address size.");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// Filter out empty ranges<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -734,12 +734,11 @@ int DWARFFormValue::Compare(const DWARFF<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
case DW_FORM_indirect:<br class="gmail_msg">
- assert(!"This shouldn't happen after the form has been extracted...");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable(<br class="gmail_msg">
+ "This shouldn't happen after the form has been extracted...");<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Unhandled DW_FORM");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unhandled DW_FORM");<br class="gmail_msg">
}<br class="gmail_msg">
return -1;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -167,8 +167,7 @@ void DWARFMappedHash::Prologue::AppendAt<br class="gmail_msg">
case DW_FORM_exprloc:<br class="gmail_msg">
case DW_FORM_flag_present:<br class="gmail_msg">
case DW_FORM_ref_sig8:<br class="gmail_msg">
- assert(!"Unhandled atom form");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unhandled atom form");<br class="gmail_msg">
<br class="gmail_msg">
case DW_FORM_string:<br class="gmail_msg">
case DW_FORM_block:<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -1253,8 +1253,7 @@ SymbolFileDWARFDebugMap::GetCompileUnit(<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
- assert(!"this shouldn't happen");<br class="gmail_msg">
- return lldb::CompUnitSP();<br class="gmail_msg">
+ llvm_unreachable("this shouldn't happen");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
SymbolFileDWARFDebugMap::CompileUnitInfo *<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -442,15 +442,14 @@ size_t UnwindAssemblyInstEmulation::Writ<br class="gmail_msg">
case EmulateInstruction::eContextPushRegisterOnStack: {<br class="gmail_msg">
uint32_t reg_num = LLDB_INVALID_REGNUM;<br class="gmail_msg">
uint32_t generic_regnum = LLDB_INVALID_REGNUM;<br class="gmail_msg">
- if (context.info_type ==<br class="gmail_msg">
- EmulateInstruction::eInfoTypeRegisterToRegisterPlusOffset) {<br class="gmail_msg">
- const uint32_t unwind_reg_kind = m_unwind_plan_ptr->GetRegisterKind();<br class="gmail_msg">
- reg_num = <a href="http://context.info" class="gmail_msg" target="_blank">context.info</a>.RegisterToRegisterPlusOffset.data_reg<br class="gmail_msg">
- .kinds[unwind_reg_kind];<br class="gmail_msg">
- generic_regnum = <a href="http://context.info" class="gmail_msg" target="_blank">context.info</a>.RegisterToRegisterPlusOffset.data_reg<br class="gmail_msg">
- .kinds[eRegisterKindGeneric];<br class="gmail_msg">
- } else<br class="gmail_msg">
- assert(!"unhandled case, add code to handle this!");<br class="gmail_msg">
+ assert(context.info_type ==<br class="gmail_msg">
+ EmulateInstruction::eInfoTypeRegisterToRegisterPlusOffset &&<br class="gmail_msg">
+ "unhandled case, add code to handle this!");<br class="gmail_msg">
+ const uint32_t unwind_reg_kind = m_unwind_plan_ptr->GetRegisterKind();<br class="gmail_msg">
+ reg_num = <a href="http://context.info" class="gmail_msg" target="_blank">context.info</a>.RegisterToRegisterPlusOffset.data_reg<br class="gmail_msg">
+ .kinds[unwind_reg_kind];<br class="gmail_msg">
+ generic_regnum = <a href="http://context.info" class="gmail_msg" target="_blank">context.info</a>.RegisterToRegisterPlusOffset.data_reg<br class="gmail_msg">
+ .kinds[eRegisterKindGeneric];<br class="gmail_msg">
<br class="gmail_msg">
if (reg_num != LLDB_INVALID_REGNUM &&<br class="gmail_msg">
generic_regnum != LLDB_REGNUM_GENERIC_SP) {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Symbol/ClangASTContext.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Symbol/ClangASTContext.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -390,7 +390,7 @@ static void ParseLangArgs(LangOptions &O<br class="gmail_msg">
case IK_AST:<br class="gmail_msg">
case IK_LLVM_IR:<br class="gmail_msg">
case IK_RenderScript:<br class="gmail_msg">
- assert(!"Invalid input kind!");<br class="gmail_msg">
+ llvm_unreachable("Invalid input kind!");<br class="gmail_msg">
case IK_OpenCL:<br class="gmail_msg">
LangStd = LangStandard::lang_opencl;<br class="gmail_msg">
break;<br class="gmail_msg">
@@ -7568,8 +7568,7 @@ ClangASTContext::GetTemplateArgument(lld<br class="gmail_msg">
return CompilerType();<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Unhandled clang::TemplateArgument::ArgKind");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unhandled clang::TemplateArgument::ArgKind");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Symbol/Type.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Type.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Type.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Symbol/Type.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Symbol/Type.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -484,8 +484,7 @@ bool Type::ResolveClangType(ResolveState<br class="gmail_msg">
break;<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Unhandled encoding_data_type.");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unhandled encoding_data_type.");<br class="gmail_msg">
}<br class="gmail_msg">
} else {<br class="gmail_msg">
// We have no encoding type, return void?<br class="gmail_msg">
@@ -529,8 +528,7 @@ bool Type::ResolveClangType(ResolveState<br class="gmail_msg">
break;<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Unhandled encoding_data_type.");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("Unhandled encoding_data_type.");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/ABI.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ABI.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ABI.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/ABI.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/ABI.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -189,8 +189,7 @@ bool ABI::PrepareTrivialCall(Thread &thr<br class="gmail_msg">
lldb::addr_t returnAddress, llvm::Type &returntype,<br class="gmail_msg">
llvm::ArrayRef<ABI::CallArgument> args) const {<br class="gmail_msg">
// dummy prepare trivial call<br class="gmail_msg">
- assert(!"Should never get here!");<br class="gmail_msg">
- return false;<br class="gmail_msg">
+ llvm_unreachable("Should never get here!");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
bool ABI::GetFallbackRegisterLocation(<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/Platform.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Platform.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Platform.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/Platform.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/Platform.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -1876,9 +1876,8 @@ size_t Platform::GetSoftwareBreakpointTr<br class="gmail_msg">
} break;<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(<br class="gmail_msg">
- !"Unhandled architecture in Platform::GetSoftwareBreakpointTrapOpcode");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable(<br class="gmail_msg">
+ "Unhandled architecture in Platform::GetSoftwareBreakpointTrapOpcode");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
assert(bp_site);<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/StackFrameList.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrameList.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrameList.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/StackFrameList.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/StackFrameList.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -541,8 +541,7 @@ StackFrameSP StackFrameList::GetFrameAtI<br class="gmail_msg">
if (m_frames.empty()) {<br class="gmail_msg">
// Why do we have a thread with zero frames, that should not ever<br class="gmail_msg">
// happen...<br class="gmail_msg">
- if (m_thread.IsValid())<br class="gmail_msg">
- assert("A valid thread has no frames.");<br class="gmail_msg">
+ assert(!m_thread.IsValid() && "A valid thread has no frames.");<br class="gmail_msg">
} else {<br class="gmail_msg">
ResetCurrentInlinedDepth();<br class="gmail_msg">
frame_sp = m_frames[original_idx];<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/tools/debugserver/source/DNBDataRef.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBDataRef.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBDataRef.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/tools/debugserver/source/DNBDataRef.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/tools/debugserver/source/DNBDataRef.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -115,18 +115,13 @@ uint32_t DNBDataRef::GetMax32(offset_t *<br class="gmail_msg">
switch (byte_size) {<br class="gmail_msg">
case 1:<br class="gmail_msg">
return Get8(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
case 2:<br class="gmail_msg">
return Get16(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
case 4:<br class="gmail_msg">
return Get32(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"GetMax32 unhandled case!");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("GetMax32 unhandled case!");<br class="gmail_msg">
}<br class="gmail_msg">
- return 0;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//----------------------------------------------------------------------<br class="gmail_msg">
@@ -139,21 +134,15 @@ uint64_t DNBDataRef::GetMax64(offset_t *<br class="gmail_msg">
switch (size) {<br class="gmail_msg">
case 1:<br class="gmail_msg">
return Get8(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
case 2:<br class="gmail_msg">
return Get16(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
case 4:<br class="gmail_msg">
return Get32(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
case 8:<br class="gmail_msg">
return Get64(offset_ptr);<br class="gmail_msg">
- break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"GetMax64 unhandled case!");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("GetMax64 unhandled case!");<br class="gmail_msg">
}<br class="gmail_msg">
- return 0;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//----------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/tools/driver/Platform.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/tools/driver/Platform.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/tools/driver/Platform.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -34,9 +34,8 @@ int ioctl(int d, int request, ...) {<br class="gmail_msg">
return 0;<br class="gmail_msg">
} break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"Not implemented!");<br class="gmail_msg">
+ llvm_unreachable("Not implemented!");<br class="gmail_msg">
}<br class="gmail_msg">
- return -1;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
int kill(pid_t pid, int sig) {<br class="gmail_msg">
@@ -44,13 +43,11 @@ int kill(pid_t pid, int sig) {<br class="gmail_msg">
if (pid == getpid())<br class="gmail_msg">
exit(sig);<br class="gmail_msg">
//<br class="gmail_msg">
- assert(!"Not implemented!");<br class="gmail_msg">
- return -1;<br class="gmail_msg">
+ llvm_unreachable("Not implemented!");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
int tcsetattr(int fd, int optional_actions, const struct termios *termios_p) {<br class="gmail_msg">
- assert(!"Not implemented!");<br class="gmail_msg">
- return -1;<br class="gmail_msg">
+ llvm_unreachable("Not implemented!");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
int tcgetattr(int fildes, struct termios *termios_p) {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/tools/lldb-perf/lib/Results.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-perf/lib/Results.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-perf/lib/Results.cpp?rev=291198&r1=291197&r2=291198&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/tools/lldb-perf/lib/Results.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/tools/lldb-perf/lib/Results.cpp Thu Jan 5 18:38:06 2017<br class="gmail_msg">
@@ -76,8 +76,7 @@ static void AddResultToArray(CFCMutableA<br class="gmail_msg">
} break;<br class="gmail_msg">
<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"unhandled result");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("unhandled result");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
@@ -125,8 +124,7 @@ static void AddResultToDictionary(CFCMut<br class="gmail_msg">
result->GetAsUnsigned()->GetValue(), true);<br class="gmail_msg">
} break;<br class="gmail_msg">
default:<br class="gmail_msg">
- assert(!"unhandled result");<br class="gmail_msg">
- break;<br class="gmail_msg">
+ llvm_unreachable("unhandled result");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
void Results::Write(const char *out_path) {<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><br clear="all" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div>-- <br class="gmail_msg"><div class="m_8745681702356306361gmail_signature gmail_msg" data-smartmail="gmail_signature">Tim <<a href="mailto:penryu@gmail.com" class="gmail_msg" target="_blank">penryu@gmail.com</a>></div>
</div></blockquote></div>