<div dir="ltr">Green Dragon build <<a href="http://lab.llvm.org:8080/green/job/lldb_build_test/23854/">http://lab.llvm.org:8080/green/job/lldb_build_test/23854/</a>> failed with this commit with the error:<div><br></div><div><span style="color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap">CompileC build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o source/DNBDataRef.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
cd "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver"
export LANG=en_US.US-ASCII
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=c++11 -stdlib=libc++ -Wno-trigraphs -fpascal-strings -Os -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Wunreachable-code -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DLLDB_DEBUGSERVER_RELEASE -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.9 -g -fvisibility=hidden -fvisibility-inlines-hidden -Wno-sign-conversion -Wno-infinite-recursion -Wno-move -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/debugserver.hmap -Isource -I../../source -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources -I../../include -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/Release/include -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources/x86_64 -I/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/DerivedSources -F/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/Release -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/PrivateFrameworks -Wparentheses -DDT_VARIANT_ -DHAVE_LIBZ=1 -DLLDB_USE_OS_LOG=0 -MMD -MT dependencies -MF /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.d --serialize-diagnostics /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.dia -c /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp -o /Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o
</span><a id="gmail--117921462749ba4694-19c4-4d7e-bec5-911270d8a58c" style="box-sizing:border-box;word-wrap:break-word;color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap;display:block"></a><span title="Compile Error" style="box-sizing:border-box;font-family:monospace;font-size:13px;white-space:pre-wrap;color:white;background-color:red">/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:123:5: error: use of undeclared identifier 'llvm_unreachable'
</span><span style="color:rgb(51,51,51);font-family:monospace;font-size:13px;white-space:pre-wrap"> llvm_unreachable("GetMax32 unhandled case!");
^
/Users/buildslave/jenkins/sharedspace/lldb@2/lldb/tools/debugserver/source/DNBDataRef.cpp:144:5: error: use of undeclared identifier 'llvm_unreachable'
llvm_unreachable("GetMax64 unhandled case!");
^
2 errors generated.</span><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 5, 2017 at 4:38 PM, David Blaikie via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Thu Jan 5 18:38:06 2017<br>
New Revision: 291198<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=291198&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=291198&view=rev</a><br>
Log:<br>
Make lldb -Werror clean for -Wstring-conversion<br>
<br>
Also found/fixed one bug identified by this warning in<br>
RenderScriptx86ABIFixups.cpp where a string literal was being used in an<br>
effort to provide a name for an instruction/register, but was instead<br>
being passed as the bool 'isVolatile' parameter.<br>
<br>
Modified:<br>
lldb/trunk/include/lldb/Core/<wbr>MappedHash.h<br>
lldb/trunk/source/Core/<wbr>DataEncoder.cpp<br>
lldb/trunk/source/Core/<wbr>ValueObjectMemory.cpp<br>
lldb/trunk/source/Expression/<wbr>IRInterpreter.cpp<br>
lldb/trunk/source/Host/<wbr>windows/EditLineWin.cpp<br>
lldb/trunk/source/Interpreter/<wbr>OptionValueProperties.cpp<br>
lldb/trunk/source/Plugins/<wbr>LanguageRuntime/RenderScript/<wbr>RenderScriptRuntime/<wbr>RenderScriptx86ABIFixups.cpp<br>
lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ProcessKDP.cpp<br>
lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ThreadKDP.cpp<br>
lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>DynamicRegisterInfo.cpp<br>
lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>RegisterContextLLDB.cpp<br>
lldb/trunk/source/Plugins/<wbr>Process/gdb-remote/<wbr>GDBRemoteCommunicationClient.<wbr>cpp<br>
lldb/trunk/source/Plugins/<wbr>ScriptInterpreter/Python/<wbr>ScriptInterpreterPython.cpp<br>
lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFDebugRanges.cpp<br>
lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFFormValue.cpp<br>
lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>HashedNameToDIE.cpp<br>
lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFDebugMap.cpp<br>
lldb/trunk/source/Plugins/<wbr>UnwindAssembly/InstEmulation/<wbr>UnwindAssemblyInstEmulation.<wbr>cpp<br>
lldb/trunk/source/Symbol/<wbr>ClangASTContext.cpp<br>
lldb/trunk/source/Symbol/Type.<wbr>cpp<br>
lldb/trunk/source/Target/ABI.<wbr>cpp<br>
lldb/trunk/source/Target/<wbr>Platform.cpp<br>
lldb/trunk/source/Target/<wbr>StackFrameList.cpp<br>
lldb/trunk/tools/debugserver/<wbr>source/DNBDataRef.cpp<br>
lldb/trunk/tools/driver/<wbr>Platform.cpp<br>
lldb/trunk/tools/lldb-perf/<wbr>lib/Results.cpp<br>
<br>
Modified: lldb/trunk/include/lldb/Core/<wbr>MappedHash.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/MappedHash.h?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/include/<wbr>lldb/Core/MappedHash.h?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/include/lldb/Core/<wbr>MappedHash.h (original)<br>
+++ lldb/trunk/include/lldb/Core/<wbr>MappedHash.h Thu Jan 5 18:38:06 2017<br>
@@ -52,8 +52,7 @@ public:<br>
default:<br>
break;<br>
}<br>
- assert(!"Invalid hash function index");<br>
- return 0;<br>
+ llvm_unreachable("Invalid hash function index");<br>
}<br>
<br>
static const uint32_t HASH_MAGIC = 0x48415348u;<br>
<br>
Modified: lldb/trunk/source/Core/<wbr>DataEncoder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataEncoder.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Core/DataEncoder.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Core/<wbr>DataEncoder.cpp (original)<br>
+++ lldb/trunk/source/Core/<wbr>DataEncoder.cpp Thu Jan 5 18:38:06 2017<br>
@@ -258,8 +258,7 @@ uint32_t DataEncoder::PutMaxU64(uint32_<wbr>t<br>
case 8:<br>
return PutU64(offset, value);<br>
default:<br>
- assert(!"GetMax64 unhandled case!");<br>
- break;<br>
+ llvm_unreachable("GetMax64 unhandled case!");<br>
}<br>
return UINT32_MAX;<br>
}<br>
<br>
Modified: lldb/trunk/source/Core/<wbr>ValueObjectMemory.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectMemory.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Core/ValueObjectMemory.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Core/<wbr>ValueObjectMemory.cpp (original)<br>
+++ lldb/trunk/source/Core/<wbr>ValueObjectMemory.cpp Thu Jan 5 18:38:06 2017<br>
@@ -165,8 +165,7 @@ bool ValueObjectMemory::<wbr>UpdateValue() {<br>
<br>
switch (value_type) {<br>
default:<br>
- assert(!"Unhandled expression result value kind...");<br>
- break;<br>
+ llvm_unreachable("Unhandled expression result value kind...");<br>
<br>
case Value::eValueTypeScalar:<br>
// The variable value is in the Scalar value inside the m_value.<br>
<br>
Modified: lldb/trunk/source/Expression/<wbr>IRInterpreter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRInterpreter.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Expression/IRInterpreter.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Expression/<wbr>IRInterpreter.cpp (original)<br>
+++ lldb/trunk/source/Expression/<wbr>IRInterpreter.cpp Thu Jan 5 18:38:06 2017<br>
@@ -1602,25 +1602,23 @@ bool IRInterpreter::Interpret(llvm:<wbr>:Modu<br>
lldb::addr_t addr = tmp_op.ULongLong();<br>
size_t dataSize = 0;<br>
<br>
- if (execution_unit.GetAllocSize(<wbr>addr, dataSize)) {<br>
- // Create the required buffer<br>
- rawArgs[i].size = dataSize;<br>
- rawArgs[i].data_ap.reset(new uint8_t[dataSize + 1]);<br>
+ bool Success = execution_unit.GetAllocSize(<wbr>addr, dataSize);<br>
+ (void)Success;<br>
+ assert(Success &&<br>
+ "unable to locate host data for transfer to device");<br>
+ // Create the required buffer<br>
+ rawArgs[i].size = dataSize;<br>
+ rawArgs[i].data_ap.reset(new uint8_t[dataSize + 1]);<br>
<br>
- // Read string from host memory<br>
- execution_unit.ReadMemory(<wbr>rawArgs[i].data_ap.get(), addr, dataSize,<br>
- error);<br>
- if (error.Fail()) {<br>
- assert(!"we have failed to read the string from memory");<br>
- return false;<br>
- }<br>
- // Add null terminator<br>
- rawArgs[i].data_ap[dataSize] = '\0';<br>
- rawArgs[i].type = lldb_private::ABI::<wbr>CallArgument::HostPointer;<br>
- } else {<br>
- assert(!"unable to locate host data for transfer to device");<br>
- return false;<br>
- }<br>
+ // Read string from host memory<br>
+ execution_unit.ReadMemory(<wbr>rawArgs[i].data_ap.get(), addr, dataSize,<br>
+ error);<br>
+ assert(!error.Fail() &&<br>
+ "we have failed to read the string from memory");<br>
+<br>
+ // Add null terminator<br>
+ rawArgs[i].data_ap[dataSize] = '\0';<br>
+ rawArgs[i].type = lldb_private::ABI::<wbr>CallArgument::HostPointer;<br>
} else /* if ( arg_ty->isPointerTy() ) */<br>
{<br>
rawArgs[i].type = lldb_private::ABI::<wbr>CallArgument::TargetValue;<br>
<br>
Modified: lldb/trunk/source/Host/<wbr>windows/EditLineWin.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/windows/EditLineWin.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Host/windows/EditLineWin.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Host/<wbr>windows/EditLineWin.cpp (original)<br>
+++ lldb/trunk/source/Host/<wbr>windows/EditLineWin.cpp Thu Jan 5 18:38:06 2017<br>
@@ -285,11 +285,10 @@ void el_end(EditLine *el) {<br>
// assert( !"Not implemented!" );<br>
}<br>
<br>
-void el_reset(EditLine *) { assert(!"Not implemented!"); }<br>
+void el_reset(EditLine *) { llvm_unreachable("Not implemented!"); }<br>
<br>
int el_getc(EditLine *, char *) {<br>
- assert(!"Not implemented!");<br>
- return 0;<br>
+ llvm_unreachable("Not implemented!");<br>
}<br>
<br>
void el_push(EditLine *, const char *) {}<br>
@@ -297,8 +296,7 @@ void el_push(EditLine *, const char *) {<br>
void el_beep(EditLine *) { Beep(1000, 500); }<br>
<br>
int el_parse(EditLine *, int, const char **) {<br>
- assert(!"Not implemented!");<br>
- return 0;<br>
+ llvm_unreachable("Not implemented!");<br>
}<br>
<br>
int el_get(EditLine *el, int code, ...) {<br>
@@ -311,7 +309,7 @@ int el_get(EditLine *el, int code, ...)<br>
*dout = clientData;<br>
} break;<br>
default:<br>
- assert(!"Not implemented!");<br>
+ llvm_unreachable("Not implemented!");<br>
}<br>
return 0;<br>
}<br>
@@ -322,7 +320,7 @@ int el_source(EditLine *el, const char *<br>
return 0;<br>
}<br>
<br>
-void el_resize(EditLine *) { assert(!"Not implemented!"); }<br>
+void el_resize(EditLine *) { llvm_unreachable("Not implemented!"); }<br>
<br>
const LineInfo *el_line(EditLine *el) { return 0; }<br>
<br>
@@ -331,7 +329,7 @@ int el_insertstr(EditLine *, const char<br>
return 0;<br>
}<br>
<br>
-void el_deletestr(EditLine *, int) { assert(!"Not implemented!"); }<br>
+void el_deletestr(EditLine *, int) { llvm_unreachable("Not implemented!"); }<br>
<br>
History *history_init(void) {<br>
// return dummy handle<br>
<br>
Modified: lldb/trunk/source/Interpreter/<wbr>OptionValueProperties.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionValueProperties.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Interpreter/<wbr>OptionValueProperties.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Interpreter/<wbr>OptionValueProperties.cpp (original)<br>
+++ lldb/trunk/source/Interpreter/<wbr>OptionValueProperties.cpp Thu Jan 5 18:38:06 2017<br>
@@ -584,8 +584,7 @@ Error OptionValueProperties::<wbr>DumpPropert<br>
}<br>
<br>
lldb::OptionValueSP OptionValueProperties::<wbr>DeepCopy() const {<br>
- assert(!"this shouldn't happen");<br>
- return lldb::OptionValueSP();<br>
+ llvm_unreachable("this shouldn't happen");<br>
}<br>
<br>
const Property *OptionValueProperties::<wbr>GetPropertyAtPath(<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>LanguageRuntime/RenderScript/<wbr>RenderScriptRuntime/<wbr>RenderScriptx86ABIFixups.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptx86ABIFixups.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/LanguageRuntime/<wbr>RenderScript/<wbr>RenderScriptRuntime/<wbr>RenderScriptx86ABIFixups.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>LanguageRuntime/RenderScript/<wbr>RenderScriptRuntime/<wbr>RenderScriptx86ABIFixups.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>LanguageRuntime/RenderScript/<wbr>RenderScriptRuntime/<wbr>RenderScriptx86ABIFixups.cpp Thu Jan 5 18:38:06 2017<br>
@@ -196,8 +196,8 @@ bool fixupX86StructRetCalls(llvm::<wbr>Module<br>
llvm::AllocaInst *new_func_ptr =<br>
new llvm::AllocaInst(new_func_ptr_<wbr>type, "new_func_ptr", call_inst);<br>
// store the new_func_cast to the newly allocated space<br>
- (void)new llvm::StoreInst(new_func_cast, new_func_ptr,<br>
- "new_func_ptr_load_cast", call_inst);<br>
+ (new llvm::StoreInst(new_func_cast, new_func_ptr, call_inst))<br>
+ ->setName("new_func_ptr_load_<wbr>cast");<br>
// load the new function address ready for a jump<br>
llvm::LoadInst *new_func_addr_load =<br>
new llvm::LoadInst(new_func_ptr, "load_func_pointer", call_inst);<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ProcessKDP.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/MacOSX-Kernel/<wbr>ProcessKDP.cpp?rev=291198&r1=<wbr>291197&r2=291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ProcessKDP.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ProcessKDP.cpp Thu Jan 5 18:38:06 2017<br>
@@ -480,8 +480,7 @@ Error ProcessKDP::DoResume() {<br>
<br>
default:<br>
// The only valid thread resume states are listed above<br>
- assert(!"invalid thread resume state");<br>
- break;<br>
+ llvm_unreachable("invalid thread resume state");<br>
}<br>
}<br>
<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ThreadKDP.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/MacOSX-Kernel/<wbr>ThreadKDP.cpp?rev=291198&r1=<wbr>291197&r2=291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ThreadKDP.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>Process/MacOSX-Kernel/<wbr>ThreadKDP.cpp Thu Jan 5 18:38:06 2017<br>
@@ -116,8 +116,7 @@ ThreadKDP::<wbr>CreateRegisterContextForFrame<br>
new RegisterContextKDP_x86_64(*<wbr>this, concrete_frame_idx));<br>
break;<br>
default:<br>
- assert(!"Add CPU type support in KDP");<br>
- break;<br>
+ llvm_unreachable("Add CPU type support in KDP");<br>
}<br>
}<br>
} else {<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>DynamicRegisterInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/Utility/<wbr>DynamicRegisterInfo.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>DynamicRegisterInfo.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>DynamicRegisterInfo.cpp Thu Jan 5 18:38:06 2017<br>
@@ -167,7 +167,7 @@ DynamicRegisterInfo::<wbr>SetRegisterInfo(con<br>
reg_info.byte_offset =<br>
containing_reg_info->byte_<wbr>offset + msbyte;<br>
} else {<br>
- assert(!"Invalid byte order");<br>
+ llvm_unreachable("Invalid byte order");<br>
}<br>
} else {<br>
if (msbit > max_bit)<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>RegisterContextLLDB.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterContextLLDB.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/Utility/<wbr>RegisterContextLLDB.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>RegisterContextLLDB.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>Process/Utility/<wbr>RegisterContextLLDB.cpp Thu Jan 5 18:38:06 2017<br>
@@ -1053,8 +1053,7 @@ bool RegisterContextLLDB::<wbr>ReadRegisterVa<br>
case UnwindLLDB::RegisterLocation::<wbr>eRegisterNotSaved:<br>
break;<br>
case UnwindLLDB::RegisterLocation::<wbr>eRegisterSavedAtHostMemoryLoca<wbr>tion:<br>
- assert("FIXME debugger inferior function call unwind");<br>
- break;<br>
+ llvm_unreachable("FIXME debugger inferior function call unwind");<br>
case UnwindLLDB::RegisterLocation::<wbr>eRegisterSavedAtMemoryLocation<wbr>: {<br>
Error error(<wbr>ReadRegisterValueFromMemory(<br>
reg_info, regloc.location.target_memory_<wbr>location, reg_info->byte_size,<br>
@@ -1062,8 +1061,7 @@ bool RegisterContextLLDB::<wbr>ReadRegisterVa<br>
success = error.Success();<br>
} break;<br>
default:<br>
- assert("Unknown RegisterLocation type.");<br>
- break;<br>
+ llvm_unreachable("Unknown RegisterLocation type.");<br>
}<br>
return success;<br>
}<br>
@@ -1097,8 +1095,7 @@ bool RegisterContextLLDB::<wbr>WriteRegisterV<br>
case UnwindLLDB::RegisterLocation::<wbr>eRegisterNotSaved:<br>
break;<br>
case UnwindLLDB::RegisterLocation::<wbr>eRegisterSavedAtHostMemoryLoca<wbr>tion:<br>
- assert("FIXME debugger inferior function call unwind");<br>
- break;<br>
+ llvm_unreachable("FIXME debugger inferior function call unwind");<br>
case UnwindLLDB::RegisterLocation::<wbr>eRegisterSavedAtMemoryLocation<wbr>: {<br>
Error error(<wbr>WriteRegisterValueToMemory(<br>
reg_info, regloc.location.target_memory_<wbr>location, reg_info->byte_size,<br>
@@ -1106,8 +1103,7 @@ bool RegisterContextLLDB::<wbr>WriteRegisterV<br>
success = error.Success();<br>
} break;<br>
default:<br>
- assert("Unknown RegisterLocation type.");<br>
- break;<br>
+ llvm_unreachable("Unknown RegisterLocation type.");<br>
}<br>
return success;<br>
}<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>Process/gdb-remote/<wbr>GDBRemoteCommunicationClient.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/gdb-remote/<wbr>GDBRemoteCommunicationClient.<wbr>cpp?rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>Process/gdb-remote/<wbr>GDBRemoteCommunicationClient.<wbr>cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>Process/gdb-remote/<wbr>GDBRemoteCommunicationClient.<wbr>cpp Thu Jan 5 18:38:06 2017<br>
@@ -2599,10 +2599,7 @@ size_t GDBRemoteCommunicationClient::<wbr>Get<br>
thread_ids.push_back(1);<br>
}<br>
} else {<br>
-#if defined(LLDB_CONFIGURATION_<wbr>DEBUG)<br>
-// assert(!"ProcessGDBRemote::<wbr>UpdateThreadList() failed due to not getting the<br>
-// sequence mutex");<br>
-#else<br>
+#if !defined(LLDB_CONFIGURATION_<wbr>DEBUG)<br>
Log *log(ProcessGDBRemoteLog::<wbr>GetLogIfAnyCategoryIsSet(GDBR_<wbr>LOG_PROCESS |<br>
GDBR_LOG_PACKETS));<br>
if (log)<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>ScriptInterpreter/Python/<wbr>ScriptInterpreterPython.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/ScriptInterpreter/<wbr>Python/<wbr>ScriptInterpreterPython.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>ScriptInterpreter/Python/<wbr>ScriptInterpreterPython.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>ScriptInterpreter/Python/<wbr>ScriptInterpreterPython.cpp Thu Jan 5 18:38:06 2017<br>
@@ -1599,12 +1599,7 @@ StructuredData::ArraySP ScriptInterprete<br>
// as the underlying typedef for uint* types, size_t, off_t and other values<br>
// change.<br>
<br>
-template <typename T> const char *GetPythonValueFormatString(T t) {<br>
- assert(!"Unhandled type passed to GetPythonValueFormatString(T), make a "<br>
- "specialization of GetPythonValueFormatString() to support this "<br>
- "type.");<br>
- return nullptr;<br>
-}<br>
+template <typename T> const char *GetPythonValueFormatString(T t) = delete;<br>
template <> const char *GetPythonValueFormatString(<wbr>char *) { return "s"; }<br>
template <> const char *GetPythonValueFormatString(<wbr>char) { return "b"; }<br>
template <> const char *GetPythonValueFormatString(<wbr>unsigned char) {<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFDebugRanges.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/SymbolFile/DWARF/<wbr>DWARFDebugRanges.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFDebugRanges.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFDebugRanges.cpp Thu Jan 5 18:38:06 2017<br>
@@ -65,8 +65,7 @@ bool DWARFDebugRanges::Extract(<wbr>SymbolFil<br>
break;<br>
<br>
default:<br>
- assert(!"DWARFRangeList::<wbr>Extract() unsupported address size.");<br>
- break;<br>
+ llvm_unreachable("<wbr>DWARFRangeList::Extract() unsupported address size.");<br>
}<br>
<br>
// Filter out empty ranges<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFFormValue.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/SymbolFile/DWARF/<wbr>DWARFFormValue.cpp?rev=291198&<wbr>r1=291197&r2=291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFFormValue.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>DWARFFormValue.cpp Thu Jan 5 18:38:06 2017<br>
@@ -734,12 +734,11 @@ int DWARFFormValue::Compare(const DWARFF<br>
}<br>
<br>
case DW_FORM_indirect:<br>
- assert(!"This shouldn't happen after the form has been extracted...");<br>
- break;<br>
+ llvm_unreachable(<br>
+ "This shouldn't happen after the form has been extracted...");<br>
<br>
default:<br>
- assert(!"Unhandled DW_FORM");<br>
- break;<br>
+ llvm_unreachable("Unhandled DW_FORM");<br>
}<br>
return -1;<br>
}<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>HashedNameToDIE.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/SymbolFile/DWARF/<wbr>HashedNameToDIE.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>HashedNameToDIE.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>HashedNameToDIE.cpp Thu Jan 5 18:38:06 2017<br>
@@ -167,8 +167,7 @@ void DWARFMappedHash::Prologue::<wbr>AppendAt<br>
case DW_FORM_exprloc:<br>
case DW_FORM_flag_present:<br>
case DW_FORM_ref_sig8:<br>
- assert(!"Unhandled atom form");<br>
- break;<br>
+ llvm_unreachable("Unhandled atom form");<br>
<br>
case DW_FORM_string:<br>
case DW_FORM_block:<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFDebugMap.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/SymbolFile/DWARF/<wbr>SymbolFileDWARFDebugMap.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFDebugMap.cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFDebugMap.cpp Thu Jan 5 18:38:06 2017<br>
@@ -1253,8 +1253,7 @@ SymbolFileDWARFDebugMap::<wbr>GetCompileUnit(<br>
}<br>
}<br>
}<br>
- assert(!"this shouldn't happen");<br>
- return lldb::CompUnitSP();<br>
+ llvm_unreachable("this shouldn't happen");<br>
}<br>
<br>
SymbolFileDWARFDebugMap::<wbr>CompileUnitInfo *<br>
<br>
Modified: lldb/trunk/source/Plugins/<wbr>UnwindAssembly/InstEmulation/<wbr>UnwindAssemblyInstEmulation.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/UnwindAssembly/<wbr>InstEmulation/<wbr>UnwindAssemblyInstEmulation.<wbr>cpp?rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Plugins/<wbr>UnwindAssembly/InstEmulation/<wbr>UnwindAssemblyInstEmulation.<wbr>cpp (original)<br>
+++ lldb/trunk/source/Plugins/<wbr>UnwindAssembly/InstEmulation/<wbr>UnwindAssemblyInstEmulation.<wbr>cpp Thu Jan 5 18:38:06 2017<br>
@@ -442,15 +442,14 @@ size_t UnwindAssemblyInstEmulation::<wbr>Writ<br>
case EmulateInstruction::<wbr>eContextPushRegisterOnStack: {<br>
uint32_t reg_num = LLDB_INVALID_REGNUM;<br>
uint32_t generic_regnum = LLDB_INVALID_REGNUM;<br>
- if (context.info_type ==<br>
- EmulateInstruction::<wbr>eInfoTypeRegisterToRegisterPlu<wbr>sOffset) {<br>
- const uint32_t unwind_reg_kind = m_unwind_plan_ptr-><wbr>GetRegisterKind();<br>
- reg_num = <a href="http://context.info">context.info</a>.<wbr>RegisterToRegisterPlusOffset.<wbr>data_reg<br>
- .kinds[unwind_reg_kind];<br>
- generic_regnum = <a href="http://context.info">context.info</a>.<wbr>RegisterToRegisterPlusOffset.<wbr>data_reg<br>
- .kinds[eRegisterKindGeneric];<br>
- } else<br>
- assert(!"unhandled case, add code to handle this!");<br>
+ assert(context.info_type ==<br>
+ EmulateInstruction::<wbr>eInfoTypeRegisterToRegisterPlu<wbr>sOffset &&<br>
+ "unhandled case, add code to handle this!");<br>
+ const uint32_t unwind_reg_kind = m_unwind_plan_ptr-><wbr>GetRegisterKind();<br>
+ reg_num = <a href="http://context.info">context.info</a>.<wbr>RegisterToRegisterPlusOffset.<wbr>data_reg<br>
+ .kinds[unwind_reg_kind];<br>
+ generic_regnum = <a href="http://context.info">context.info</a>.<wbr>RegisterToRegisterPlusOffset.<wbr>data_reg<br>
+ .kinds[eRegisterKindGeneric];<br>
<br>
if (reg_num != LLDB_INVALID_REGNUM &&<br>
generic_regnum != LLDB_REGNUM_GENERIC_SP) {<br>
<br>
Modified: lldb/trunk/source/Symbol/<wbr>ClangASTContext.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/ClangASTContext.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Symbol/ClangASTContext.cpp?<wbr>rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Symbol/<wbr>ClangASTContext.cpp (original)<br>
+++ lldb/trunk/source/Symbol/<wbr>ClangASTContext.cpp Thu Jan 5 18:38:06 2017<br>
@@ -390,7 +390,7 @@ static void ParseLangArgs(LangOptions &O<br>
case IK_AST:<br>
case IK_LLVM_IR:<br>
case IK_RenderScript:<br>
- assert(!"Invalid input kind!");<br>
+ llvm_unreachable("Invalid input kind!");<br>
case IK_OpenCL:<br>
LangStd = LangStandard::lang_opencl;<br>
break;<br>
@@ -7568,8 +7568,7 @@ ClangASTContext::<wbr>GetTemplateArgument(lld<br>
return CompilerType();<br>
<br>
default:<br>
- assert(!"Unhandled clang::TemplateArgument::<wbr>ArgKind");<br>
- break;<br>
+ llvm_unreachable("Unhandled clang::TemplateArgument::<wbr>ArgKind");<br>
}<br>
}<br>
}<br>
<br>
Modified: lldb/trunk/source/Symbol/Type.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Type.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Symbol/Type.cpp?rev=291198&r1=<wbr>291197&r2=291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Symbol/Type.<wbr>cpp (original)<br>
+++ lldb/trunk/source/Symbol/Type.<wbr>cpp Thu Jan 5 18:38:06 2017<br>
@@ -484,8 +484,7 @@ bool Type::ResolveClangType(<wbr>ResolveState<br>
break;<br>
<br>
default:<br>
- assert(!"Unhandled encoding_data_type.");<br>
- break;<br>
+ llvm_unreachable("Unhandled encoding_data_type.");<br>
}<br>
} else {<br>
// We have no encoding type, return void?<br>
@@ -529,8 +528,7 @@ bool Type::ResolveClangType(<wbr>ResolveState<br>
break;<br>
<br>
default:<br>
- assert(!"Unhandled encoding_data_type.");<br>
- break;<br>
+ llvm_unreachable("Unhandled encoding_data_type.");<br>
}<br>
}<br>
<br>
<br>
Modified: lldb/trunk/source/Target/ABI.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ABI.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Target/ABI.cpp?rev=291198&r1=<wbr>291197&r2=291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Target/ABI.<wbr>cpp (original)<br>
+++ lldb/trunk/source/Target/ABI.<wbr>cpp Thu Jan 5 18:38:06 2017<br>
@@ -189,8 +189,7 @@ bool ABI::PrepareTrivialCall(Thread &thr<br>
lldb::addr_t returnAddress, llvm::Type &returntype,<br>
llvm::ArrayRef<ABI::<wbr>CallArgument> args) const {<br>
// dummy prepare trivial call<br>
- assert(!"Should never get here!");<br>
- return false;<br>
+ llvm_unreachable("Should never get here!");<br>
}<br>
<br>
bool ABI::<wbr>GetFallbackRegisterLocation(<br>
<br>
Modified: lldb/trunk/source/Target/<wbr>Platform.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Platform.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Target/Platform.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Target/<wbr>Platform.cpp (original)<br>
+++ lldb/trunk/source/Target/<wbr>Platform.cpp Thu Jan 5 18:38:06 2017<br>
@@ -1876,9 +1876,8 @@ size_t Platform::<wbr>GetSoftwareBreakpointTr<br>
} break;<br>
<br>
default:<br>
- assert(<br>
- !"Unhandled architecture in Platform::<wbr>GetSoftwareBreakpointTrapOpcod<wbr>e");<br>
- break;<br>
+ llvm_unreachable(<br>
+ "Unhandled architecture in Platform::<wbr>GetSoftwareBreakpointTrapOpcod<wbr>e");<br>
}<br>
<br>
assert(bp_site);<br>
<br>
Modified: lldb/trunk/source/Target/<wbr>StackFrameList.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrameList.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Target/StackFrameList.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Target/<wbr>StackFrameList.cpp (original)<br>
+++ lldb/trunk/source/Target/<wbr>StackFrameList.cpp Thu Jan 5 18:38:06 2017<br>
@@ -541,8 +541,7 @@ StackFrameSP StackFrameList::GetFrameAtI<br>
if (m_frames.empty()) {<br>
// Why do we have a thread with zero frames, that should not ever<br>
// happen...<br>
- if (m_thread.IsValid())<br>
- assert("A valid thread has no frames.");<br>
+ assert(!m_thread.IsValid() && "A valid thread has no frames.");<br>
} else {<br>
ResetCurrentInlinedDepth();<br>
frame_sp = m_frames[original_idx];<br>
<br>
Modified: lldb/trunk/tools/debugserver/<wbr>source/DNBDataRef.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/debugserver/source/DNBDataRef.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/tools/<wbr>debugserver/source/DNBDataRef.<wbr>cpp?rev=291198&r1=291197&r2=<wbr>291198&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/tools/debugserver/<wbr>source/DNBDataRef.cpp (original)<br>
+++ lldb/trunk/tools/debugserver/<wbr>source/DNBDataRef.cpp Thu Jan 5 18:38:06 2017<br>
@@ -115,18 +115,13 @@ uint32_t DNBDataRef::GetMax32(offset_t *<br>
switch (byte_size) {<br>
case 1:<br>
return Get8(offset_ptr);<br>
- break;<br>
case 2:<br>
return Get16(offset_ptr);<br>
- break;<br>
case 4:<br>
return Get32(offset_ptr);<br>
- break;<br>
default:<br>
- assert(!"GetMax32 unhandled case!");<br>
- break;<br>
+ llvm_unreachable("GetMax32 unhandled case!");<br>
}<br>
- return 0;<br>
}<br>
<br>
//----------------------------<wbr>------------------------------<wbr>------------<br>
@@ -139,21 +134,15 @@ uint64_t DNBDataRef::GetMax64(offset_t *<br>
switch (size) {<br>
case 1:<br>
return Get8(offset_ptr);<br>
- break;<br>
case 2:<br>
return Get16(offset_ptr);<br>
- break;<br>
case 4:<br>
return Get32(offset_ptr);<br>
- break;<br>
case 8:<br>
return Get64(offset_ptr);<br>
- break;<br>
default:<br>
- assert(!"GetMax64 unhandled case!");<br>
- break;<br>
+ llvm_unreachable("GetMax64 unhandled case!");<br>
}<br>
- return 0;<br>
}<br>
<br>
//----------------------------<wbr>------------------------------<wbr>------------<br>
<br>
Modified: lldb/trunk/tools/driver/<wbr>Platform.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/driver/Platform.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/tools/<wbr>driver/Platform.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/tools/driver/<wbr>Platform.cpp (original)<br>
+++ lldb/trunk/tools/driver/<wbr>Platform.cpp Thu Jan 5 18:38:06 2017<br>
@@ -34,9 +34,8 @@ int ioctl(int d, int request, ...) {<br>
return 0;<br>
} break;<br>
default:<br>
- assert(!"Not implemented!");<br>
+ llvm_unreachable("Not implemented!");<br>
}<br>
- return -1;<br>
}<br>
<br>
int kill(pid_t pid, int sig) {<br>
@@ -44,13 +43,11 @@ int kill(pid_t pid, int sig) {<br>
if (pid == getpid())<br>
exit(sig);<br>
//<br>
- assert(!"Not implemented!");<br>
- return -1;<br>
+ llvm_unreachable("Not implemented!");<br>
}<br>
<br>
int tcsetattr(int fd, int optional_actions, const struct termios *termios_p) {<br>
- assert(!"Not implemented!");<br>
- return -1;<br>
+ llvm_unreachable("Not implemented!");<br>
}<br>
<br>
int tcgetattr(int fildes, struct termios *termios_p) {<br>
<br>
Modified: lldb/trunk/tools/lldb-perf/<wbr>lib/Results.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-perf/lib/Results.cpp?rev=291198&r1=291197&r2=291198&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/tools/lldb-<wbr>perf/lib/Results.cpp?rev=<wbr>291198&r1=291197&r2=291198&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/tools/lldb-perf/<wbr>lib/Results.cpp (original)<br>
+++ lldb/trunk/tools/lldb-perf/<wbr>lib/Results.cpp Thu Jan 5 18:38:06 2017<br>
@@ -76,8 +76,7 @@ static void AddResultToArray(CFCMutableA<br>
} break;<br>
<br>
default:<br>
- assert(!"unhandled result");<br>
- break;<br>
+ llvm_unreachable("unhandled result");<br>
}<br>
}<br>
<br>
@@ -125,8 +124,7 @@ static void AddResultToDictionary(CFCMut<br>
result->GetAsUnsigned()-><wbr>GetValue(), true);<br>
} break;<br>
default:<br>
- assert(!"unhandled result");<br>
- break;<br>
+ llvm_unreachable("unhandled result");<br>
}<br>
}<br>
void Results::Write(const char *out_path) {<br>
<br>
<br>
______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Tim <<a href="mailto:penryu@gmail.com" target="_blank">penryu@gmail.com</a>></div>
</div>