<div dir="ltr">It may also be the addition of a source file not being added to the Xcode project. This is currently handled by manual changes to the xcodeproj.<div><br></div><div>-Tim<br><div><br></div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 3, 2017 at 9:41 AM, Pavel Labath via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I bet it's the Xcode build not replicating the<br>
if (LLVM_ENABLE_DIA_SDK)<br>
add_subdirectory(PDB)<br>
endif()<br>
and trying to run the PDB test even though it shouldn't.<br>
<br>
(I don't really have a good idea on how to fix this.)<br>
<br>
pl<br>
<br>
On 3 January 2017 at 17:36, Zachary Turner via lldb-commits<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
> Hi Michal,<br>
> It looks like this patch may have broken this bot.<br>
><br>
> <a href="http://lab.llvm.org:8080/green/job/lldb_build_test/23767/consoleFull#-1083450927b825e790-484f-4586-af29-73c4754ff671" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/lldb_build_test/<wbr>23767/consoleFull#-<wbr>1083450927b825e790-484f-4586-<wbr>af29-73c4754ff671</a><br>
><br>
> What do you think?<br>
><br>
> On Mon, Jan 2, 2017 at 10:31 AM Michal Gorny via lldb-commits<br>
> <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: mgorny<br>
>> Date: Mon Jan 2 12:20:33 2017<br>
>> New Revision: 290819<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=290819&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290819&view=rev</a><br>
>> Log:<br>
>> [unittests] Split DWARF tests out of PDB, fix standalone build<br>
>><br>
>> Split the PDB tests into DWARF test and actual PDB tests, the latter<br>
>> requiring DIA SDK. Use the new LLVMConfig.cmake LLVM_ENABLE_DIA_SDK<br>
>> symbol to enable the PDB tests rather than relying on<br>
>> llvm/Config/config.h private include file that is not available when<br>
>> building standalone.<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D26249" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D26249</a><br>
>><br>
>> Added:<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/DWARF/<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/DWARF/CMakeLists.<wbr>txt<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/test-<wbr>dwarf.cpp<br>
>> - copied, changed from r290688,<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/test-<wbr>dwarf.exe<br>
>> - copied, changed from r290688,<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFTests.cpp<br>
>> Removed:<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe<br>
>> Modified:<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/CMakeLists.txt<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/PDB/CMakeLists.txt<br>
>> lldb/trunk/unittests/<wbr>SymbolFile/PDB/<wbr>SymbolFilePDBTests.cpp<br>
>><br>
>> Modified: lldb/trunk/unittests/<wbr>SymbolFile/CMakeLists.txt<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/CMakeLists.txt?rev=290819&r1=290818&r2=290819&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/CMakeLists.txt?rev=<wbr>290819&r1=290818&r2=290819&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/<wbr>SymbolFile/CMakeLists.txt (original)<br>
>> +++ lldb/trunk/unittests/<wbr>SymbolFile/CMakeLists.txt Mon Jan 2 12:20:33<br>
>> 2017<br>
>> @@ -1 +1,4 @@<br>
>> -add_subdirectory(PDB)<br>
>> +add_subdirectory(DWARF)<br>
>> +if (LLVM_ENABLE_DIA_SDK)<br>
>> + add_subdirectory(PDB)<br>
>> +endif()<br>
>><br>
>> Added: lldb/trunk/unittests/<wbr>SymbolFile/DWARF/CMakeLists.<wbr>txt<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/DWARF/CMakeLists.txt?rev=290819&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/DWARF/CMakeLists.<wbr>txt?rev=290819&view=auto</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/<wbr>SymbolFile/DWARF/CMakeLists.<wbr>txt (added)<br>
>> +++ lldb/trunk/unittests/<wbr>SymbolFile/DWARF/CMakeLists.<wbr>txt Mon Jan 2<br>
>> 12:20:33 2017<br>
>> @@ -0,0 +1,8 @@<br>
>> +add_lldb_unittest(<wbr>SymbolFileDWARFTests<br>
>> + SymbolFileDWARFTests.cpp<br>
>> + )<br>
>> +<br>
>> +set(test_inputs<br>
>> + test-dwarf.exe)<br>
>> +<br>
>> +add_unittest_inputs(<wbr>SymbolFileDWARFTests "${test_inputs}")<br>
>><br>
>> Copied: lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/test-<wbr>dwarf.cpp (from<br>
>> r290688, lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp)<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp?p2=lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp&p1=lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp&r1=290688&r2=290819&rev=290819&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/test-<wbr>dwarf.cpp?p2=lldb/trunk/<wbr>unittests/SymbolFile/DWARF/<wbr>Inputs/test-dwarf.cpp&p1=lldb/<wbr>trunk/unittests/SymbolFile/<wbr>PDB/Inputs/test-dwarf.cpp&r1=<wbr>290688&r2=290819&rev=290819&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> (empty)<br>
>><br>
>> Copied: lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/test-<wbr>dwarf.exe (from<br>
>> r290688, lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe)<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.exe?p2=lldb/trunk/unittests/SymbolFile/DWARF/Inputs/test-dwarf.exe&p1=lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.exe&r1=290688&r2=290819&rev=290819&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/DWARF/Inputs/test-<wbr>dwarf.exe?p2=lldb/trunk/<wbr>unittests/SymbolFile/DWARF/<wbr>Inputs/test-dwarf.exe&p1=lldb/<wbr>trunk/unittests/SymbolFile/<wbr>PDB/Inputs/test-dwarf.exe&r1=<wbr>290688&r2=290819&rev=290819&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> (empty)<br>
>><br>
>> Added: lldb/trunk/unittests/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFTests.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp?rev=290819&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFTests.cpp?rev=<wbr>290819&view=auto</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFTests.cpp (added)<br>
>> +++ lldb/trunk/unittests/<wbr>SymbolFile/DWARF/<wbr>SymbolFileDWARFTests.cpp Mon Jan<br>
>> 2 12:20:33 2017<br>
>> @@ -0,0 +1,83 @@<br>
>> +//===-- PythonDataObjectsTests.cpp ------------------------------<wbr>*- C++<br>
>> -*-===//<br>
>> +//<br>
>> +// The LLVM Compiler Infrastructure<br>
>> +//<br>
>> +// This file is distributed under the University of Illinois Open Source<br>
>> +// License. See LICENSE.TXT for details.<br>
>> +//<br>
>><br>
>> +//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
>> +<br>
>> +#include "gtest/gtest.h"<br>
>> +<br>
>> +#include "llvm/ADT/STLExtras.h"<br>
>> +#include "llvm/DebugInfo/PDB/<wbr>PDBSymbolData.h"<br>
>> +#include "llvm/DebugInfo/PDB/<wbr>PDBSymbolExe.h"<br>
>> +#include "llvm/Support/FileSystem.h"<br>
>> +#include "llvm/Support/Path.h"<br>
>> +<br>
>> +#include "lldb/Core/Address.h"<br>
>> +#include "lldb/Core/ArchSpec.h"<br>
>> +#include "lldb/Core/Module.h"<br>
>> +#include "lldb/Core/ModuleSpec.h"<br>
>> +#include "lldb/Host/FileSpec.h"<br>
>> +#include "lldb/Host/HostInfo.h"<br>
>> +#include "lldb/Symbol/ClangASTContext.<wbr>h"<br>
>> +#include "lldb/Symbol/CompileUnit.h"<br>
>> +#include "lldb/Symbol/LineTable.h"<br>
>> +#include "lldb/Symbol/SymbolVendor.h"<br>
>> +<br>
>> +#include "Plugins/ObjectFile/PECOFF/<wbr>ObjectFilePECOFF.h"<br>
>> +#include "Plugins/SymbolFile/DWARF/<wbr>SymbolFileDWARF.h"<br>
>> +#include "Plugins/SymbolFile/PDB/<wbr>SymbolFilePDB.h"<br>
>> +<br>
>> +extern const char *TestMainArgv0;<br>
>> +<br>
>> +using namespace lldb_private;<br>
>> +<br>
>> +class SymbolFileDWARFTests : public testing::Test {<br>
>> +public:<br>
>> + void SetUp() override {<br>
>> +// Initialize and TearDown the plugin every time, so we get a brand new<br>
>> +// AST every time so that modifications to the AST from each test don't<br>
>> +// leak into the next test.<br>
>> + HostInfo::Initialize();<br>
>> + ObjectFilePECOFF::Initialize()<wbr>;<br>
>> + SymbolFileDWARF::Initialize();<br>
>> + ClangASTContext::Initialize();<br>
>> + SymbolFilePDB::Initialize();<br>
>> +<br>
>> + llvm::StringRef exe_folder =<br>
>> llvm::sys::path::parent_path(<wbr>TestMainArgv0);<br>
>> + llvm::SmallString<128> inputs_folder = exe_folder;<br>
>> + llvm::sys::path::append(<wbr>inputs_folder, "Inputs");<br>
>> +<br>
>> + m_dwarf_test_exe = inputs_folder;<br>
>> + llvm::sys::path::append(m_<wbr>dwarf_test_exe, "test-dwarf.exe");<br>
>> + }<br>
>> +<br>
>> + void TearDown() override {<br>
>> + SymbolFilePDB::Terminate();<br>
>> + ClangASTContext::Initialize();<br>
>> + SymbolFileDWARF::Terminate();<br>
>> + ObjectFilePECOFF::Terminate();<br>
>> + HostInfo::Terminate();<br>
>> + }<br>
>> +<br>
>> +protected:<br>
>> + llvm::SmallString<128> m_dwarf_test_exe;<br>
>> +};<br>
>> +<br>
>> +TEST_F(SymbolFileDWARFTests, TestAbilitiesForDWARF) {<br>
>> + // Test that when we have Dwarf debug info, SymbolFileDWARF is used.<br>
>> + FileSpec fspec(m_dwarf_test_exe.c_str()<wbr>, false);<br>
>> + ArchSpec aspec("i686-pc-windows");<br>
>> + lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> +<br>
>> + SymbolVendor *plugin = module->GetSymbolVendor();<br>
>> + EXPECT_NE(nullptr, plugin);<br>
>> + SymbolFile *symfile = plugin->GetSymbolFile();<br>
>> + EXPECT_NE(nullptr, symfile);<br>
>> + EXPECT_EQ(symfile-><wbr>GetPluginName(),<br>
>> SymbolFileDWARF::<wbr>GetPluginNameStatic());<br>
>> +<br>
>> + uint32_t expected_abilities = SymbolFile::kAllAbilities;<br>
>> + EXPECT_EQ(expected_abilities, symfile->CalculateAbilities())<wbr>;<br>
>> +}<br>
>><br>
>> Modified: lldb/trunk/unittests/<wbr>SymbolFile/PDB/CMakeLists.txt<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/PDB/CMakeLists.txt?rev=290819&r1=290818&r2=290819&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/PDB/CMakeLists.txt?<wbr>rev=290819&r1=290818&r2=<wbr>290819&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/<wbr>SymbolFile/PDB/CMakeLists.txt (original)<br>
>> +++ lldb/trunk/unittests/<wbr>SymbolFile/PDB/CMakeLists.txt Mon Jan 2 12:20:33<br>
>> 2017<br>
>> @@ -5,8 +5,7 @@ add_lldb_unittest(<wbr>SymbolFilePDBTests<br>
>> set(test_inputs<br>
>> test-pdb.exe<br>
>> test-pdb.pdb<br>
>> - test-dwarf.exe<br>
>> test-pdb-types.exe<br>
>> test-pdb-types.pdb)<br>
>><br>
>> -add_unittest_inputs(<wbr>SymbolFilePDBTests "${test_inputs}")<br>
>> +add_unittest_inputs(<wbr>SymbolFilePDBTests "${test_inputs}")<br>
>><br>
>> Removed: lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.cpp?rev=290818&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp?rev=290818&view=auto</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp (original)<br>
>> +++ lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.cpp (removed)<br>
>> @@ -1,6 +0,0 @@<br>
>> -// Compile with "cl /c /Zi /GR- test.cpp"<br>
>> -// Link with "link test.obj /debug /nodefaultlib /entry:main<br>
>> /out:test.exe"<br>
>> -<br>
>> -int __cdecl _purecall(void) { return 0; }<br>
>> -<br>
>> -int main(int argc, char **argv) { return 0; }<br>
>><br>
>> Removed: lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-dwarf.exe?rev=290818&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe?rev=290818&view=auto</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> Binary files lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe<br>
>> (original) and lldb/trunk/unittests/<wbr>SymbolFile/PDB/Inputs/test-<wbr>dwarf.exe<br>
>> (removed) differ<br>
>><br>
>> Modified: lldb/trunk/unittests/<wbr>SymbolFile/PDB/<wbr>SymbolFilePDBTests.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp?rev=290819&r1=290818&r2=290819&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>SymbolFile/PDB/<wbr>SymbolFilePDBTests.cpp?rev=<wbr>290819&r1=290818&r2=290819&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/<wbr>SymbolFile/PDB/<wbr>SymbolFilePDBTests.cpp (original)<br>
>> +++ lldb/trunk/unittests/<wbr>SymbolFile/PDB/<wbr>SymbolFilePDBTests.cpp Mon Jan 2<br>
>> 12:20:33 2017<br>
>> @@ -10,7 +10,6 @@<br>
>> #include "gtest/gtest.h"<br>
>><br>
>> #include "llvm/ADT/STLExtras.h"<br>
>> -#include "llvm/Config/config.h"<br>
>> #include "llvm/DebugInfo/PDB/<wbr>PDBSymbolData.h"<br>
>> #include "llvm/DebugInfo/PDB/<wbr>PDBSymbolExe.h"<br>
>> #include "llvm/Support/FileSystem.h"<br>
>> @@ -63,10 +62,8 @@ public:<br>
>> llvm::sys::path::append(<wbr>inputs_folder, "Inputs");<br>
>><br>
>> m_pdb_test_exe = inputs_folder;<br>
>> - m_dwarf_test_exe = inputs_folder;<br>
>> m_types_test_exe = inputs_folder;<br>
>> llvm::sys::path::append(m_pdb_<wbr>test_exe, "test-pdb.exe");<br>
>> - llvm::sys::path::append(m_<wbr>dwarf_test_exe, "test-dwarf.exe");<br>
>> llvm::sys::path::append(m_<wbr>types_test_exe, "test-pdb-types.exe");<br>
>> }<br>
>><br>
>> @@ -84,7 +81,6 @@ public:<br>
>><br>
>> protected:<br>
>> llvm::SmallString<128> m_pdb_test_exe;<br>
>> - llvm::SmallString<128> m_dwarf_test_exe;<br>
>> llvm::SmallString<128> m_types_test_exe;<br>
>><br>
>> bool FileSpecMatchesAsBaseOrFull(<wbr>const FileSpec &left,<br>
>> @@ -154,29 +150,7 @@ protected:<br>
>> }<br>
>> };<br>
>><br>
>> -#if HAVE_DIA_SDK<br>
>> -#define REQUIRES_DIA_SDK(TestName) TestName<br>
>> -#else<br>
>> -#define REQUIRES_DIA_SDK(TestName) DISABLED_##TestName<br>
>> -#endif<br>
>> -<br>
>> -TEST_F(SymbolFilePDBTests, TestAbilitiesForDWARF) {<br>
>> - // Test that when we have Dwarf debug info, SymbolFileDWARF is used.<br>
>> - FileSpec fspec(m_dwarf_test_exe.c_str()<wbr>, false);<br>
>> - ArchSpec aspec("i686-pc-windows");<br>
>> - lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> -<br>
>> - SymbolVendor *plugin = module->GetSymbolVendor();<br>
>> - EXPECT_NE(nullptr, plugin);<br>
>> - SymbolFile *symfile = plugin->GetSymbolFile();<br>
>> - EXPECT_NE(nullptr, symfile);<br>
>> - EXPECT_EQ(symfile-><wbr>GetPluginName(),<br>
>> SymbolFileDWARF::<wbr>GetPluginNameStatic());<br>
>> -<br>
>> - uint32_t expected_abilities = SymbolFile::kAllAbilities;<br>
>> - EXPECT_EQ(expected_abilities, symfile->CalculateAbilities())<wbr>;<br>
>> -}<br>
>> -<br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestAbilitiesForPDB)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestAbilitiesForPDB) {<br>
>> // Test that when we have PDB debug info, SymbolFilePDB is used.<br>
>> FileSpec fspec(m_pdb_test_exe.c_str(), false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> @@ -193,7 +167,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> EXPECT_EQ(expected_abilities, symfile->CalculateAbilities())<wbr>;<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests,<br>
>> REQUIRES_DIA_SDK(<wbr>TestResolveSymbolContextBasena<wbr>me)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestResolveSymbolContextBasena<wbr>me) {<br>
>> // Test that attempting to call ResolveSymbolContext with only a<br>
>> basename<br>
>> // finds all full paths<br>
>> // with the same basename<br>
>> @@ -213,7 +187,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> EXPECT_TRUE(<wbr>ContainsCompileUnit(sc_list, header_spec));<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests,<br>
>> REQUIRES_DIA_SDK(<wbr>TestResolveSymbolContextFullPa<wbr>th)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestResolveSymbolContextFullPa<wbr>th) {<br>
>> // Test that attempting to call ResolveSymbolContext with a full path<br>
>> only<br>
>> // finds the one source<br>
>> // file that matches the full path.<br>
>> @@ -236,7 +210,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> }<br>
>><br>
>> TEST_F(SymbolFilePDBTests,<br>
>> - REQUIRES_DIA_SDK(<wbr>TestLookupOfHeaderFileWithInli<wbr>nes)) {<br>
>> + TestLookupOfHeaderFileWithInli<wbr>nes) {<br>
>> // Test that when looking up a header file via ResolveSymbolContext<br>
>> (i.e. a<br>
>> // file that was not by itself<br>
>> // compiled, but only contributes to the combined code of other source<br>
>> files),<br>
>> @@ -264,8 +238,7 @@ TEST_F(SymbolFilePDBTests,<br>
>> }<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests,<br>
>> - REQUIRES_DIA_SDK(<wbr>TestLookupOfHeaderFileWithNoIn<wbr>lines)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestLookupOfHeaderFileWithNoIn<wbr>lines) {<br>
>> // Test that when looking up a header file via ResolveSymbolContext<br>
>> (i.e. a<br>
>> // file that was not by itself<br>
>> // compiled, but only contributes to the combined code of other source<br>
>> files),<br>
>> @@ -289,7 +262,7 @@ TEST_F(SymbolFilePDBTests,<br>
>> }<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestLineTablesMatchAll)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestLineTablesMatchAll) {<br>
>> // Test that when calling ResolveSymbolContext with a line number of 0,<br>
>> all<br>
>> // line entries from<br>
>> // the specified files are returned.<br>
>> @@ -338,7 +311,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> VerifyLineEntry(module, sc, header2, *lt, 7, 0x401089);<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestLineTablesMatchSpecific))<br>
>> {<br>
>> +TEST_F(SymbolFilePDBTests, TestLineTablesMatchSpecific) {<br>
>> // Test that when calling ResolveSymbolContext with a specific line<br>
>> number,<br>
>> // only line entries<br>
>> // which match the requested line are returned.<br>
>> @@ -390,7 +363,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> VerifyLineEntry(module, sc, header1, *lt, 9, 0x401090);<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestSimpleClassTypes)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestSimpleClassTypes) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -413,7 +386,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> udt_type->GetByteSize());<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestNestedClassTypes)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestNestedClassTypes) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -436,7 +409,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> udt_type->GetByteSize());<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestClassInNamespace)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestClassInNamespace) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -459,7 +432,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> udt_type->GetByteSize());<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestEnumTypes)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestEnumTypes) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -492,21 +465,21 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> }<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestArrayTypes)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestArrayTypes) {<br>
>> // In order to get this test working, we need to support lookup by<br>
>> symbol<br>
>> // name. Because array<br>
>> // types themselves do not have names, only the symbols have names<br>
>> (i.e. the<br>
>> // name of the array).<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestFunctionTypes)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestFunctionTypes) {<br>
>> // In order to get this test working, we need to support lookup by<br>
>> symbol<br>
>> // name. Because array<br>
>> // types themselves do not have names, only the symbols have names<br>
>> (i.e. the<br>
>> // name of the array).<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(TestTypedefs)<wbr>) {<br>
>> +TEST_F(SymbolFilePDBTests, TestTypedefs) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -540,7 +513,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> }<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestRegexNameMatch)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestRegexNameMatch) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -557,7 +530,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> EXPECT_EQ(num_results, results.GetSize());<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(<wbr>TestMaxMatches)) {<br>
>> +TEST_F(SymbolFilePDBTests, TestMaxMatches) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>> @@ -584,7 +557,7 @@ TEST_F(SymbolFilePDBTests, REQUIRES_DIA_<br>
>> }<br>
>> }<br>
>><br>
>> -TEST_F(SymbolFilePDBTests, REQUIRES_DIA_SDK(TestNullName)<wbr>) {<br>
>> +TEST_F(SymbolFilePDBTests, TestNullName) {<br>
>> FileSpec fspec(m_types_test_exe.c_str()<wbr>, false);<br>
>> ArchSpec aspec("i686-pc-windows");<br>
>> lldb::ModuleSP module = std::make_shared<Module>(<wbr>fspec, aspec);<br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> lldb-commits mailing list<br>
>> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
><br>
______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Tim <<a href="mailto:penryu@gmail.com" target="_blank">penryu@gmail.com</a>></div>
</div>