<div dir="ltr"><span style="font-size:12.800000190734863px">I like the version without "function" in it; you might be returning from a method.</span><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 2, 2016 at 12:15 PM, Filipe Cabecinhas <span dir="ltr"><<a href="mailto:filcab+llvm.phabricator@gmail.com" target="_blank">filcab+llvm.phabricator@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><div><span style="font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)">  </span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap">    </span><span class="m_7936266447044576261p" style="display:inline;word-break:break-all;font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial">.</span></span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap"></span><span class="m_7936266447044576261n" style="display:inline;word-break:break-all;font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial">Case</span></span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap"></span><span class="m_7936266447044576261p" style="display:inline;word-break:break-all;font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial">(</span></span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap"></span><span class="m_7936266447044576261s" style="display:inline;word-break:break-all;color:rgb(118,101,16);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial">"stack-use-after-return"</span></span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap"></span><span class="m_7936266447044576261p" style="display:inline;word-break:break-all;font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial"><wbr>,</span></span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap"> </span><span class="m_7936266447044576261s" style="display:inline;word-break:break-all;color:rgb(118,101,16);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial">"Use of returned stack memory"</span></span><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap"></span><span class="m_7936266447044576261p" style="display:inline;word-break:break-all;font-family:Menlo,Consolas,Monaco,monospace;font-size:11px;white-space:pre-wrap;background-color:rgba(151,234,151,0.298039)"><span class="m_7936266447044576261bright" style="display:inline;word-break:break-all;background-color:rgba(151,234,151,0.6);background-position:initial initial;background-repeat:initial initial">)</span></span><br></div><div><br></div></span><div><br><div class="gmail_quote"><div>Maybe "Use of stack memory after (function) return"? (i couldn't decide whether to include "function". Either delete it or delete the parens.</div><div>This is a very minor nit, so I'm ok with keeping the current wording if you prefer that.</div><div><div class="h5"><div><br></div><div><br></div><div>On Fri, 2 Dec 2016 at 20:04, Kuba (Brecka) Mracek via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">kubabrecka added a comment.<br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br>In <a href="https://reviews.llvm.org/D27017#611894" rel="noreferrer" class="m_7936266447044576261gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D27017#611894</a>, @filcab wrote:<br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br>> LGTM<br class="m_7936266447044576261gmail_msg"><br>><br class="m_7936266447044576261gmail_msg"><br>> (I commented on a minor nit. It might just be me, so feel free to keep the current wording if you feel it's preferred)<br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br>I'm not seeing this comment.  Can you post it again?<br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br><a href="https://reviews.llvm.org/D27017" rel="noreferrer" class="m_7936266447044576261gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D27017</a><br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br><br class="m_7936266447044576261gmail_msg"><br></blockquote></div></div></div></div>
</blockquote></div><br></div>