<div dir="ltr">Hey Todd, Did you run the tests earlier?  If so what was the result?  No worries if you didn't run them yet, but it sounded like you were already kicking it off at 11:30.  Just want to make sure you didn't finish and forget to update with the result :)<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 16, 2016 at 12:38 PM Todd Fiala <<a href="mailto:todd.fiala@gmail.com">todd.fiala@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Yep - I followed that.  I'm just doing the "build + test" verification on macOS.<div class="gmail_msg"><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg"></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner <span dir="ltr" class="gmail_msg"><<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">BTW, I would still like to get Chris to take a look at my usage of llvm::Twine.  Even if it works, I'm not sure if I used it correctly.</div><div class="m_4237202819273627784HOEnZb gmail_msg"><div class="m_4237202819273627784h5 gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">Either way is fine, I think you might have hit a merge conflict if you stacked them, but if you've already worked through it, then no big deal.</div><br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg"><div class="gmail_quote m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg"><div dir="ltr" class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">On Wed, Nov 16, 2016 at 11:30 AM Todd Fiala <<a href="mailto:todd.fiala@gmail.com" class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg" target="_blank">todd.fiala@gmail.com</a>> wrote:<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg"></div><blockquote class="gmail_quote m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">tfiala added a comment.<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
I'm going to test this one now, stacked on top of the final macOS-working version of <a href="https://reviews.llvm.org/D26698" rel="noreferrer" class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D26698</a>.  Tell me now if you want it tested independently of <a href="https://reviews.llvm.org/D26698" rel="noreferrer" class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D26698</a>.<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<a href="https://reviews.llvm.org/D26721" rel="noreferrer" class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D26721</a><br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
<br class="m_4237202819273627784m_-3390863547758527553gmail_msg gmail_msg">
</blockquote></div></blockquote></div>
</div></div></blockquote></div><br class="gmail_msg"><br clear="all" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg">-- <br class="gmail_msg"><div class="m_4237202819273627784gmail_signature gmail_msg" data-smartmail="gmail_signature"><div dir="ltr" class="gmail_msg">-Todd</div></div>
</div></blockquote></div></div>