<div dir="ltr">Okay cool. I'm building against this now. Should I hold off testing?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 16, 2016 at 3:41 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It's no problem, I actually found a few functions I forgot to convert, so I'm making some additional changes. Nothing that requires additional testing, but at the very least I won't be able to get this in until tomorrow at the earliest, so it's no biggie.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 16, 2016 at 3:17 PM Todd Fiala <<a href="mailto:todd.fiala@gmail.com" target="_blank">todd.fiala@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Zachary,<div class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"></div><div class="m_3334347233669763404gmail_msg">I had to run home unexpectedly. The build worked but I left before the test results came out.</div><div class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"></div><div class="m_3334347233669763404gmail_msg">If you ran it on Linux and the Linux tests passed, we can address issues that show up on the macOS side.</div><div class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"></div><div class="m_3334347233669763404gmail_msg">I will also try it at home on macOS, but I don't think you need to hold up with the aforementioned caveat on running the Linux tests.</div><div class="m_3334347233669763404gmail_msg"><span class="m_3334347233669763404gmail_msg"></span><br class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg">On Wednesday, November 16, 2016, Zachary Turner <<a href="mailto:zturner@google.com" class="m_3334347233669763404gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="m_3334347233669763404gmail_msg"><blockquote class="gmail_quote m_3334347233669763404gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_3334347233669763404gmail_msg">Hey Todd, Did you run the tests earlier? If so what was the result? No worries if you didn't run them yet, but it sounded like you were already kicking it off at 11:30. Just want to make sure you didn't finish and forget to update with the result :)<br class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"><div class="gmail_quote m_3334347233669763404gmail_msg"><div dir="ltr" class="m_3334347233669763404gmail_msg">On Wed, Nov 16, 2016 at 12:38 PM Todd Fiala <<a class="m_3334347233669763404gmail_msg">todd.fiala@gmail.com</a>> wrote:<br class="m_3334347233669763404gmail_msg"></div><blockquote class="gmail_quote m_3334347233669763404gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_3334347233669763404gmail_msg">Yep - I followed that. I'm just doing the "build + test" verification on macOS.<div class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"></div></div><div class="gmail_extra m_3334347233669763404gmail_msg"></div><div class="gmail_extra m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"><div class="gmail_quote m_3334347233669763404gmail_msg">On Wed, Nov 16, 2016 at 11:41 AM, Zachary Turner <span dir="ltr" class="m_3334347233669763404gmail_msg"><<a class="m_3334347233669763404gmail_msg">zturner@google.com</a>></span> wrote:<br class="m_3334347233669763404gmail_msg"><blockquote class="gmail_quote m_3334347233669763404gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_3334347233669763404gmail_msg">BTW, I would still like to get Chris to take a look at my usage of llvm::Twine. Even if it works, I'm not sure if I used it correctly.</div><div class="m_3334347233669763404gmail_msg"><div class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"><div class="gmail_quote m_3334347233669763404gmail_msg"><div dir="ltr" class="m_3334347233669763404gmail_msg">On Wed, Nov 16, 2016 at 11:36 AM Zachary Turner <<a class="m_3334347233669763404gmail_msg">zturner@google.com</a>> wrote:<br class="m_3334347233669763404gmail_msg"></div><blockquote class="gmail_quote m_3334347233669763404gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_3334347233669763404gmail_msg">Either way is fine, I think you might have hit a merge conflict if you stacked them, but if you've already worked through it, then no big deal.</div><br class="m_3334347233669763404gmail_msg"><div class="gmail_quote m_3334347233669763404gmail_msg"><div dir="ltr" class="m_3334347233669763404gmail_msg">On Wed, Nov 16, 2016 at 11:30 AM Todd Fiala <<a class="m_3334347233669763404gmail_msg">todd.fiala@gmail.com</a>> wrote:<br class="m_3334347233669763404gmail_msg"></div><blockquote class="gmail_quote m_3334347233669763404gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">tfiala added a comment.<br class="m_3334347233669763404gmail_msg">
<br class="m_3334347233669763404gmail_msg">
I'm going to test this one now, stacked on top of the final macOS-working version of <a href="https://reviews.llvm.org/D26698" rel="noreferrer" class="m_3334347233669763404gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D26698</a>. Tell me now if you want it tested independently of <a href="https://reviews.llvm.org/D26698" rel="noreferrer" class="m_3334347233669763404gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D26698</a>.<br class="m_3334347233669763404gmail_msg">
<br class="m_3334347233669763404gmail_msg">
<br class="m_3334347233669763404gmail_msg">
<a href="https://reviews.llvm.org/D26721" rel="noreferrer" class="m_3334347233669763404gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D26721</a><br class="m_3334347233669763404gmail_msg">
<br class="m_3334347233669763404gmail_msg">
<br class="m_3334347233669763404gmail_msg">
<br class="m_3334347233669763404gmail_msg">
</blockquote></div></blockquote></div>
</div></div></blockquote></div><br class="m_3334347233669763404gmail_msg"><br clear="all" class="m_3334347233669763404gmail_msg"><div class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg"></div></div><div class="gmail_extra m_3334347233669763404gmail_msg">-- <br class="m_3334347233669763404gmail_msg"><div data-smartmail="gmail_signature" class="m_3334347233669763404gmail_msg"><div dir="ltr" class="m_3334347233669763404gmail_msg">-Todd</div></div>
</div></blockquote></div></div>
</blockquote></div><br class="m_3334347233669763404gmail_msg"><br class="m_3334347233669763404gmail_msg">-- <br class="m_3334347233669763404gmail_msg"><div dir="ltr" class="m_3334347233669763404gmail_msg">-Todd</div><br class="m_3334347233669763404gmail_msg">
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-Todd</div></div>
</div>