No that sounds like a good change.  Lgtm<br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 14, 2016 at 3:00 AM Sam McCall <<a href="mailto:sammccall@google.com">sammccall@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Agreed, I updated the patch.<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">For the classes I touched, I also removed init-list initializers that had no effect (e.g. where the member is ConstString and the initalizer explictly called the default constructor). To me this seems part and parcel of using in-class initializers consistently, but LMK if I should revert that.</div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Fri, Nov 11, 2016 at 6:11 PM, Zachary Turner <span dir="ltr" class="gmail_msg"><<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yea, I agree doing it for a whole class at a time should be the standard <br class="gmail_msg"><div class="m_-383596076873028671HOEnZb gmail_msg"><div class="m_-383596076873028671h5 gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Fri, Nov 11, 2016 at 9:10 AM Jim Ingham <<a href="mailto:jingham@apple.com" class="gmail_msg" target="_blank">jingham@apple.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> On Nov 10, 2016, at 8:57 PM, Zachary Turner via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> Maybe just inline the initializations so we don't have to repeat code across multiple constructors?  i.e.<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> bool m_is_resolved = false;<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> in the header file.<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
I actually like the ability to do this in the header file, that seems clearer to me.  But if we're going to start doing this more widely I think it would be better to do it consistently  - maybe converting on a class by class basis when you touch one of the ivars in the class?  Having to look in two places for all these default initializations with only history as the pattern seems like it will make the code harder to read.<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
Jim<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> On Thu, Nov 10, 2016 at 8:54 PM Sam McCall via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> sammccall created this revision.<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> sammccall added a subscriber: lldb-commits.<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> Fix uninitialized members.<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> <a href="https://reviews.llvm.org/D26528" rel="noreferrer" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D26528</a><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> Files:<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>   source/Host/common/FileSpec.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>   source/Target/Process.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> Index: source/Target/Process.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> ===================================================================<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> --- source/Target/Process.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> +++ source/Target/Process.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> @@ -4581,7 +4581,7 @@<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>        : IOHandler(process->GetTarget().GetDebugger(),<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>                    IOHandler::Type::ProcessIO),<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>          m_process(process), m_read_file(), m_write_file(write_fd, false),<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> -        m_pipe() {<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> +        m_pipe(), m_is_running(false) {<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>      m_pipe.CreateNew(false);<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>      m_read_file.SetDescriptor(GetInputFD(), false);<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>    }<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> Index: source/Host/common/FileSpec.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> ===================================================================<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> --- source/Host/common/FileSpec.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> +++ source/Host/common/FileSpec.cpp<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> @@ -278,8 +278,8 @@<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>  }<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>  FileSpec::FileSpec()<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> -    : m_directory(), m_filename(), m_syntax(FileSystem::GetNativePathSyntax()) {<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> -}<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> +    : m_directory(), m_filename(), m_is_resolved(false),<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> +      m_syntax(FileSystem::GetNativePathSyntax()) {}<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>  //------------------------------------------------------------------<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
>  // Default constructor that can take an optional full path to a<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> _______________________________________________<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> lldb-commits mailing list<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> _______________________________________________<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> lldb-commits mailing list<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
<br class="m_-383596076873028671m_8478118418954319030gmail_msg gmail_msg">
</blockquote></div>
</div></div></blockquote></div><br class="gmail_msg"></div></div></blockquote></div>