<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 10, 2016, at 9:00 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Am I missing something? We're talking about lldb::Error here, and llvm::Expected<T>. The two classes are unrelated right? lldb::Error != llvm::Error</div></div></blockquote><div><br class=""></div><div>Oh, I just noticed now that I had two commits back-to-back, and I had a wrong rebase, so r286561 changed lldb::Error by mistake and r286562 is supposed to put it back as before.</div><div><br class=""></div><div>Sorry for the noise!</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Nov 10, 2016 at 8:39 PM Mehdi Amini via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br class="gmail_msg">
Date: Thu Nov 10 22:29:25 2016<br class="gmail_msg">
New Revision: 286562<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=286562&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=286562&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Prevent at compile time converting from Error::success() to Expected<T><br class="gmail_msg">
<br class="gmail_msg">
This would trigger an assertion at runtime otherwise.<br class="gmail_msg">
<br class="gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D26482" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26482</a><br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
lldb/trunk/include/lldb/Target/Process.h<br class="gmail_msg">
lldb/trunk/source/Commands/CommandObjectDisassemble.cpp<br class="gmail_msg">
lldb/trunk/source/Commands/CommandObjectExpression.cpp<br class="gmail_msg">
lldb/trunk/source/Core/ModuleList.cpp<br class="gmail_msg">
lldb/trunk/source/Host/common/NativeBreakpoint.cpp<br class="gmail_msg">
lldb/trunk/source/Host/common/NativeBreakpointList.cpp<br class="gmail_msg">
lldb/trunk/source/Host/common/NativeProcessProtocol.cpp<br class="gmail_msg">
lldb/trunk/source/Host/common/NativeWatchpointList.cpp<br class="gmail_msg">
lldb/trunk/source/Host/common/SoftwareBreakpoint.cpp<br class="gmail_msg">
lldb/trunk/source/Host/posix/FileSystem.cpp<br class="gmail_msg">
lldb/trunk/source/Host/posix/MainLoopPosix.cpp<br class="gmail_msg">
lldb/trunk/source/Host/posix/PipePosix.cpp<br class="gmail_msg">
lldb/trunk/source/Interpreter/OptionGroupVariable.cpp<br class="gmail_msg">
lldb/trunk/source/Interpreter/OptionValueString.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp<br class="gmail_msg">
lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp<br class="gmail_msg">
lldb/trunk/source/Target/Platform.cpp<br class="gmail_msg">
lldb/trunk/source/Target/Process.cpp<br class="gmail_msg">
lldb/trunk/source/Target/Thread.cpp<br class="gmail_msg">
lldb/trunk/source/Utility/ModuleCache.cpp<br class="gmail_msg">
lldb/trunk/tools/lldb-server/lldb-platform.cpp<br class="gmail_msg">
lldb/trunk/unittests/Utility/ModuleCacheTest.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/include/lldb/Target/Process.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/Process.h?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/Process.h?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/include/lldb/Target/Process.h (original)<br class="gmail_msg">
+++ lldb/trunk/include/lldb/Target/Process.h Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -1082,9 +1082,7 @@ public:<br class="gmail_msg">
/// @return<br class="gmail_msg">
/// Returns an error object.<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
- virtual Error WillAttachToProcessWithID(lldb::pid_t pid) {<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
- }<br class="gmail_msg">
+ virtual Error WillAttachToProcessWithID(lldb::pid_t pid) { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
/// Called before attaching to a process.<br class="gmail_msg">
@@ -1097,7 +1095,7 @@ public:<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
virtual Error WillAttachToProcessWithName(const char *process_name,<br class="gmail_msg">
bool wait_for_launch) {<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
@@ -1206,7 +1204,7 @@ public:<br class="gmail_msg">
/// @return<br class="gmail_msg">
/// Returns an error object.<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
- virtual Error WillLaunch(Module *module) { return Error::success(); }<br class="gmail_msg">
+ virtual Error WillLaunch(Module *module) { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
/// Launch a new process.<br class="gmail_msg">
@@ -1252,7 +1250,7 @@ public:<br class="gmail_msg">
/// @return<br class="gmail_msg">
/// Returns an error object.<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
- virtual Error WillResume() { return Error::success(); }<br class="gmail_msg">
+ virtual Error WillResume() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
/// Resumes all of a process's threads as configured using the<br class="gmail_msg">
@@ -1296,7 +1294,7 @@ public:<br class="gmail_msg">
/// @return<br class="gmail_msg">
/// Returns an error object.<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
- virtual Error WillHalt() { return Error::success(); }<br class="gmail_msg">
+ virtual Error WillHalt() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
/// Halts a running process.<br class="gmail_msg">
@@ -1343,7 +1341,7 @@ public:<br class="gmail_msg">
/// @return<br class="gmail_msg">
/// Returns an error object.<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
- virtual Error WillDetach() { return Error::success(); }<br class="gmail_msg">
+ virtual Error WillDetach() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
/// Detaches from a running or stopped process.<br class="gmail_msg">
@@ -1381,7 +1379,7 @@ public:<br class="gmail_msg">
/// Process::DoSignal(int), otherwise an error describing what<br class="gmail_msg">
/// prevents the signal from being sent.<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
- virtual Error WillSignal() { return Error::success(); }<br class="gmail_msg">
+ virtual Error WillSignal() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
/// Sends a process a UNIX signal \a signal.<br class="gmail_msg">
@@ -1397,7 +1395,7 @@ public:<br class="gmail_msg">
return error;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- virtual Error WillDestroy() { return Error::success(); }<br class="gmail_msg">
+ virtual Error WillDestroy() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
virtual Error DoDestroy() = 0;<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Commands/CommandObjectDisassemble.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectDisassemble.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectDisassemble.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Commands/CommandObjectDisassemble.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Commands/CommandObjectDisassemble.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -231,7 +231,7 @@ Error CommandObjectDisassemble::CommandO<br class="gmail_msg">
ExecutionContext *execution_context) {<br class="gmail_msg">
if (!some_location_specified)<br class="gmail_msg">
current_function = true;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
llvm::ArrayRef<OptionDefinition><br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Commands/CommandObjectExpression.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Commands/CommandObjectExpression.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -303,7 +303,7 @@ CanBeUsedForElementCountPrinting(ValueOb<br class="gmail_msg">
return Error("as it does not refer to a pointer");<br class="gmail_msg">
if (pointee.IsVoidType())<br class="gmail_msg">
return Error("as it refers to a pointer to void");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
bool CommandObjectExpression::EvaluateExpression(const char *expr,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Core/ModuleList.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ModuleList.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ModuleList.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Core/ModuleList.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Core/ModuleList.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -788,7 +788,7 @@ Error ModuleList::GetSharedModule(const<br class="gmail_msg">
*did_create_ptr = true;<br class="gmail_msg">
<br class="gmail_msg">
shared_module_list.ReplaceEquivalent(module_sp);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
} else {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/common/NativeBreakpoint.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeBreakpoint.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeBreakpoint.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/common/NativeBreakpoint.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/common/NativeBreakpoint.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -53,7 +53,7 @@ Error NativeBreakpoint::Enable() {<br class="gmail_msg">
log->Printf("NativeBreakpoint::%s addr = 0x%" PRIx64<br class="gmail_msg">
" already enabled, ignoring.",<br class="gmail_msg">
__FUNCTION__, m_addr);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// Log and enable.<br class="gmail_msg">
@@ -85,7 +85,7 @@ Error NativeBreakpoint::Disable() {<br class="gmail_msg">
log->Printf("NativeBreakpoint::%s addr = 0x%" PRIx64<br class="gmail_msg">
" already disabled, ignoring.",<br class="gmail_msg">
__FUNCTION__, m_addr);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// Log and disable.<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/common/NativeBreakpointList.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeBreakpointList.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeBreakpointList.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/common/NativeBreakpointList.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/common/NativeBreakpointList.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -40,7 +40,7 @@ Error NativeBreakpointList::AddRef(lldb:<br class="gmail_msg">
__FUNCTION__, addr);<br class="gmail_msg">
<br class="gmail_msg">
iter->second->AddRef();<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// Create a new breakpoint using the given create func.<br class="gmail_msg">
@@ -205,7 +205,7 @@ Error NativeBreakpointList::GetBreakpoin<br class="gmail_msg">
<br class="gmail_msg">
// Disable it.<br class="gmail_msg">
breakpoint_sp = iter->second;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error NativeBreakpointList::RemoveTrapsFromBuffer(lldb::addr_t addr, void *buf,<br class="gmail_msg">
@@ -225,5 +225,5 @@ Error NativeBreakpointList::RemoveTrapsF<br class="gmail_msg">
auto opcode_size = software_bp_sp->m_opcode_size;<br class="gmail_msg">
::memcpy(opcode_addr, saved_opcodes, opcode_size);<br class="gmail_msg">
}<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/common/NativeProcessProtocol.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeProcessProtocol.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeProcessProtocol.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/common/NativeProcessProtocol.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/common/NativeProcessProtocol.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -405,7 +405,7 @@ Error NativeProcessProtocol::ResolveProc<br class="gmail_msg">
<br class="gmail_msg">
arch = module_specs.GetModuleSpecRefAtIndex(0).GetArchitecture();<br class="gmail_msg">
if (arch.IsValid())<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
else<br class="gmail_msg">
return Error("failed to retrieve a valid architecture from the exe module");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/common/NativeWatchpointList.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeWatchpointList.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/NativeWatchpointList.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/common/NativeWatchpointList.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/common/NativeWatchpointList.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -17,12 +17,12 @@ using namespace lldb_private;<br class="gmail_msg">
Error NativeWatchpointList::Add(addr_t addr, size_t size, uint32_t watch_flags,<br class="gmail_msg">
bool hardware) {<br class="gmail_msg">
m_watchpoints[addr] = {addr, size, watch_flags, hardware};<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error NativeWatchpointList::Remove(addr_t addr) {<br class="gmail_msg">
m_watchpoints.erase(addr);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
const NativeWatchpointList::WatchpointMap &<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/common/SoftwareBreakpoint.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/SoftwareBreakpoint.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/SoftwareBreakpoint.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/common/SoftwareBreakpoint.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/common/SoftwareBreakpoint.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -103,7 +103,7 @@ Error SoftwareBreakpoint::CreateSoftware<br class="gmail_msg">
// breakpoint.<br class="gmail_msg">
breakpoint_sp.reset(new SoftwareBreakpoint(process, addr, saved_opcode_bytes,<br class="gmail_msg">
bp_opcode_bytes, bp_opcode_size));<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error SoftwareBreakpoint::EnableSoftwareBreakpoint(<br class="gmail_msg">
@@ -219,7 +219,7 @@ Error SoftwareBreakpoint::EnableSoftware<br class="gmail_msg">
log->Printf("SoftwareBreakpoint::%s addr = 0x%" PRIx64 " -- SUCCESS",<br class="gmail_msg">
__FUNCTION__, addr);<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// -------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/posix/FileSystem.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/FileSystem.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/FileSystem.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/posix/FileSystem.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/posix/FileSystem.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -62,7 +62,7 @@ Error FileSystem::MakeDirectory(const Fi<br class="gmail_msg">
} break;<br class="gmail_msg">
case EEXIST: {<br class="gmail_msg">
if (file_spec.IsDirectory())<br class="gmail_msg">
- return Error::success(); // It is a directory and it already exists<br class="gmail_msg">
+ return Error(); // It is a directory and it already exists<br class="gmail_msg">
} break;<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
@@ -210,7 +210,7 @@ Error FileSystem::ResolveSymbolicLink(co<br class="gmail_msg">
<br class="gmail_msg">
dst = FileSpec(real_path, false);<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
#if defined(__NetBSD__)<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/posix/MainLoopPosix.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/MainLoopPosix.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/MainLoopPosix.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/posix/MainLoopPosix.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/posix/MainLoopPosix.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -160,7 +160,7 @@ Error MainLoopPosix::Run() {<br class="gmail_msg">
it->second.callback(*this); // Do the work<br class="gmail_msg">
<br class="gmail_msg">
if (m_terminate_request)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
for (int fd : read_fds) {<br class="gmail_msg">
@@ -175,8 +175,8 @@ Error MainLoopPosix::Run() {<br class="gmail_msg">
it->second(*this); // Do the work<br class="gmail_msg">
<br class="gmail_msg">
if (m_terminate_request)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/posix/PipePosix.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/PipePosix.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/posix/PipePosix.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/posix/PipePosix.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/posix/PipePosix.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -206,7 +206,7 @@ Error PipePosix::OpenAsWriterWithTimeout<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
int PipePosix::GetReadFileDescriptor() const { return m_fds[READ]; }<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Interpreter/OptionGroupVariable.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionGroupVariable.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionGroupVariable.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Interpreter/OptionGroupVariable.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Interpreter/OptionGroupVariable.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -59,13 +59,13 @@ static Error ValidateNamedSummary(const<br class="gmail_msg">
if (DataVisualization::NamedSummaryFormats::GetSummaryFormat(<br class="gmail_msg">
ConstString(str), summary_sp) == false)<br class="gmail_msg">
return Error("must specify a valid named summary");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
static Error ValidateSummaryString(const char *str, void *) {<br class="gmail_msg">
if (!str || !str[0])<br class="gmail_msg">
return Error("must specify a non-empty summary string");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
OptionGroupVariable::OptionGroupVariable(bool show_frame_options)<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Interpreter/OptionValueString.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionValueString.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/OptionValueString.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Interpreter/OptionValueString.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Interpreter/OptionValueString.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -133,7 +133,7 @@ Error OptionValueString::SetCurrentValue<br class="gmail_msg">
return error;<br class="gmail_msg">
}<br class="gmail_msg">
m_current_value.assign(value);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error OptionValueString::AppendToCurrentValue(const char *value) {<br class="gmail_msg">
@@ -148,5 +148,5 @@ Error OptionValueString::AppendToCurrent<br class="gmail_msg">
} else<br class="gmail_msg">
m_current_value.append(value);<br class="gmail_msg">
}<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -213,7 +213,7 @@ ModuleSP DynamicLoaderHexagonDYLD::GetTa<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// AD: Needs to be updated?<br class="gmail_msg">
-Error DynamicLoaderHexagonDYLD::CanLoadImage() { return Error::success(); }<br class="gmail_msg">
+Error DynamicLoaderHexagonDYLD::CanLoadImage() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
void DynamicLoaderHexagonDYLD::UpdateLoadedSections(ModuleSP module,<br class="gmail_msg">
addr_t link_map_addr,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -221,7 +221,7 @@ void DynamicLoaderPOSIXDYLD::DidLaunch()<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-Error DynamicLoaderPOSIXDYLD::CanLoadImage() { return Error::success(); }<br class="gmail_msg">
+Error DynamicLoaderPOSIXDYLD::CanLoadImage() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
void DynamicLoaderPOSIXDYLD::UpdateLoadedSections(ModuleSP module,<br class="gmail_msg">
addr_t link_map_addr,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -61,7 +61,7 @@ void DynamicLoaderWindowsDYLD::DidAttach<br class="gmail_msg">
<br class="gmail_msg">
void DynamicLoaderWindowsDYLD::DidLaunch() {}<br class="gmail_msg">
<br class="gmail_msg">
-Error DynamicLoaderWindowsDYLD::CanLoadImage() { return Error::success(); }<br class="gmail_msg">
+Error DynamicLoaderWindowsDYLD::CanLoadImage() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
ConstString DynamicLoaderWindowsDYLD::GetPluginName() {<br class="gmail_msg">
return GetPluginNameStatic();<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -381,7 +381,7 @@ Error AdbClient::internalShell(const cha<br class="gmail_msg">
std::string(output_buf.begin(), output_buf.end()).c_str());<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error AdbClient::Shell(const char *command, uint32_t timeout_ms,<br class="gmail_msg">
@@ -412,7 +412,7 @@ Error AdbClient::ShellToFile(const char<br class="gmail_msg">
dst.close();<br class="gmail_msg">
if (!dst)<br class="gmail_msg">
return Error("Failed to write file %s", output_filename.c_str());<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
std::unique_ptr<AdbClient::SyncService><br class="gmail_msg">
@@ -536,7 +536,7 @@ Error AdbClient::SyncService::internalSt<br class="gmail_msg">
mode = extractor.GetU32(&offset);<br class="gmail_msg">
size = extractor.GetU32(&offset);<br class="gmail_msg">
mtime = extractor.GetU32(&offset);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error AdbClient::SyncService::PullFile(const FileSpec &remote_file,<br class="gmail_msg">
@@ -641,7 +641,7 @@ Error AdbClient::SyncService::PullFileCh<br class="gmail_msg">
} else<br class="gmail_msg">
return Error("Pull failed with unknown response: %s", response_id.c_str());<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error AdbClient::SyncService::ReadAllBytes(void *buffer, size_t size) {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -252,7 +252,7 @@ Error PlatformFreeBSD::GetFileWithUUID(c<br class="gmail_msg">
<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/Kalimba/PlatformKalimba.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -179,7 +179,7 @@ Error PlatformKalimba::ResolveExecutable<br class="gmail_msg">
Error PlatformKalimba::GetFileWithUUID(const FileSpec & /*platform_file*/,<br class="gmail_msg">
const UUID * /*uuid_ptr*/,<br class="gmail_msg">
FileSpec & /*local_file*/) {<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -341,7 +341,7 @@ Error PlatformLinux::GetFileWithUUID(con<br class="gmail_msg">
<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -71,7 +71,7 @@ lldb_private::Error PlatformAppleSimulat<br class="gmail_msg">
<br class="gmail_msg">
if (spawned) {<br class="gmail_msg">
launch_info.SetProcessID(spawned.GetPID());<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
} else<br class="gmail_msg">
return spawned.GetError();<br class="gmail_msg">
#else<br class="gmail_msg">
@@ -164,7 +164,7 @@ Error PlatformAppleSimulator::ConnectRem<br class="gmail_msg">
Error PlatformAppleSimulator::DisconnectRemote() {<br class="gmail_msg">
#if defined(__APPLE__)<br class="gmail_msg">
m_device.reset();<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
#else<br class="gmail_msg">
Error err;<br class="gmail_msg">
err.SetErrorString(UNSUPPORTED_ERROR);<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -393,7 +393,7 @@ lldb_private::Error PlatformDarwin::GetS<br class="gmail_msg">
module_spec.GetArchitecture());<br class="gmail_msg">
module_sp.reset(new Module(local_spec));<br class="gmail_msg">
module_sp->SetPlatformFileSpec(module_spec.GetFileSpec());<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
@@ -433,7 +433,7 @@ lldb_private::Error PlatformDarwin::GetS<br class="gmail_msg">
(IsHost() ? "host" : "remote"),<br class="gmail_msg">
module_spec.GetFileSpec().GetDirectory().AsCString(),<br class="gmail_msg">
module_spec.GetFileSpec().GetFilename().AsCString());<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// bring in the remote module file<br class="gmail_msg">
@@ -455,7 +455,7 @@ lldb_private::Error PlatformDarwin::GetS<br class="gmail_msg">
ModuleSpec local_spec(module_cache_spec, module_spec.GetArchitecture());<br class="gmail_msg">
module_sp.reset(new Module(local_spec));<br class="gmail_msg">
module_sp->SetPlatformFileSpec(module_spec.GetFileSpec());<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
} else<br class="gmail_msg">
return Error("unable to obtain valid module file");<br class="gmail_msg">
} else<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -247,7 +247,7 @@ Error PlatformMacOSX::GetSymbolFile(cons<br class="gmail_msg">
<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
lldb_private::Error<br class="gmail_msg">
@@ -264,7 +264,7 @@ PlatformMacOSX::GetFileWithUUID(const ll<br class="gmail_msg">
if (local_os_build.compare(remote_os_build) == 0) {<br class="gmail_msg">
// same OS version: the local file is good enough<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
} else {<br class="gmail_msg">
// try to find the file in the cache<br class="gmail_msg">
std::string cache_path(GetLocalCacheDirectory());<br class="gmail_msg">
@@ -273,7 +273,7 @@ PlatformMacOSX::GetFileWithUUID(const ll<br class="gmail_msg">
FileSpec module_cache_spec(cache_path, false);<br class="gmail_msg">
if (module_cache_spec.Exists()) {<br class="gmail_msg">
local_file = module_cache_spec;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
// bring in the remote module file<br class="gmail_msg">
FileSpec module_cache_folder =<br class="gmail_msg">
@@ -288,13 +288,13 @@ PlatformMacOSX::GetFileWithUUID(const ll<br class="gmail_msg">
return err;<br class="gmail_msg">
if (module_cache_spec.Exists()) {<br class="gmail_msg">
local_file = module_cache_spec;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
} else<br class="gmail_msg">
return Error("unable to obtain valid module file");<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
bool PlatformMacOSX::GetSupportedArchitectureAtIndex(uint32_t idx,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -244,7 +244,7 @@ Error PlatformNetBSD::GetFileWithUUID(co<br class="gmail_msg">
<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -207,7 +207,7 @@ PlatformPOSIX::PutFile(const lldb_privat<br class="gmail_msg">
<br class="gmail_msg">
if (IsHost()) {<br class="gmail_msg">
if (FileSpec::Equal(source, destination, true))<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
// cp src dst<br class="gmail_msg">
// chown uid:gid dst<br class="gmail_msg">
std::string src_path(source.GetPath());<br class="gmail_msg">
@@ -223,10 +223,10 @@ PlatformPOSIX::PutFile(const lldb_privat<br class="gmail_msg">
if (status != 0)<br class="gmail_msg">
return Error("unable to perform copy");<br class="gmail_msg">
if (uid == UINT32_MAX && gid == UINT32_MAX)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
if (chown_file(this, dst_path.c_str(), uid, gid) != 0)<br class="gmail_msg">
return Error("unable to perform chown");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
} else if (m_remote_platform_sp) {<br class="gmail_msg">
if (GetSupportsRSync()) {<br class="gmail_msg">
std::string src_path(source.GetPath());<br class="gmail_msg">
@@ -254,7 +254,7 @@ PlatformPOSIX::PutFile(const lldb_privat<br class="gmail_msg">
// Don't chown a local file for a remote system<br class="gmail_msg">
// if (chown_file(this,dst_path.c_str(),uid,gid) != 0)<br class="gmail_msg">
// return Error("unable to perform chown");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
// if we are still here rsync has failed - let's try the slow way before<br class="gmail_msg">
// giving up<br class="gmail_msg">
@@ -323,7 +323,7 @@ lldb_private::Error PlatformPOSIX::GetFi<br class="gmail_msg">
RunShellCommand(cp_command.GetData(), NULL, &status, NULL, NULL, 10);<br class="gmail_msg">
if (status != 0)<br class="gmail_msg">
return Error("unable to perform copy");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
} else if (m_remote_platform_sp) {<br class="gmail_msg">
if (GetSupportsRSync()) {<br class="gmail_msg">
StreamString command;<br class="gmail_msg">
@@ -343,7 +343,7 @@ lldb_private::Error PlatformPOSIX::GetFi<br class="gmail_msg">
int retcode;<br class="gmail_msg">
Host::RunShellCommand(command.GetData(), NULL, &retcode, NULL, NULL, 60);<br class="gmail_msg">
if (retcode == 0)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
// If we are here, rsync has failed - let's try the slow way before giving<br class="gmail_msg">
// up<br class="gmail_msg">
}<br class="gmail_msg">
@@ -745,7 +745,7 @@ Error PlatformPOSIX::EvaluateLibdlExpres<br class="gmail_msg">
<br class="gmail_msg">
if (result_valobj_sp->GetError().Fail())<br class="gmail_msg">
return result_valobj_sp->GetError();<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
uint32_t PlatformPOSIX::DoLoadImage(lldb_private::Process *process,<br class="gmail_msg">
@@ -833,7 +833,7 @@ Error PlatformPOSIX::UnloadImage(lldb_pr<br class="gmail_msg">
return Error("expression failed: \"%s\"", expr.GetData());<br class="gmail_msg">
process->ResetImageToken(image_token);<br class="gmail_msg">
}<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
lldb::ProcessSP PlatformPOSIX::ConnectProcess(const char *connect_url,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/Windows/PlatformWindows.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -527,7 +527,7 @@ Error PlatformWindows::GetFileWithUUID(c<br class="gmail_msg">
<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error PlatformWindows::GetSharedModule(<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -196,7 +196,7 @@ Error PlatformRemoteGDBServer::GetFileWi<br class="gmail_msg">
FileSpec &local_file) {<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
@@ -482,7 +482,7 @@ Error PlatformRemoteGDBServer::LaunchPro<br class="gmail_msg">
Error PlatformRemoteGDBServer::KillProcess(const lldb::pid_t pid) {<br class="gmail_msg">
if (!KillSpawnedProcess(pid))<br class="gmail_msg">
return Error("failed to kill remote spawned process");<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
lldb::ProcessSP PlatformRemoteGDBServer::DebugProcess(<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -414,7 +414,7 @@ lldb_private::DynamicLoader *ProcessKDP:<br class="gmail_msg">
return m_dyld_ap.get();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-Error ProcessKDP::WillResume() { return Error::success(); }<br class="gmail_msg">
+Error ProcessKDP::WillResume() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
Error ProcessKDP::DoResume() {<br class="gmail_msg">
Error error;<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/elf-core/ProcessElfCore.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -258,7 +258,7 @@ bool ProcessElfCore::UpdateThreadList(Th<br class="gmail_msg">
<br class="gmail_msg">
void ProcessElfCore::RefreshStateAfterStop() {}<br class="gmail_msg">
<br class="gmail_msg">
-Error ProcessElfCore::DoDestroy() { return Error::success(); }<br class="gmail_msg">
+Error ProcessElfCore::DoDestroy() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
// Process Queries<br class="gmail_msg">
@@ -304,7 +304,7 @@ Error ProcessElfCore::GetMemoryRegionInf<br class="gmail_msg">
region_info.SetExecutable(MemoryRegionInfo::eNo);<br class="gmail_msg">
region_info.SetMapped(MemoryRegionInfo::eNo);<br class="gmail_msg">
}<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
region_info.GetRange().SetRangeBase(load_addr);<br class="gmail_msg">
@@ -313,7 +313,7 @@ Error ProcessElfCore::GetMemoryRegionInf<br class="gmail_msg">
region_info.SetWritable(MemoryRegionInfo::eNo);<br class="gmail_msg">
region_info.SetExecutable(MemoryRegionInfo::eNo);<br class="gmail_msg">
region_info.SetMapped(MemoryRegionInfo::eNo);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
size_t ProcessElfCore::DoReadMemory(lldb::addr_t addr, void *buf, size_t size,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -2672,7 +2672,7 @@ lldb_private::Error GDBRemoteCommunicati<br class="gmail_msg">
response.GetEscapedBinaryData(output);<br class="gmail_msg">
if (command_output)<br class="gmail_msg">
command_output->assign(output);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
return Error("unable to send packet");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -197,13 +197,13 @@ Error GDBRemoteCommunicationServerLLGS::<br class="gmail_msg">
__FUNCTION__);<br class="gmail_msg">
<br class="gmail_msg">
m_process_launch_info.SetArguments(const_cast<const char **>(args), true);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error GDBRemoteCommunicationServerLLGS::SetLaunchFlags(<br class="gmail_msg">
unsigned int launch_flags) {<br class="gmail_msg">
m_process_launch_info.GetFlags().Set(launch_flags);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error GDBRemoteCommunicationServerLLGS::LaunchProcess() {<br class="gmail_msg">
@@ -988,7 +988,7 @@ Error GDBRemoteCommunicationServerLLGS::<br class="gmail_msg">
return error;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
void GDBRemoteCommunicationServerLLGS::StartSTDIOForwarding() {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -1252,7 +1252,7 @@ Error ProcessGDBRemote::WillResume() {<br class="gmail_msg">
m_continue_S_tids.clear();<br class="gmail_msg">
m_jstopinfo_sp.reset();<br class="gmail_msg">
m_jthreadsinfo_sp.reset();<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error ProcessGDBRemote::DoResume() {<br class="gmail_msg">
@@ -3246,7 +3246,7 @@ Error ProcessGDBRemote::EstablishConnect<br class="gmail_msg">
const ProcessInfo &process_info) {<br class="gmail_msg">
// Make sure we aren't already connected?<br class="gmail_msg">
if (m_gdb_comm.IsConnected())<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
<br class="gmail_msg">
PlatformSP platform_sp(GetTarget().GetPlatform());<br class="gmail_msg">
if (platform_sp && !platform_sp->IsHost())<br class="gmail_msg">
@@ -4408,7 +4408,7 @@ Error ProcessGDBRemote::GetLoadedModuleL<br class="gmail_msg">
<br class="gmail_msg">
XMLNode root_element = doc.GetRootElement("library-list-svr4");<br class="gmail_msg">
if (!root_element)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
<br class="gmail_msg">
// main link map structure<br class="gmail_msg">
llvm::StringRef main_lm = root_element.GetAttributeValue("main-lm");<br class="gmail_msg">
@@ -4494,7 +4494,7 @@ Error ProcessGDBRemote::GetLoadedModuleL<br class="gmail_msg">
<br class="gmail_msg">
XMLNode root_element = doc.GetRootElement("library-list");<br class="gmail_msg">
if (!root_element)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
<br class="gmail_msg">
root_element.ForEachChildElementWithName(<br class="gmail_msg">
"library", [log, &list](const XMLNode &library) -> bool {<br class="gmail_msg">
@@ -4538,7 +4538,7 @@ Error ProcessGDBRemote::GetLoadedModuleL<br class="gmail_msg">
return Error(0, ErrorType::eErrorTypeGeneric);<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
lldb::ModuleSP ProcessGDBRemote::LoadModuleAtAddress(const FileSpec &file,<br class="gmail_msg">
@@ -4662,7 +4662,7 @@ Error ProcessGDBRemote::GetFileLoadAddre<br class="gmail_msg">
// The file is not loaded into the inferior<br class="gmail_msg">
is_loaded = false;<br class="gmail_msg">
load_addr = LLDB_INVALID_ADDRESS;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
return Error(<br class="gmail_msg">
@@ -4672,7 +4672,7 @@ Error ProcessGDBRemote::GetFileLoadAddre<br class="gmail_msg">
if (response.IsNormalResponse()) {<br class="gmail_msg">
is_loaded = true;<br class="gmail_msg">
load_addr = response.GetHexMaxU64(false, LLDB_INVALID_ADDRESS);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
return Error("Unknown error happened during sending the load address packet");<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/mach-core/ProcessMachCore.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -461,7 +461,7 @@ void ProcessMachCore::RefreshStateAfterS<br class="gmail_msg">
// SetThreadStopInfo (m_last_stop_packet);<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-Error ProcessMachCore::DoDestroy() { return Error::success(); }<br class="gmail_msg">
+Error ProcessMachCore::DoDestroy() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
//------------------------------------------------------------------<br class="gmail_msg">
// Process Queries<br class="gmail_msg">
@@ -564,7 +564,7 @@ Error ProcessMachCore::GetMemoryRegionIn<br class="gmail_msg">
region_info.SetExecutable(MemoryRegionInfo::eNo);<br class="gmail_msg">
region_info.SetMapped(MemoryRegionInfo::eNo);<br class="gmail_msg">
}<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
region_info.GetRange().SetRangeBase(load_addr);<br class="gmail_msg">
@@ -573,7 +573,7 @@ Error ProcessMachCore::GetMemoryRegionIn<br class="gmail_msg">
region_info.SetWritable(MemoryRegionInfo::eNo);<br class="gmail_msg">
region_info.SetExecutable(MemoryRegionInfo::eNo);<br class="gmail_msg">
region_info.SetMapped(MemoryRegionInfo::eNo);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
void ProcessMachCore::Clear() { m_thread_list.Clear(); }<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -133,7 +133,7 @@ ConstString ProcessMinidump::GetPluginNa<br class="gmail_msg">
<br class="gmail_msg">
uint32_t ProcessMinidump::GetPluginVersion() { return 1; }<br class="gmail_msg">
<br class="gmail_msg">
-Error ProcessMinidump::DoDestroy() { return Error::success(); }<br class="gmail_msg">
+Error ProcessMinidump::DoDestroy() { return Error(); }<br class="gmail_msg">
<br class="gmail_msg">
void ProcessMinidump::RefreshStateAfterStop() {<br class="gmail_msg">
if (!m_active_exception)<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/Platform.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Platform.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Platform.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/Platform.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/Platform.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -172,7 +172,7 @@ Error Platform::GetFileWithUUID(const Fi<br class="gmail_msg">
const UUID *uuid_ptr, FileSpec &local_file) {<br class="gmail_msg">
// Default to the local case<br class="gmail_msg">
local_file = platform_file;<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
FileSpecList<br class="gmail_msg">
@@ -1089,7 +1089,7 @@ Error Platform::KillProcess(const lldb::<br class="gmail_msg">
"they are controlled by a process plugin");<br class="gmail_msg">
}<br class="gmail_msg">
Host::Kill(pid, SIGTERM);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
lldb::ProcessSP<br class="gmail_msg">
@@ -1597,7 +1597,7 @@ Error Platform::GetRemoteSharedModule(co<br class="gmail_msg">
const auto error = module_resolver(resolved_module_spec);<br class="gmail_msg">
if (error.Fail()) {<br class="gmail_msg">
if (GetCachedSharedModule(resolved_module_spec, module_sp, did_create_ptr))<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
return error;<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/Process.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/Process.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/Process.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -3359,7 +3359,7 @@ Error Process::Halt(bool clear_thread_pl<br class="gmail_msg">
RestoreProcessEvents();<br class="gmail_msg">
SetExitStatus(SIGKILL, "Cancelled async attach.");<br class="gmail_msg">
Destroy(false);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
// Wait for 10 second for the process to stop.<br class="gmail_msg">
@@ -3375,7 +3375,7 @@ Error Process::Halt(bool clear_thread_pl<br class="gmail_msg">
<br class="gmail_msg">
BroadcastEvent(event_sp);<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error Process::StopForDestroyOrDetach(lldb::EventSP &exit_event_sp) {<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/Thread.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Thread.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Thread.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/Thread.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/Thread.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -1766,7 +1766,7 @@ Error Thread::JumpToLine(const FileSpec<br class="gmail_msg">
if (!reg_ctx->SetPC(dest))<br class="gmail_msg">
return Error("Cannot change PC to target address.");<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
void Thread::DumpUsingSettingsFormat(Stream &strm, uint32_t frame_idx,<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Utility/ModuleCache.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/ModuleCache.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/ModuleCache.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Utility/ModuleCache.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Utility/ModuleCache.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -70,7 +70,7 @@ Error MakeDirectory(const FileSpec &dir_<br class="gmail_msg">
if (!dir_path.IsDirectory())<br class="gmail_msg">
return Error("Invalid existing path");<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
return FileSystem::MakeDirectory(dir_path, eFilePermissionsDirectoryDefault);<br class="gmail_msg">
@@ -141,7 +141,7 @@ Error CreateHostSysRootModuleLink(const<br class="gmail_msg">
platform_module_spec.GetPath().c_str());<br class="gmail_msg">
if (sysroot_module_path_spec.Exists()) {<br class="gmail_msg">
if (!delete_existing)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
<br class="gmail_msg">
DecrementRefExistingModule(root_dir_spec, sysroot_module_path_spec);<br class="gmail_msg">
}<br class="gmail_msg">
@@ -210,7 +210,7 @@ Error ModuleCache::Put(const FileSpec &r<br class="gmail_msg">
if (error.Fail())<br class="gmail_msg">
return Error("Failed to create link to %s: %s",<br class="gmail_msg">
module_file_path.GetPath().c_str(), error.AsCString());<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error ModuleCache::Get(const FileSpec &root_dir_spec, const char *hostname,<br class="gmail_msg">
@@ -221,7 +221,7 @@ Error ModuleCache::Get(const FileSpec &r<br class="gmail_msg">
if (find_it != m_loaded_modules.end()) {<br class="gmail_msg">
cached_module_sp = (*find_it).second.lock();<br class="gmail_msg">
if (cached_module_sp)<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
m_loaded_modules.erase(find_it);<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
@@ -263,7 +263,7 @@ Error ModuleCache::Get(const FileSpec &r<br class="gmail_msg">
m_loaded_modules.insert(<br class="gmail_msg">
std::make_pair(module_spec.GetUUID().GetAsString(), cached_module_sp));<br class="gmail_msg">
<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Error ModuleCache::GetAndPut(const FileSpec &root_dir_spec,<br class="gmail_msg">
@@ -320,7 +320,7 @@ Error ModuleCache::GetAndPut(const FileS<br class="gmail_msg">
// module might<br class="gmail_msg">
// contain the necessary symbols and the debugging is also possible without<br class="gmail_msg">
// a symfile.<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
<br class="gmail_msg">
error = Put(root_dir_spec, escaped_hostname.c_str(), module_spec,<br class="gmail_msg">
tmp_download_sym_file_spec,<br class="gmail_msg">
@@ -332,5 +332,5 @@ Error ModuleCache::GetAndPut(const FileS<br class="gmail_msg">
<br class="gmail_msg">
FileSpec symfile_spec = GetSymbolFileSpec(cached_module_sp->GetFileSpec());<br class="gmail_msg">
cached_module_sp->SetSymbolFileFileSpec(symfile_spec);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-platform.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/tools/lldb-server/lldb-platform.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/tools/lldb-server/lldb-platform.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/tools/lldb-server/lldb-platform.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -130,7 +130,7 @@ static Error save_socket_id_to_file(cons<br class="gmail_msg">
file_spec.GetPath().c_str(), err_code.message().c_str());<br class="gmail_msg">
<br class="gmail_msg">
tmp_file_remover.releaseFile();<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
//----------------------------------------------------------------------<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/unittests/Utility/ModuleCacheTest.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/ModuleCacheTest.cpp?rev=286562&r1=286561&r2=286562&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Utility/ModuleCacheTest.cpp?rev=286562&r1=286561&r2=286562&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/unittests/Utility/ModuleCacheTest.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/unittests/Utility/ModuleCacheTest.cpp Thu Nov 10 22:29:25 2016<br class="gmail_msg">
@@ -114,7 +114,7 @@ void ModuleCacheTest::TryGetAndPut(const<br class="gmail_msg">
std::error_code ec = llvm::sys::fs::copy_file(<br class="gmail_msg">
s_test_executable, tmp_download_file_spec.GetCString());<br class="gmail_msg">
EXPECT_FALSE(ec);<br class="gmail_msg">
- return Error::success();<br class="gmail_msg">
+ return Error();<br class="gmail_msg">
},<br class="gmail_msg">
[](const ModuleSP &module_sp, const FileSpec &tmp_download_file_spec) {<br class="gmail_msg">
return Error("Not supported.");<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>