Just to be clear, if the unit test depends on functionality that isn't present when this target isn't defined, then your original patch sounds correct.<br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 7, 2016 at 11:06 AM Vedant Kumar <<a href="mailto:vsk@apple.com">vsk@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="gmail_msg">
> On Nov 7, 2016, at 8:20 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> Why not?<br class="gmail_msg">
<br class="gmail_msg">
It breaks my build.<br class="gmail_msg">
<br class="gmail_msg">
If the right solution is to fix the unit test, we should advertise somewhere<br class="gmail_msg">
that '-DLLVM_TARGETS_TO_BUILD=X86' is temporarily broken and drop this patch.<br class="gmail_msg">
I'd volunteer to put something like that in place.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
> Just because llvm isn't building support for targeting some architecture doesn't mean lldb shouldn't be able to debug those architectures. We could add a similar LLDB specific define, but using llvm's seems wrong<br class="gmail_msg">
<br class="gmail_msg">
Given 'LLVM_TARGETS_TO_BUILD', how do I define 'LLDB_SUPPORTED_TARGETS'?<br class="gmail_msg">
<br class="gmail_msg">
Do you know of an existing define I can use?<br class="gmail_msg">
<br class="gmail_msg">
thanks,<br class="gmail_msg">
vedant<br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
> On Sun, Nov 6, 2016 at 6:13 PM Vedant Kumar via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
> vsk created this revision.<br class="gmail_msg">
> vsk added a reviewer: jasonmolenda.<br class="gmail_msg">
> vsk added a subscriber: lldb-commits.<br class="gmail_msg">
> Herald added a subscriber: mgorny.<br class="gmail_msg">
><br class="gmail_msg">
> Should fix: <a href="https://llvm.org/bugs/show_bug.cgi?id=30928" rel="noreferrer" class="gmail_msg" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=30928</a><br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> <a href="https://reviews.llvm.org/D26338" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26338</a><br class="gmail_msg">
><br class="gmail_msg">
> Files:<br class="gmail_msg">
>   unittests/UnwindAssembly/CMakeLists.txt<br class="gmail_msg">
>   unittests/UnwindAssembly/InstEmulation/CMakeLists.txt<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> Index: unittests/UnwindAssembly/InstEmulation/CMakeLists.txt<br class="gmail_msg">
> ===================================================================<br class="gmail_msg">
> --- unittests/UnwindAssembly/InstEmulation/CMakeLists.txt<br class="gmail_msg">
> +++ unittests/UnwindAssembly/InstEmulation/CMakeLists.txt<br class="gmail_msg">
> @@ -1 +1,3 @@<br class="gmail_msg">
> -add_lldb_unittest(InstEmulationTests TestArm64InstEmulation.cpp)<br class="gmail_msg">
> +if ("AArch64" IN_LIST LLVM_TARGETS_TO_BUILD)<br class="gmail_msg">
> +  add_lldb_unittest(InstEmulationTests TestArm64InstEmulation.cpp)<br class="gmail_msg">
> +endif()<br class="gmail_msg">
> Index: unittests/UnwindAssembly/CMakeLists.txt<br class="gmail_msg">
> ===================================================================<br class="gmail_msg">
> --- unittests/UnwindAssembly/CMakeLists.txt<br class="gmail_msg">
> +++ unittests/UnwindAssembly/CMakeLists.txt<br class="gmail_msg">
> @@ -1,2 +1,5 @@<br class="gmail_msg">
> -add_subdirectory(x86)<br class="gmail_msg">
> +if ("X86" IN_LIST LLVM_TARGETS_TO_BUILD)<br class="gmail_msg">
> +  add_subdirectory(x86)<br class="gmail_msg">
> +endif()<br class="gmail_msg">
> +<br class="gmail_msg">
>  add_subdirectory(InstEmulation)<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> lldb-commits mailing list<br class="gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>