<div dir="ltr">Hi,<div><br></div><div>Chris, thanks for the heads-up.</div><div>Pavel - yes, this is the case, and I have a patch that fixes it - <a href="https://reviews.llvm.org/D26193">https://reviews.llvm.org/D26193</a></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 1, 2016 at 10:23 AM, Pavel Labath <span dir="ltr"><<a href="mailto:labath@google.com" target="_blank">labath@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the heads-up, Chris.<br>
<br>
Dimitar,<br>
we have had a similar problem for elf core file tests, where lldb<br>
would get confused if we get a running process with the same pid as<br>
the core file. I fixed this in <<a href="https://reviews.llvm.org/D18697" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D18697</a>>, and<br>
I suspect you will need a similar fix for your ProcessMinidump. Could<br>
you check if this is the case, and fix it?<br>
<br>
pl<br>
<br>
On 31 October 2016 at 23:07, Chris Bieneman via lldb-commits<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
> I think the new mini-dump test case added here might be flaky.<br>
><br>
> See: <a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/381" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/lldb-x86_64-ubuntu-<wbr>14.04-cmake/builds/381</a><br>
><br>
> The next build was successful.<br>
><br>
> -Chris<br>
><br>
>> On Oct 31, 2016, at 8:35 AM, Dimitar Vlahovski via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: dvlahovski<br>
>> Date: Mon Oct 31 10:35:18 2016<br>
>> New Revision: 285587<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285587&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=285587&view=rev</a><br>
>> Log:<br>
>> Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull<br>
>><br>
>> Summary:<br>
>> This plugin resembles the already existing Windows-only Minidump plugin.<br>
>> The WinMinidumpPlugin uses the Windows API for parsing Minidumps<br>
>> while this plugin is cross-platform because it includes a Minidump<br>
>> parser (which is already commited)<br>
>><br>
>> It is able to produce a backtrace, to read the general puprose regiters,<br>
>> inspect local variables, show image list, do memory reads, etc.<br>
>><br>
>> For now the only arches that this supports are x86_32 and x86_64.<br>
>> This is because I have only written register contexts for those.<br>
>> Others will come in next CLs.<br>
>><br>
>> I copied the WinMinidump tests and adapted them a little bit for them to<br>
>> work with the new plugin (and they pass)<br>
>> I will add more tests, aiming for better code coverage.<br>
>><br>
>> There is still functionality to be added, see TODOs in code.<br>
>><br>
>> Reviewers: labath, zturner<br>
>><br>
>> Subscribers: beanz, mgorny, modocache, lldb-commits, amccarth<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D25905" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D25905</a><br>
>><br>
>> Added:<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/TestMiniDumpNew.<wbr>py<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/install_breakpad.<wbr>cpp<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64 (with props)<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.cpp<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.dmp<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed (with props)<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.cpp<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.dmp<br>
>> lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/makefile.txt<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/NtStructures.<wbr>h<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.cpp<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.h<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.cpp<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.h<br>
>> Modified:<br>
>> lldb/trunk/source/API/<wbr>SystemInitializerFull.cpp<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/CMakeLists.<wbr>txt<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.cpp<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.h<br>
>> lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpTypes.h<br>
>> lldb/trunk/unittests/Process/<wbr>minidump/MinidumpParserTest.<wbr>cpp<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/TestMiniDumpNew.<wbr>py<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/TestMiniDumpNew.<wbr>py?rev=285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/TestMiniDumpNew.<wbr>py (added)<br>
>> +++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/TestMiniDumpNew.<wbr>py Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,100 @@<br>
>> +"""<br>
>> +Test basics of Minidump debugging.<br>
>> +"""<br>
>> +<br>
>> +from __future__ import print_function<br>
>> +from six import iteritems<br>
>> +<br>
>> +<br>
>> +import lldb<br>
>> +from lldbsuite.test.decorators import *<br>
>> +from lldbsuite.test.lldbtest import *<br>
>> +from lldbsuite.test import lldbutil<br>
>> +<br>
>> +<br>
>> +class MiniDumpNewTestCase(TestBase):<br>
>> +<br>
>> + mydir = TestBase.compute_mydir(__file_<wbr>_)<br>
>> +<br>
>> + NO_DEBUG_INFO_TESTCASE = True<br>
>> +<br>
>> + def test_process_info_in_minidump(<wbr>self):<br>
>> + """Test that lldb can read the process information from the Minidump."""<br>
>> + # target create -c linux-x86_64.dmp<br>
>> + self.dbg.CreateTarget(None)<br>
>> + self.target = self.dbg.GetSelectedTarget()<br>
>> + self.process = self.target.LoadCore("linux-<wbr>x86_64.dmp")<br>
>> + self.assertTrue(self.process, PROCESS_IS_VALID)<br>
>> + self.assertEqual(self.process.<wbr>GetNumThreads(), 1)<br>
>> + self.assertEqual(self.process.<wbr>GetProcessID(), 29917)<br>
>> +<br>
>> + def test_thread_info_in_minidump(<wbr>self):<br>
>> + """Test that lldb can read the thread information from the Minidump."""<br>
>> + # target create -c linux-x86_64.dmp<br>
>> + self.dbg.CreateTarget(None)<br>
>> + self.target = self.dbg.GetSelectedTarget()<br>
>> + self.process = self.target.LoadCore("linux-<wbr>x86_64.dmp")<br>
>> + # This process crashed due to a segmentation fault in its<br>
>> + # one and only thread.<br>
>> + self.assertEqual(self.process.<wbr>GetNumThreads(), 1)<br>
>> + thread = self.process.GetThreadAtIndex(<wbr>0)<br>
>> + self.assertEqual(thread.<wbr>GetStopReason(), lldb.eStopReasonSignal)<br>
>> + stop_description = thread.GetStopDescription(256)<br>
>> + self.assertTrue("SIGSEGV" in stop_description)<br>
>> +<br>
>> + def test_stack_info_in_minidump(<wbr>self):<br>
>> + """Test that we can see a trivial stack in a breakpad-generated Minidump."""<br>
>> + # target create linux-x86_64 -c linux-x86_64.dmp<br>
>> + self.dbg.CreateTarget("linux-<wbr>x86_64")<br>
>> + self.target = self.dbg.GetSelectedTarget()<br>
>> + self.process = self.target.LoadCore("linux-<wbr>x86_64.dmp")<br>
>> + self.assertEqual(self.process.<wbr>GetNumThreads(), 1)<br>
>> + thread = self.process.GetThreadAtIndex(<wbr>0)<br>
>> + # frame #0: linux-x86_64`crash()<br>
>> + # frame #1: linux-x86_64`_start<br>
>> + self.assertEqual(thread.<wbr>GetNumFrames(), 2)<br>
>> + frame = thread.GetFrameAtIndex(0)<br>
>> + self.assertTrue(frame.IsValid(<wbr>))<br>
>> + pc = frame.GetPC()<br>
>> + eip = frame.FindRegister("pc")<br>
>> + self.assertTrue(eip.IsValid())<br>
>> + self.assertEqual(pc, eip.GetValueAsUnsigned())<br>
>> +<br>
>> + def test_snapshot_minidump(self):<br>
>> + """Test that if we load a snapshot minidump file (meaning the process did not crash) there is no stop reason."""<br>
>> + # target create -c linux-x86_64_not_crashed.dmp<br>
>> + self.dbg.CreateTarget(None)<br>
>> + self.target = self.dbg.GetSelectedTarget()<br>
>> + self.process = self.target.LoadCore("linux-<wbr>x86_64_not_crashed.dmp")<br>
>> + self.assertEqual(self.process.<wbr>GetNumThreads(), 1)<br>
>> + thread = self.process.GetThreadAtIndex(<wbr>0)<br>
>> + self.assertEqual(thread.<wbr>GetStopReason(), lldb.eStopReasonNone)<br>
>> + stop_description = thread.GetStopDescription(256)<br>
>> + self.assertEqual(stop_<wbr>description, None)<br>
>> +<br>
>> + def test_deeper_stack_in_minidump(<wbr>self):<br>
>> + """Test that we can examine a more interesting stack in a Minidump."""<br>
>> + # Launch with the Minidump, and inspect the stack.<br>
>> + # target create linux-x86_64_not_crashed -c linux-x86_64_not_crashed.dmp<br>
>> + target = self.dbg.CreateTarget("linux-<wbr>x86_64_not_crashed")<br>
>> + process = target.LoadCore("linux-x86_64_<wbr>not_crashed.dmp")<br>
>> + thread = process.GetThreadAtIndex(0)<br>
>> +<br>
>> + expected_stack = {1: 'bar', 2: 'foo', 3: '_start'}<br>
>> + self.assertGreaterEqual(<wbr>thread.GetNumFrames(), len(expected_stack))<br>
>> + for index, name in iteritems(expected_stack):<br>
>> + frame = thread.GetFrameAtIndex(index)<br>
>> + self.assertTrue(frame.IsValid(<wbr>))<br>
>> + function_name = frame.GetFunctionName()<br>
>> + self.assertTrue(name in function_name)<br>
>> +<br>
>> + def test_local_variables_in_<wbr>minidump(self):<br>
>> + """Test that we can examine local variables in a Minidump."""<br>
>> + # Launch with the Minidump, and inspect a local variable.<br>
>> + # target create linux-x86_64_not_crashed -c linux-x86_64_not_crashed.dmp<br>
>> + target = self.dbg.CreateTarget("linux-<wbr>x86_64_not_crashed")<br>
>> + process = target.LoadCore("linux-x86_64_<wbr>not_crashed.dmp")<br>
>> + thread = process.GetThreadAtIndex(0)<br>
>> + frame = thread.GetFrameAtIndex(1)<br>
>> + value = frame.EvaluateExpression('x')<br>
>> + self.assertEqual(value.<wbr>GetValueAsSigned(), 3)<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/install_breakpad.<wbr>cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/install_breakpad.cpp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/install_breakpad.<wbr>cpp?rev=285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/install_breakpad.<wbr>cpp (added)<br>
>> +++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/install_breakpad.<wbr>cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,16 @@<br>
>> +#include "client/linux/handler/<wbr>exception_handler.h"<br>
>> +<br>
>> +static bool dumpCallback(const google_breakpad::<wbr>MinidumpDescriptor &descriptor,<br>
>> + void *context, bool succeeded) {<br>
>> + return succeeded;<br>
>> +}<br>
>> +<br>
>> +google_breakpad::<wbr>ExceptionHandler *eh;<br>
>> +<br>
>> +void InstallBreakpad() {<br>
>> + google_breakpad::<wbr>MinidumpDescriptor descriptor("/tmp");<br>
>> + eh = new google_breakpad::<wbr>ExceptionHandler(descriptor, NULL, dumpCallback,<br>
>> + NULL, true, -1);<br>
>> +}<br>
>> +<br>
>> +void WriteMinidump() { eh->WriteMinidump(); }<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64?rev=<wbr>285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> Binary files lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64 (added) and lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64 Mon Oct 31 10:35:18 2016 differ<br>
>><br>
>> Propchange: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64<br>
>> ------------------------------<wbr>------------------------------<wbr>------------------<br>
>> svn:executable = *<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64.cpp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.cpp?<wbr>rev=285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.cpp (added)<br>
>> +++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,12 @@<br>
>> +void crash() {<br>
>> + volatile int *a = (int *)(nullptr);<br>
>> + *a = 1;<br>
>> +}<br>
>> +<br>
>> +extern "C" void _start();<br>
>> +void InstallBreakpad();<br>
>> +<br>
>> +void _start() {<br>
>> + InstallBreakpad();<br>
>> + crash();<br>
>> +}<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.dmp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64.dmp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.dmp?<wbr>rev=285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> Binary files lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.dmp (added) and lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64.dmp Mon Oct 31 10:35:18 2016 differ<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64_not_crashed?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed?rev=285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> Binary files lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed (added) and lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed Mon Oct 31 10:35:18 2016 differ<br>
>><br>
>> Propchange: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed<br>
>> ------------------------------<wbr>------------------------------<wbr>------------------<br>
>> svn:executable = *<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64_not_crashed.cpp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.cpp?rev=285587&view=<wbr>auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.cpp (added)<br>
>> +++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,22 @@<br>
>> +void InstallBreakpad();<br>
>> +void WriteMinidump();<br>
>> +<br>
>> +int global = 42;<br>
>> +<br>
>> +int bar(int x) {<br>
>> + WriteMinidump();<br>
>> + int y = 4 * x + global;<br>
>> + return y;<br>
>> +}<br>
>> +<br>
>> +int foo(int x) {<br>
>> + int y = 2 * bar(3 * x);<br>
>> + return y;<br>
>> +}<br>
>> +<br>
>> +extern "C" void _start();<br>
>> +<br>
>> +void _start() {<br>
>> + InstallBreakpad();<br>
>> + foo(1);<br>
>> +}<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.dmp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64_not_crashed.dmp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.dmp?rev=285587&view=<wbr>auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> Binary files lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.dmp (added) and lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/linux-x86_64_not_<wbr>crashed.dmp Mon Oct 31 10:35:18 2016 differ<br>
>><br>
>> Added: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/makefile.txt<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/makefile.txt?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/makefile.txt?rev=<wbr>285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/makefile.txt (added)<br>
>> +++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/postmortem/<wbr>minidump-new/makefile.txt Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,29 @@<br>
>> +# This makefile aims to make the binaries as small as possible, for us not to<br>
>> +# upload huge binary blobs in the repo.<br>
>> +# The binary should have debug symbols because stack unwinding doesn't work<br>
>> +# correctly using the information in the Minidump only. Also we want to evaluate<br>
>> +# local variables, etc.<br>
>> +# Breakpad compiles as a static library, so statically linking againts it<br>
>> +# makes the binary huge.<br>
>> +# Dynamically linking to it does improve things, but we are still #include-ing<br>
>> +# breakpad headers (which is a lot of source code for which we generate debug<br>
>> +# symbols)<br>
>> +# So, install_breakpad.cpp does the #include-ing and defines a global function<br>
>> +# "InstallBreakpad" that does all the exception handler registration.<br>
>> +# We compile install_breakpad to object file and then link it, alongside the<br>
>> +# static libbreakpad, into a shared library.<br>
>> +# Then the binaries dynamically link to that lib.<br>
>> +# The other optimisation is not using the standard library (hence the _start<br>
>> +# instead of main). We only link dynamically to some standard libraries.<br>
>> +# This way we have a tiny binary (~8K) that has debug symbols and uses breakpad<br>
>> +# to generate a Minidump when the binary crashes/requests such.<br>
>> +#<br>
>> +CC=g++<br>
>> +FLAGS=-g --std=c++11<br>
>> +INCLUDE=-I$HOME/breakpad/src/<wbr>src/<br>
>> +LINK=-L. -lbreakpad -lpthread -nostdlib -lc -lstdc++ -lgcc_s -fno-exceptions<br>
>> +all:<br>
>> + $(CC) $(FLAGS) -fPIC -c install_breakpad.cpp $(INCLUDE) -o install_breakpad.o<br>
>> + ld -shared install_breakpad.o libbreakpad_client.a -o libbreakpad.so<br>
>> + $(CC) $(FLAGS) -o linux-x86_64 linux-x86_64.cpp $(LINK)<br>
>> + $(CC) $(FLAGS) -o linux-x86_64_not_crashed linux-x86_64_not_crashed.cpp $(LINK)<br>
>><br>
>> Modified: lldb/trunk/source/API/<wbr>SystemInitializerFull.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SystemInitializerFull.cpp?rev=285587&r1=285586&r2=285587&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/API/<wbr>SystemInitializerFull.cpp?rev=<wbr>285587&r1=285586&r2=285587&<wbr>view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/API/<wbr>SystemInitializerFull.cpp (original)<br>
>> +++ lldb/trunk/source/API/<wbr>SystemInitializerFull.cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -78,6 +78,7 @@<br>
>> #include "Plugins/Platform/gdb-server/<wbr>PlatformRemoteGDBServer.h"<br>
>> #include "Plugins/Process/elf-core/<wbr>ProcessElfCore.h"<br>
>> #include "Plugins/Process/gdb-remote/<wbr>ProcessGDBRemote.h"<br>
>> +#include "Plugins/Process/minidump/<wbr>ProcessMinidump.h"<br>
>> #include "Plugins/ScriptInterpreter/<wbr>None/ScriptInterpreterNone.h"<br>
>> #include "Plugins/SymbolFile/DWARF/<wbr>SymbolFileDWARF.h"<br>
>> #include "Plugins/SymbolFile/DWARF/<wbr>SymbolFileDWARFDebugMap.h"<br>
>> @@ -304,6 +305,7 @@ void SystemInitializerFull::<wbr>Initialize()<br>
>><br>
>> JITLoaderGDB::Initialize();<br>
>> ProcessElfCore::Initialize();<br>
>> + minidump::ProcessMinidump::<wbr>Initialize();<br>
>> #if defined(_MSC_VER)<br>
>> ProcessWinMiniDump::<wbr>Initialize();<br>
>> #endif<br>
>> @@ -429,6 +431,7 @@ void SystemInitializerFull::<wbr>Terminate()<br>
>><br>
>> JITLoaderGDB::Terminate();<br>
>> ProcessElfCore::Terminate();<br>
>> + minidump::ProcessMinidump::<wbr>Terminate();<br>
>> #if defined(_MSC_VER)<br>
>> ProcessWinMiniDump::Terminate(<wbr>);<br>
>> #endif<br>
>><br>
>> Modified: lldb/trunk/source/Plugins/<wbr>Process/minidump/CMakeLists.<wbr>txt<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/CMakeLists.txt?rev=285587&r1=285586&r2=285587&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>CMakeLists.txt?rev=285587&r1=<wbr>285586&r2=285587&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/CMakeLists.<wbr>txt (original)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/CMakeLists.<wbr>txt Mon Oct 31 10:35:18 2016<br>
>> @@ -5,4 +5,6 @@ add_lldb_library(<wbr>lldbPluginProcessMinidu<br>
>> MinidumpParser.cpp<br>
>> RegisterContextMinidump_x86_<wbr>32.cpp<br>
>> RegisterContextMinidump_x86_<wbr>64.cpp<br>
>> + ProcessMinidump.cpp<br>
>> + ThreadMinidump.cpp<br>
>> )<br>
>><br>
>> Modified: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp?rev=285587&r1=285586&r2=285587&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>MinidumpParser.cpp?rev=285587&<wbr>r1=285586&r2=285587&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.cpp (original)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -9,6 +9,8 @@<br>
>><br>
>> // Project includes<br>
>> #include "MinidumpParser.h"<br>
>> +#include "NtStructures.h"<br>
>> +#include "RegisterContextMinidump_x86_<wbr>32.h"<br>
>><br>
>> // Other libraries and framework includes<br>
>> #include "lldb/Target/MemoryRegionInfo.<wbr>h"<br>
>> @@ -106,11 +108,42 @@ llvm::ArrayRef<MinidumpThread> MinidumpP<br>
>> llvm::ArrayRef<uint8_t><br>
>> MinidumpParser::<wbr>GetThreadContext(const MinidumpThread &td) {<br>
>> if (td.thread_context.rva + td.thread_context.data_size > GetData().size())<br>
>> - return llvm::None;<br>
>> + return {};<br>
>><br>
>> return GetData().slice(td.thread_<wbr>context.rva, td.thread_context.data_size);<br>
>> }<br>
>><br>
>> +llvm::ArrayRef<uint8_t><br>
>> +MinidumpParser::<wbr>GetThreadContextWow64(const MinidumpThread &td) {<br>
>> + // On Windows, a 32-bit process can run on a 64-bit machine under<br>
>> + // WOW64. If the minidump was captured with a 64-bit debugger, then<br>
>> + // the CONTEXT we just grabbed from the mini_dump_thread is the one<br>
>> + // for the 64-bit "native" process rather than the 32-bit "guest"<br>
>> + // process we care about. In this case, we can get the 32-bit CONTEXT<br>
>> + // from the TEB (Thread Environment Block) of the 64-bit process.<br>
>> + auto teb_mem = GetMemory(td.teb, sizeof(TEB64));<br>
>> + if (teb_mem.empty())<br>
>> + return {};<br>
>> +<br>
>> + const TEB64 *wow64teb;<br>
>> + Error error = consumeObject(teb_mem, wow64teb);<br>
>> + if (error.Fail())<br>
>> + return {};<br>
>> +<br>
>> + // Slot 1 of the thread-local storage in the 64-bit TEB points to a<br>
>> + // structure that includes the 32-bit CONTEXT (after a ULONG).<br>
>> + // See: <a href="https://msdn.microsoft.com/en-us/library/ms681670.aspx" rel="noreferrer" target="_blank">https://msdn.microsoft.com/en-<wbr>us/library/ms681670.aspx</a><br>
>> + auto context =<br>
>> + GetMemory(wow64teb->tls_slots[<wbr>1] + 4, sizeof(MinidumpContext_x86_32)<wbr>);<br>
>> + if (context.size() < sizeof(MinidumpContext_x86_32)<wbr>)<br>
>> + return {};<br>
>> +<br>
>> + return context;<br>
>> + // NOTE: We don't currently use the TEB for anything else. If we<br>
>> + // need it in the future, the 32-bit TEB is located according to the address<br>
>> + // stored in the first slot of the 64-bit TEB (wow64teb.Reserved1[0]).<br>
>> +}<br>
>> +<br>
>> const MinidumpSystemInfo *MinidumpParser::<wbr>GetSystemInfo() {<br>
>> llvm::ArrayRef<uint8_t> data = GetStream(MinidumpStreamType::<wbr>SystemInfo);<br>
>><br>
>> @@ -229,8 +262,7 @@ llvm::ArrayRef<MinidumpModule> MinidumpP<br>
>><br>
>> std::vector<const MinidumpModule *> MinidumpParser::<wbr>GetFilteredModuleList() {<br>
>> llvm::ArrayRef<MinidumpModule> modules = GetModuleList();<br>
>> - // mapping module_name to pair(load_address, pointer to module struct in<br>
>> - // memory)<br>
>> + // map module_name -> pair(load_address, pointer to module struct in memory)<br>
>> llvm::StringMap<std::pair<<wbr>uint64_t, const MinidumpModule *>> lowest_addr;<br>
>><br>
>> std::vector<const MinidumpModule *> filtered_modules;<br>
>><br>
>> Modified: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.h?rev=285587&r1=285586&r2=285587&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>MinidumpParser.h?rev=285587&<wbr>r1=285586&r2=285587&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.h (original)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpParser.h Mon Oct 31 10:35:18 2016<br>
>> @@ -59,6 +59,8 @@ public:<br>
>><br>
>> llvm::ArrayRef<uint8_t> GetThreadContext(const MinidumpThread &td);<br>
>><br>
>> + llvm::ArrayRef<uint8_t> GetThreadContextWow64(const MinidumpThread &td);<br>
>> +<br>
>> const MinidumpSystemInfo *GetSystemInfo();<br>
>><br>
>> ArchSpec GetArchitecture();<br>
>><br>
>> Modified: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpTypes.h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/MinidumpTypes.h?rev=285587&r1=285586&r2=285587&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>MinidumpTypes.h?rev=285587&r1=<wbr>285586&r2=285587&view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpTypes.h (original)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>MinidumpTypes.h Mon Oct 31 10:35:18 2016<br>
>> @@ -439,7 +439,8 @@ static_assert(sizeof(<wbr>MinidumpModule) ==<br>
>> // Exception stuff<br>
>> struct MinidumpException {<br>
>> enum {<br>
>> - MaxParams = 15,<br>
>> + ExceptonInfoMaxParams = 15,<br>
>> + DumpRequested = 0xFFFFFFFF,<br>
>> };<br>
>><br>
>> llvm::support::ulittle32_t exception_code;<br>
>> @@ -448,7 +449,7 @@ struct MinidumpException {<br>
>> llvm::support::ulittle64_t exception_address;<br>
>> llvm::support::ulittle32_t number_parameters;<br>
>> llvm::support::ulittle32_t unused_alignment;<br>
>> - llvm::support::ulittle64_t exception_information[<wbr>MaxParams];<br>
>> + llvm::support::ulittle64_t exception_information[<wbr>ExceptonInfoMaxParams];<br>
>> };<br>
>> static_assert(sizeof(<wbr>MinidumpException) == 152,<br>
>> "sizeof MinidumpException is not correct!");<br>
>><br>
>> Added: lldb/trunk/source/Plugins/<wbr>Process/minidump/NtStructures.<wbr>h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/NtStructures.h?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>NtStructures.h?rev=285587&<wbr>view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/NtStructures.<wbr>h (added)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/NtStructures.<wbr>h Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,37 @@<br>
>> +//===-- NtStructures.h ------------------------------<wbr>------------*- C++ -*-===//<br>
>> +//<br>
>> +// The LLVM Compiler Infrastructure<br>
>> +//<br>
>> +// This file is distributed under the University of Illinois Open Source<br>
>> +// License. See LICENSE.TXT for details.<br>
>> +//<br>
>> +//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
>> +<br>
>> +#ifndef liblldb_Plugins_Process_<wbr>Minidump_NtStructures_h_<br>
>> +#define liblldb_Plugins_Process_<wbr>Minidump_NtStructures_h_<br>
>> +<br>
>> +#include "llvm/Support/Endian.h"<br>
>> +<br>
>> +namespace lldb_private {<br>
>> +<br>
>> +namespace minidump {<br>
>> +<br>
>> +// This describes the layout of a TEB (Thread Environment Block) for a 64-bit<br>
>> +// process. It's adapted from the 32-bit TEB in winternl.h. Currently, we care<br>
>> +// only about the position of the tls_slots.<br>
>> +struct TEB64 {<br>
>> + llvm::support::ulittle64_t reserved1[12];<br>
>> + llvm::support::ulittle64_t process_environment_block;<br>
>> + llvm::support::ulittle64_t reserved2[399];<br>
>> + uint8_t reserved3[1952];<br>
>> + llvm::support::ulittle64_t tls_slots[64];<br>
>> + uint8_t reserved4[8];<br>
>> + llvm::support::ulittle64_t reserved5[26];<br>
>> + llvm::support::ulittle64_t reserved_for_ole; // Windows 2000 only<br>
>> + llvm::support::ulittle64_t reserved6[4];<br>
>> + llvm::support::ulittle64_t tls_expansion_slots;<br>
>> +};<br>
>> +<br>
>> +#endif // liblldb_Plugins_Process_<wbr>Minidump_NtStructures_h_<br>
>> +} // namespace minidump<br>
>> +} // namespace lldb_private<br>
>><br>
>> Added: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>ProcessMinidump.cpp?rev=<wbr>285587&view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.cpp (added)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,293 @@<br>
>> +//===-- ProcessMinidump.cpp ------------------------------<wbr>-------*- C++ -*-===//<br>
>> +//<br>
>> +// The LLVM Compiler Infrastructure<br>
>> +//<br>
>> +// This file is distributed under the University of Illinois Open Source<br>
>> +// License. See LICENSE.TXT for details.<br>
>> +//<br>
>> +//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
>> +<br>
>> +// Project includes<br>
>> +#include "ProcessMinidump.h"<br>
>> +#include "ThreadMinidump.h"<br>
>> +<br>
>> +// Other libraries and framework includes<br>
>> +#include "lldb/Core/DataBufferHeap.h"<br>
>> +#include "lldb/Core/Log.h"<br>
>> +#include "lldb/Core/Module.h"<br>
>> +#include "lldb/Core/ModuleSpec.h"<br>
>> +#include "lldb/Core/PluginManager.h"<br>
>> +#include "lldb/Core/Section.h"<br>
>> +#include "lldb/Core/State.h"<br>
>> +#include "lldb/Target/DynamicLoader.h"<br>
>> +#include "lldb/Target/MemoryRegionInfo.<wbr>h"<br>
>> +#include "lldb/Target/Target.h"<br>
>> +#include "lldb/Target/UnixSignals.h"<br>
>> +#include "lldb/Utility/LLDBAssert.h"<br>
>> +<br>
>> +// C includes<br>
>> +// C++ includes<br>
>> +<br>
>> +using namespace lldb_private;<br>
>> +using namespace minidump;<br>
>> +<br>
>> +ConstString ProcessMinidump::<wbr>GetPluginNameStatic() {<br>
>> + static ConstString g_name("minidump");<br>
>> + return g_name;<br>
>> +}<br>
>> +<br>
>> +const char *ProcessMinidump::<wbr>GetPluginDescriptionStatic() {<br>
>> + return "Minidump plug-in.";<br>
>> +}<br>
>> +<br>
>> +lldb::ProcessSP ProcessMinidump::<wbr>CreateInstance(lldb::TargetSP target_sp,<br>
>> + lldb::ListenerSP listener_sp,<br>
>> + const FileSpec *crash_file) {<br>
>> + if (!crash_file)<br>
>> + return nullptr;<br>
>> +<br>
>> + lldb::ProcessSP process_sp;<br>
>> + // Read enough data for the Minidump header<br>
>> + const size_t header_size = sizeof(MinidumpHeader);<br>
>> + lldb::DataBufferSP data_sp(crash_file-><wbr>MemoryMapFileContents(0, header_size));<br>
>> + if (!data_sp)<br>
>> + return nullptr;<br>
>> +<br>
>> + // first, only try to parse the header, beacuse we need to be fast<br>
>> + llvm::ArrayRef<uint8_t> header_data(data_sp->GetBytes(<wbr>), header_size);<br>
>> + const MinidumpHeader *header = MinidumpHeader::Parse(header_<wbr>data);<br>
>> +<br>
>> + if (data_sp->GetByteSize() != header_size || header == nullptr)<br>
>> + return nullptr;<br>
>> +<br>
>> + lldb::DataBufferSP all_data_sp(crash_file-><wbr>MemoryMapFileContents());<br>
>> + auto minidump_parser = MinidumpParser::Create(all_<wbr>data_sp);<br>
>> + // check if the parser object is valid<br>
>> + // skip if the Minidump file is Windows generated, because we are still<br>
>> + // work-in-progress<br>
>> + if (!minidump_parser ||<br>
>> + minidump_parser-><wbr>GetArchitecture().GetTriple().<wbr>getOS() ==<br>
>> + llvm::Triple::OSType::Win32)<br>
>> + return nullptr;<br>
>> +<br>
>> + return std::make_shared<<wbr>ProcessMinidump>(target_sp, listener_sp, *crash_file,<br>
>> + minidump_parser.getValue());<br>
>> +}<br>
>> +<br>
>> +bool ProcessMinidump::CanDebug(<wbr>lldb::TargetSP target_sp,<br>
>> + bool plugin_specified_by_name) {<br>
>> + return true;<br>
>> +}<br>
>> +<br>
>> +ProcessMinidump::<wbr>ProcessMinidump(lldb::TargetSP target_sp,<br>
>> + lldb::ListenerSP listener_sp,<br>
>> + const FileSpec &core_file,<br>
>> + MinidumpParser minidump_parser)<br>
>> + : Process(target_sp, listener_sp), m_minidump_parser(minidump_<wbr>parser),<br>
>> + m_core_file(core_file), m_is_wow64(false) {}<br>
>> +<br>
>> +ProcessMinidump::~<wbr>ProcessMinidump() {<br>
>> + Clear();<br>
>> + // We need to call finalize on the process before destroying ourselves<br>
>> + // to make sure all of the broadcaster cleanup goes as planned. If we<br>
>> + // destruct this class, then Process::~Process() might have problems<br>
>> + // trying to fully destroy the broadcaster.<br>
>> + Finalize();<br>
>> +}<br>
>> +<br>
>> +void ProcessMinidump::Initialize() {<br>
>> + static std::once_flag g_once_flag;<br>
>> +<br>
>> + std::call_once(g_once_flag, []() {<br>
>> + PluginManager::RegisterPlugin(<wbr>GetPluginNameStatic(),<br>
>> + GetPluginDescriptionStatic(),<br>
>> + ProcessMinidump::<wbr>CreateInstance);<br>
>> + });<br>
>> +}<br>
>> +<br>
>> +void ProcessMinidump::Terminate() {<br>
>> + PluginManager::<wbr>UnregisterPlugin(<wbr>ProcessMinidump::<wbr>CreateInstance);<br>
>> +}<br>
>> +<br>
>> +Error ProcessMinidump::DoLoadCore() {<br>
>> + Error error;<br>
>> +<br>
>> + m_thread_list = m_minidump_parser.GetThreads()<wbr>;<br>
>> + m_active_exception = m_minidump_parser.<wbr>GetExceptionStream();<br>
>> + ReadModuleList();<br>
>> + GetTarget().SetArchitecture(<wbr>GetArchitecture());<br>
>> +<br>
>> + llvm::Optional<lldb::pid_t> pid = m_minidump_parser.GetPid();<br>
>> + if (!pid) {<br>
>> + error.SetErrorString("failed to parse PID");<br>
>> + return error;<br>
>> + }<br>
>> + SetID(pid.getValue());<br>
>> +<br>
>> + return error;<br>
>> +}<br>
>> +<br>
>> +DynamicLoader *ProcessMinidump::<wbr>GetDynamicLoader() {<br>
>> + if (m_dyld_ap.get() == nullptr)<br>
>> + m_dyld_ap.reset(DynamicLoader:<wbr>:FindPlugin(this, nullptr));<br>
>> + return m_dyld_ap.get();<br>
>> +}<br>
>> +<br>
>> +ConstString ProcessMinidump::<wbr>GetPluginName() { return GetPluginNameStatic(); }<br>
>> +<br>
>> +uint32_t ProcessMinidump::<wbr>GetPluginVersion() { return 1; }<br>
>> +<br>
>> +Error ProcessMinidump::DoDestroy() { return Error(); }<br>
>> +<br>
>> +void ProcessMinidump::<wbr>RefreshStateAfterStop() {<br>
>> + if (!m_active_exception)<br>
>> + return;<br>
>> +<br>
>> + if (m_active_exception-><wbr>exception_record.exception_<wbr>code ==<br>
>> + MinidumpException::<wbr>DumpRequested) {<br>
>> + return;<br>
>> + }<br>
>> +<br>
>> + lldb::StopInfoSP stop_info;<br>
>> + lldb::ThreadSP stop_thread;<br>
>> +<br>
>> + Process::m_thread_list.<wbr>SetSelectedThreadByID(m_<wbr>active_exception->thread_id);<br>
>> + stop_thread = Process::m_thread_list.<wbr>GetSelectedThread();<br>
>> + ArchSpec arch = GetArchitecture();<br>
>> +<br>
>> + if (arch.GetTriple().getOS() == llvm::Triple::Linux) {<br>
>> + stop_info = StopInfo::<wbr>CreateStopReasonWithSignal(<br>
>> + *stop_thread, m_active_exception->exception_<wbr>record.exception_code);<br>
>> + } else {<br>
>> + std::string desc;<br>
>> + llvm::raw_string_ostream desc_stream(desc);<br>
>> + desc_stream << "Exception "<br>
>> + << llvm::format_hex(<br>
>> + m_active_exception->exception_<wbr>record.exception_code, 8)<br>
>> + << " encountered at address "<br>
>> + << llvm::format_hex(<br>
>> + m_active_exception->exception_<wbr>record.exception_address,<br>
>> + 8);<br>
>> + stop_info = StopInfo::<wbr>CreateStopReasonWithException(<br>
>> + *stop_thread, desc_stream.str().c_str());<br>
>> + }<br>
>> +<br>
>> + stop_thread->SetStopInfo(stop_<wbr>info);<br>
>> +}<br>
>> +<br>
>> +bool ProcessMinidump::IsAlive() { return true; }<br>
>> +<br>
>> +bool ProcessMinidump::<wbr>WarnBeforeDetach() const { return false; }<br>
>> +<br>
>> +size_t ProcessMinidump::ReadMemory(<wbr>lldb::addr_t addr, void *buf, size_t size,<br>
>> + lldb_private::Error &error) {<br>
>> + // Don't allow the caching that lldb_private::Process::<wbr>ReadMemory does<br>
>> + // since we have it all cached in our dump file anyway.<br>
>> + return DoReadMemory(addr, buf, size, error);<br>
>> +}<br>
>> +<br>
>> +size_t ProcessMinidump::DoReadMemory(<wbr>lldb::addr_t addr, void *buf, size_t size,<br>
>> + lldb_private::Error &error) {<br>
>> +<br>
>> + llvm::ArrayRef<uint8_t> mem = m_minidump_parser.GetMemory(<wbr>addr, size);<br>
>> + if (mem.empty()) {<br>
>> + error.SetErrorString("could not parse memory info");<br>
>> + return 0;<br>
>> + }<br>
>> +<br>
>> + std::memcpy(buf, mem.data(), mem.size());<br>
>> + return mem.size();<br>
>> +}<br>
>> +<br>
>> +ArchSpec ProcessMinidump::<wbr>GetArchitecture() {<br>
>> + if (!m_is_wow64) {<br>
>> + return m_minidump_parser.<wbr>GetArchitecture();<br>
>> + }<br>
>> +<br>
>> + llvm::Triple triple;<br>
>> + triple.setVendor(llvm::Triple:<wbr>:VendorType::UnknownVendor);<br>
>> + triple.setArch(llvm::Triple::<wbr>ArchType::x86);<br>
>> + triple.setOS(llvm::Triple::<wbr>OSType::Win32);<br>
>> + return ArchSpec(triple);<br>
>> +}<br>
>> +<br>
>> +Error ProcessMinidump::<wbr>GetMemoryRegionInfo(<br>
>> + lldb::addr_t load_addr, lldb_private::MemoryRegionInfo &range_info) {<br>
>> + Error error;<br>
>> + auto info = m_minidump_parser.<wbr>GetMemoryRegionInfo(load_addr)<wbr>;<br>
>> + if (!info) {<br>
>> + error.SetErrorString("No valid MemoryRegionInfo found!");<br>
>> + return error;<br>
>> + }<br>
>> + range_info = info.getValue();<br>
>> + return error;<br>
>> +}<br>
>> +<br>
>> +void ProcessMinidump::Clear() { Process::m_thread_list.Clear()<wbr>; }<br>
>> +<br>
>> +bool ProcessMinidump::<wbr>UpdateThreadList(<br>
>> + lldb_private::ThreadList &old_thread_list,<br>
>> + lldb_private::ThreadList &new_thread_list) {<br>
>> + uint32_t num_threads = 0;<br>
>> + if (m_thread_list.size() > 0)<br>
>> + num_threads = m_thread_list.size();<br>
>> +<br>
>> + for (lldb::tid_t tid = 0; tid < num_threads; ++tid) {<br>
>> + llvm::ArrayRef<uint8_t> context;<br>
>> + if (!m_is_wow64)<br>
>> + context = m_minidump_parser.<wbr>GetThreadContext(m_thread_<wbr>list[tid]);<br>
>> + else<br>
>> + context = m_minidump_parser.<wbr>GetThreadContextWow64(m_<wbr>thread_list[tid]);<br>
>> +<br>
>> + lldb::ThreadSP thread_sp(<br>
>> + new ThreadMinidump(*this, m_thread_list[tid], context));<br>
>> + new_thread_list.AddThread(<wbr>thread_sp);<br>
>> + }<br>
>> + return new_thread_list.GetSize(false) > 0;<br>
>> +}<br>
>> +<br>
>> +void ProcessMinidump::<wbr>ReadModuleList() {<br>
>> + std::vector<const MinidumpModule *> filtered_modules =<br>
>> + m_minidump_parser.<wbr>GetFilteredModuleList();<br>
>> +<br>
>> + for (auto module : filtered_modules) {<br>
>> + llvm::Optional<std::string> name =<br>
>> + m_minidump_parser.<wbr>GetMinidumpString(module-><wbr>module_name_rva);<br>
>> +<br>
>> + if (!name)<br>
>> + continue;<br>
>> +<br>
>> + Log *log(GetLogIfAllCategoriesSet(<wbr>LIBLLDB_LOG_MODULES));<br>
>> + if (log) {<br>
>> + log->Printf(<br>
>> + "ProcessMinidump::%s found module: name: %s %#010lx-%#010lx size: %u",<br>
>> + __FUNCTION__, name.getValue().c_str(),<br>
>> + uint64_t(module->base_of_<wbr>image),<br>
>> + module->base_of_image + module->size_of_image,<br>
>> + uint32_t(module->size_of_<wbr>image));<br>
>> + }<br>
>> +<br>
>> + // check if the process is wow64 - a 32 bit windows process running on a<br>
>> + // 64 bit windows<br>
>> + if (llvm::StringRef(name.<wbr>getValue()).endswith_lower("<wbr>wow64.dll")) {<br>
>> + m_is_wow64 = true;<br>
>> + }<br>
>> +<br>
>> + const auto file_spec = FileSpec(name.getValue(), true);<br>
>> + ModuleSpec module_spec = file_spec;<br>
>> + Error error;<br>
>> + lldb::ModuleSP module_sp = GetTarget().GetSharedModule(<wbr>module_spec, &error);<br>
>> + if (!module_sp || error.Fail()) {<br>
>> + continue;<br>
>> + }<br>
>> +<br>
>> + if (log) {<br>
>> + log->Printf("ProcessMinidump::<wbr>%s load module: name: %s", __FUNCTION__,<br>
>> + name.getValue().c_str());<br>
>> + }<br>
>> +<br>
>> + bool load_addr_changed = false;<br>
>> + module_sp->SetLoadAddress(<wbr>GetTarget(), module->base_of_image, false,<br>
>> + load_addr_changed);<br>
>> + }<br>
>> +}<br>
>><br>
>> Added: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.h?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>ProcessMinidump.h?rev=285587&<wbr>view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.h (added)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ProcessMinidump.h Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,104 @@<br>
>> +//===-- ProcessMinidump.h ------------------------------<wbr>---------*- C++ -*-===//<br>
>> +//<br>
>> +// The LLVM Compiler Infrastructure<br>
>> +//<br>
>> +// This file is distributed under the University of Illinois Open Source<br>
>> +// License. See LICENSE.TXT for details.<br>
>> +//<br>
>> +//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
>> +<br>
>> +#ifndef liblldb_ProcessMinidump_h_<br>
>> +#define liblldb_ProcessMinidump_h_<br>
>> +<br>
>> +// Project includes<br>
>> +#include "MinidumpParser.h"<br>
>> +#include "MinidumpTypes.h"<br>
>> +<br>
>> +// Other libraries and framework includes<br>
>> +#include "lldb/Core/ConstString.h"<br>
>> +#include "lldb/Core/Error.h"<br>
>> +#include "lldb/Target/Process.h"<br>
>> +#include "lldb/Target/StopInfo.h"<br>
>> +#include "lldb/Target/Target.h"<br>
>> +<br>
>> +#include "llvm/Support/Format.h"<br>
>> +#include "llvm/Support/raw_ostream.h"<br>
>> +<br>
>> +// C Includes<br>
>> +// C++ Includes<br>
>> +<br>
>> +namespace lldb_private {<br>
>> +<br>
>> +namespace minidump {<br>
>> +<br>
>> +class ProcessMinidump : public Process {<br>
>> +public:<br>
>> + static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp,<br>
>> + lldb::ListenerSP listener_sp,<br>
>> + const FileSpec *crash_file_path);<br>
>> +<br>
>> + static void Initialize();<br>
>> +<br>
>> + static void Terminate();<br>
>> +<br>
>> + static ConstString GetPluginNameStatic();<br>
>> +<br>
>> + static const char *GetPluginDescriptionStatic();<br>
>> +<br>
>> + ProcessMinidump(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp,<br>
>> + const lldb_private::FileSpec &core_file,<br>
>> + MinidumpParser minidump_parser);<br>
>> +<br>
>> + ~ProcessMinidump() override;<br>
>> +<br>
>> + bool CanDebug(lldb::TargetSP target_sp,<br>
>> + bool plugin_specified_by_name) override;<br>
>> +<br>
>> + Error DoLoadCore() override;<br>
>> +<br>
>> + DynamicLoader *GetDynamicLoader() override;<br>
>> +<br>
>> + ConstString GetPluginName() override;<br>
>> +<br>
>> + uint32_t GetPluginVersion() override;<br>
>> +<br>
>> + Error DoDestroy() override;<br>
>> +<br>
>> + void RefreshStateAfterStop() override;<br>
>> +<br>
>> + bool IsAlive() override;<br>
>> +<br>
>> + bool WarnBeforeDetach() const override;<br>
>> +<br>
>> + size_t ReadMemory(lldb::addr_t addr, void *buf, size_t size,<br>
>> + Error &error) override;<br>
>> +<br>
>> + size_t DoReadMemory(lldb::addr_t addr, void *buf, size_t size,<br>
>> + Error &error) override;<br>
>> +<br>
>> + ArchSpec GetArchitecture();<br>
>> +<br>
>> + Error GetMemoryRegionInfo(lldb::<wbr>addr_t load_addr,<br>
>> + MemoryRegionInfo &range_info) override;<br>
>> +<br>
>> + MinidumpParser m_minidump_parser;<br>
>> +<br>
>> +protected:<br>
>> + void Clear();<br>
>> +<br>
>> + bool UpdateThreadList(ThreadList &old_thread_list,<br>
>> + ThreadList &new_thread_list) override;<br>
>> +<br>
>> + void ReadModuleList();<br>
>> +<br>
>> +private:<br>
>> + FileSpec m_core_file;<br>
>> + llvm::ArrayRef<MinidumpThread> m_thread_list;<br>
>> + const MinidumpExceptionStream *m_active_exception;<br>
>> + bool m_is_wow64;<br>
>> +};<br>
>> +<br>
>> +} // namespace minidump<br>
>> +} // namespace lldb_private<br>
>> +<br>
>> +#endif // liblldb_ProcessMinidump_h_<br>
>><br>
>> Added: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.cpp?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>ThreadMinidump.cpp?rev=285587&<wbr>view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.cpp (added)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,114 @@<br>
>> +//===-- ThreadMinidump.cpp ------------------------------<wbr>--------*- C++ -*-===//<br>
>> +//<br>
>> +// The LLVM Compiler Infrastructure<br>
>> +//<br>
>> +// This file is distributed under the University of Illinois Open Source<br>
>> +// License. See LICENSE.TXT for details.<br>
>> +//<br>
>> +//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
>> +<br>
>> +// Project includes<br>
>> +#include "ThreadMinidump.h"<br>
>> +#include "ProcessMinidump.h"<br>
>> +<br>
>> +#include "RegisterContextMinidump_x86_<wbr>32.h"<br>
>> +#include "RegisterContextMinidump_x86_<wbr>64.h"<br>
>> +<br>
>> +// Other libraries and framework includes<br>
>> +#include "Plugins/Process/Utility/<wbr>RegisterContextLinux_i386.h"<br>
>> +#include "Plugins/Process/Utility/<wbr>RegisterContextLinux_x86_64.h"<br>
>> +<br>
>> +#include "Plugins/Process/elf-core/<wbr>RegisterContextPOSIXCore_x86_<wbr>64.h"<br>
>> +<br>
>> +#include "lldb/Core/DataExtractor.h"<br>
>> +#include "lldb/Core/Log.h"<br>
>> +#include "lldb/Target/RegisterContext.<wbr>h"<br>
>> +#include "lldb/Target/StopInfo.h"<br>
>> +#include "lldb/Target/Target.h"<br>
>> +#include "lldb/Target/Unwind.h"<br>
>> +<br>
>> +// C Includes<br>
>> +// C++ Includes<br>
>> +<br>
>> +using namespace lldb;<br>
>> +using namespace lldb_private;<br>
>> +using namespace minidump;<br>
>> +<br>
>> +ThreadMinidump::<wbr>ThreadMinidump(Process &process, const MinidumpThread &td,<br>
>> + llvm::ArrayRef<uint8_t> gpregset_data)<br>
>> + : Thread(process, td.thread_id), m_thread_reg_ctx_sp(),<br>
>> + m_gpregset_data(gpregset_data) {}<br>
>> +<br>
>> +ThreadMinidump::~<wbr>ThreadMinidump() {}<br>
>> +<br>
>> +void ThreadMinidump::<wbr>RefreshStateAfterStop() {}<br>
>> +<br>
>> +void ThreadMinidump::<wbr>ClearStackFrames() {}<br>
>> +<br>
>> +RegisterContextSP ThreadMinidump::<wbr>GetRegisterContext() {<br>
>> + if (!m_reg_context_sp) {<br>
>> + m_reg_context_sp = CreateRegisterContextForFrame(<wbr>nullptr);<br>
>> + }<br>
>> + return m_reg_context_sp;<br>
>> +}<br>
>> +<br>
>> +RegisterContextSP<br>
>> +ThreadMinidump::<wbr>CreateRegisterContextForFrame(<wbr>StackFrame *frame) {<br>
>> + RegisterContextSP reg_ctx_sp;<br>
>> + uint32_t concrete_frame_idx = 0;<br>
>> + Log *log(GetLogIfAllCategoriesSet(<wbr>LIBLLDB_LOG_THREAD));<br>
>> +<br>
>> + if (frame)<br>
>> + concrete_frame_idx = frame->GetConcreteFrameIndex()<wbr>;<br>
>> +<br>
>> + if (concrete_frame_idx == 0) {<br>
>> + if (m_thread_reg_ctx_sp)<br>
>> + return m_thread_reg_ctx_sp;<br>
>> +<br>
>> + ProcessMinidump *process =<br>
>> + static_cast<ProcessMinidump *>(GetProcess().get());<br>
>> + ArchSpec arch = process->GetArchitecture();<br>
>> + RegisterInfoInterface *reg_interface = nullptr;<br>
>> +<br>
>> + // TODO write other register contexts and add them here<br>
>> + switch (arch.GetMachine()) {<br>
>> + case llvm::Triple::x86: {<br>
>> + reg_interface = new RegisterContextLinux_i386(<wbr>arch);<br>
>> + lldb::DataBufferSP buf =<br>
>> + ConvertMinidumpContext_x86_32(<wbr>m_gpregset_data, reg_interface);<br>
>> + DataExtractor gpregs(buf, lldb::eByteOrderLittle, 4);<br>
>> + DataExtractor fpregs;<br>
>> + m_thread_reg_ctx_sp.reset(new RegisterContextCorePOSIX_x86_<wbr>64(<br>
>> + *this, reg_interface, gpregs, fpregs));<br>
>> + break;<br>
>> + }<br>
>> + case llvm::Triple::x86_64: {<br>
>> + reg_interface = new RegisterContextLinux_x86_64(<wbr>arch);<br>
>> + lldb::DataBufferSP buf =<br>
>> + ConvertMinidumpContext_x86_64(<wbr>m_gpregset_data, reg_interface);<br>
>> + DataExtractor gpregs(buf, lldb::eByteOrderLittle, 8);<br>
>> + DataExtractor fpregs;<br>
>> + m_thread_reg_ctx_sp.reset(new RegisterContextCorePOSIX_x86_<wbr>64(<br>
>> + *this, reg_interface, gpregs, fpregs));<br>
>> + break;<br>
>> + }<br>
>> + default:<br>
>> + break;<br>
>> + }<br>
>> +<br>
>> + if (!reg_interface) {<br>
>> + if (log)<br>
>> + log->Printf("elf-core::%s:: Architecture(%d) not supported",<br>
>> + __FUNCTION__, arch.GetMachine());<br>
>> + assert(false && "Architecture not supported");<br>
>> + }<br>
>> +<br>
>> + reg_ctx_sp = m_thread_reg_ctx_sp;<br>
>> + } else if (m_unwinder_ap) {<br>
>> + reg_ctx_sp = m_unwinder_ap-><wbr>CreateRegisterContextForFrame(<wbr>frame);<br>
>> + }<br>
>> +<br>
>> + return reg_ctx_sp;<br>
>> +}<br>
>> +<br>
>> +bool ThreadMinidump::<wbr>CalculateStopInfo() { return false; }<br>
>><br>
>> Added: lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.h<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/minidump/ThreadMinidump.h?rev=285587&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Plugins/Process/minidump/<wbr>ThreadMinidump.h?rev=285587&<wbr>view=auto</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.h (added)<br>
>> +++ lldb/trunk/source/Plugins/<wbr>Process/minidump/<wbr>ThreadMinidump.h Mon Oct 31 10:35:18 2016<br>
>> @@ -0,0 +1,52 @@<br>
>> +//===-- ThreadMinidump.h ------------------------------<wbr>---------*- C++ -*-===//<br>
>> +//<br>
>> +// The LLVM Compiler Infrastructure<br>
>> +//<br>
>> +// This file is distributed under the University of Illinois Open Source<br>
>> +// License. See LICENSE.TXT for details.<br>
>> +//<br>
>> +//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
>> +<br>
>> +#ifndef liblldb_ThreadMinidump_h_<br>
>> +#define liblldb_ThreadMinidump_h_<br>
>> +<br>
>> +// Project includes<br>
>> +#include "MinidumpTypes.h"<br>
>> +<br>
>> +// Other libraries and framework includes<br>
>> +#include "lldb/Target/Thread.h"<br>
>> +<br>
>> +// C Includes<br>
>> +// C++ Includes<br>
>> +<br>
>> +namespace lldb_private {<br>
>> +<br>
>> +namespace minidump {<br>
>> +<br>
>> +class ThreadMinidump : public Thread {<br>
>> +public:<br>
>> + ThreadMinidump(Process &process, const MinidumpThread &td,<br>
>> + llvm::ArrayRef<uint8_t> gpregset_data);<br>
>> +<br>
>> + ~ThreadMinidump() override;<br>
>> +<br>
>> + void RefreshStateAfterStop() override;<br>
>> +<br>
>> + lldb::RegisterContextSP GetRegisterContext() override;<br>
>> +<br>
>> + lldb::RegisterContextSP<br>
>> + CreateRegisterContextForFrame(<wbr>StackFrame *frame) override;<br>
>> +<br>
>> + void ClearStackFrames() override;<br>
>> +<br>
>> +protected:<br>
>> + lldb::RegisterContextSP m_thread_reg_ctx_sp;<br>
>> + llvm::ArrayRef<uint8_t> m_gpregset_data;<br>
>> +<br>
>> + bool CalculateStopInfo() override;<br>
>> +};<br>
>> +<br>
>> +} // namespace minidump<br>
>> +} // namespace lldb_private<br>
>> +<br>
>> +#endif // liblldb_ThreadMinidump_h_<br>
>><br>
>> Modified: lldb/trunk/unittests/Process/<wbr>minidump/MinidumpParserTest.<wbr>cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp?rev=285587&r1=285586&r2=285587&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/unittests/<wbr>Process/minidump/<wbr>MinidumpParserTest.cpp?rev=<wbr>285587&r1=285586&r2=285587&<wbr>view=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- lldb/trunk/unittests/Process/<wbr>minidump/MinidumpParserTest.<wbr>cpp (original)<br>
>> +++ lldb/trunk/unittests/Process/<wbr>minidump/MinidumpParserTest.<wbr>cpp Mon Oct 31 10:35:18 2016<br>
>> @@ -134,7 +134,7 @@ TEST_F(MinidumpParserTest, GetModuleList<br>
>> llvm::Optional<std::string> name =<br>
>> parser->GetMinidumpString(<wbr>modules[i].module_name_rva);<br>
>> ASSERT_TRUE(name.hasValue());<br>
>> - ASSERT_EQ(module_names[i], name.getValue());<br>
>> + EXPECT_EQ(module_names[i], name.getValue());<br>
>> }<br>
>> }<br>
>><br>
>> @@ -275,8 +275,46 @@ TEST_F(MinidumpParserTest, GetPidWindows<br>
>> ASSERT_EQ(4440UL, pid.getValue());<br>
>> }<br>
>><br>
>> -// Register stuff<br>
>> -// TODO probably split register stuff tests into different file?<br>
>> +// wow64<br>
>> +TEST_F(MinidumpParserTest, GetPidWow64) {<br>
>> + SetUpData("fizzbuzz_wow64.dmp"<wbr>);<br>
>> + llvm::Optional<lldb::pid_t> pid = parser->GetPid();<br>
>> + ASSERT_TRUE(pid.hasValue());<br>
>> + ASSERT_EQ(7836UL, pid.getValue());<br>
>> +}<br>
>> +<br>
>> +TEST_F(MinidumpParserTest, GetModuleListWow64) {<br>
>> + SetUpData("fizzbuzz_wow64.dmp"<wbr>);<br>
>> + llvm::ArrayRef<MinidumpModule> modules = parser->GetModuleList();<br>
>> + ASSERT_EQ(16UL, modules.size());<br>
>> + std::string module_names[16] = {<br>
>> + R"(D:\src\llvm\llvm\tools\<wbr>lldb\packages\Python\<wbr>lldbsuite\test\<wbr>functionalities\postmortem\<wbr>wow64_minidump\fizzbuzz.exe)",<br>
>> + R"(C:\Windows\System32\ntdll.<wbr>dll)",<br>
>> + R"(C:\Windows\System32\wow64.<wbr>dll)",<br>
>> + R"(C:\Windows\System32\<wbr>wow64win.dll)",<br>
>> + R"(C:\Windows\System32\<wbr>wow64cpu.dll)",<br>
>> + R"(D:\src\llvm\llvm\tools\<wbr>lldb\packages\Python\<wbr>lldbsuite\test\<wbr>functionalities\postmortem\<wbr>wow64_minidump\fizzbuzz.exe)",<br>
>> + R"(C:\Windows\SysWOW64\ntdll.<wbr>dll)",<br>
>> + R"(C:\Windows\SysWOW64\<wbr>kernel32.dll)",<br>
>> + R"(C:\Windows\SysWOW64\<wbr>KERNELBASE.dll)",<br>
>> + R"(C:\Windows\SysWOW64\<wbr>advapi32.dll)",<br>
>> + R"(C:\Windows\SysWOW64\msvcrt.<wbr>dll)",<br>
>> + R"(C:\Windows\SysWOW64\<wbr>sechost.dll)",<br>
>> + R"(C:\Windows\SysWOW64\rpcrt4.<wbr>dll)",<br>
>> + R"(C:\Windows\SysWOW64\<wbr>sspicli.dll)",<br>
>> + R"(C:\Windows\SysWOW64\<wbr>CRYPTBASE.dll)",<br>
>> + R"(C:\Windows\System32\api-ms-<wbr>win-core-synch-l1-2-0.DLL)",<br>
>> + };<br>
>> +<br>
>> + for (int i = 0; i < 16; ++i) {<br>
>> + llvm::Optional<std::string> name =<br>
>> + parser->GetMinidumpString(<wbr>modules[i].module_name_rva);<br>
>> + ASSERT_TRUE(name.hasValue());<br>
>> + EXPECT_EQ(module_names[i], name.getValue());<br>
>> + }<br>
>> +}<br>
>> +<br>
>> +// Register tests<br>
>> #define REG_VAL32(x) *(reinterpret_cast<uint32_t *>(x))<br>
>> #define REG_VAL64(x) *(reinterpret_cast<uint64_t *>(x))<br>
>><br>
>> @@ -371,3 +409,45 @@ TEST_F(MinidumpParserTest, ConvertMinidu<br>
>> }<br>
>> }<br>
>> }<br>
>> +<br>
>> +TEST_F(MinidumpParserTest, ConvertMinidumpContext_x86_32_<wbr>wow64) {<br>
>> + SetUpData("fizzbuzz_wow64.dmp"<wbr>);<br>
>> + llvm::ArrayRef<MinidumpThread> thread_list = parser->GetThreads();<br>
>> + const MinidumpThread thread = thread_list[0];<br>
>> + llvm::ArrayRef<uint8_t> registers(parser-><wbr>GetThreadContextWow64(thread))<wbr>;<br>
>> +<br>
>> + ArchSpec arch = parser->GetArchitecture();<br>
>> + RegisterInfoInterface *reg_interface = new RegisterContextLinux_i386(<wbr>arch);<br>
>> + lldb::DataBufferSP buf =<br>
>> + ConvertMinidumpContext_x86_32(<wbr>registers, reg_interface);<br>
>> + ASSERT_EQ(reg_interface-><wbr>GetGPRSize(), buf->GetByteSize());<br>
>> +<br>
>> + const RegisterInfo *reg_info = reg_interface-><wbr>GetRegisterInfo();<br>
>> +<br>
>> + std::map<uint64_t, uint32_t> reg_values;<br>
>> +<br>
>> + reg_values[lldb_eax_i386] = 0x00000000;<br>
>> + reg_values[lldb_ebx_i386] = 0x0037f608;<br>
>> + reg_values[lldb_ecx_i386] = 0x00e61578;<br>
>> + reg_values[lldb_edx_i386] = 0x00000008;<br>
>> + reg_values[lldb_edi_i386] = 0x00000000;<br>
>> + reg_values[lldb_esi_i386] = 0x00000002;<br>
>> + reg_values[lldb_ebp_i386] = 0x0037f654;<br>
>> + reg_values[lldb_esp_i386] = 0x0037f5b8;<br>
>> + reg_values[lldb_eip_i386] = 0x77ce01fd;<br>
>> + reg_values[lldb_eflags_i386] = 0x00000246;<br>
>> + reg_values[lldb_cs_i386] = 0x00000023;<br>
>> + reg_values[lldb_fs_i386] = 0x00000053;<br>
>> + reg_values[lldb_gs_i386] = 0x0000002b;<br>
>> + reg_values[lldb_ss_i386] = 0x0000002b;<br>
>> + reg_values[lldb_ds_i386] = 0x0000002b;<br>
>> + reg_values[lldb_es_i386] = 0x0000002b;<br>
>> +<br>
>> + for (uint32_t reg_index = 0; reg_index < reg_interface-><wbr>GetRegisterCount();<br>
>> + ++reg_index) {<br>
>> + if (reg_values.find(reg_index) != reg_values.end()) {<br>
>> + EXPECT_EQ(reg_values[reg_<wbr>index],<br>
>> + REG_VAL32(buf->GetBytes() + reg_info[reg_index].byte_<wbr>offset));<br>
>> + }<br>
>> + }<br>
>> +}<br>
>> \ No newline at end of file<br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> lldb-commits mailing list<br>
>> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
><br>
> ______________________________<wbr>_________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</div></div></blockquote></div><br></div>