I don't think you need to go out of your way to account for this, but Microsoft recently shipped bash on Windows in a full ubuntu environment. I can't check right this second, but I don't think it has sh, only bash. What about a fallback? Try bash, if you can't find it try sh. Thoughts?<br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 18, 2016 at 4:39 PM Jim Ingham via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I am pretty sure /bin/sh is supposed to be a posix shell. We could probably use that as well if we felt that there might be an OS X without /bin/bash.<br class="gmail_msg">
<br class="gmail_msg">
But we aren't using any but the most basic properties of the shell along this code path. It isn't being done for shell expansion or anything like that, So there isn't much point in making it overridable.<br class="gmail_msg">
<br class="gmail_msg">
Jim<br class="gmail_msg">
<br class="gmail_msg">
> On Oct 18, 2016, at 4:26 PM, Todd Fiala via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> Actually that's a good point. We can default to bash but add a setting to override. The issue we have to solve is that the current approach fails with non-POSIX shells.<br class="gmail_msg">
><br class="gmail_msg">
> -Todd<br class="gmail_msg">
><br class="gmail_msg">
>> On Oct 18, 2016, at 4:09 PM, Joerg Sonnenberger <joerg@NetBSD.org> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> joerg added a comment.<br class="gmail_msg">
>><br class="gmail_msg">
>> OK, this is OSX specific, but I still think that hardcoding bash is a bad idea. Does it need anything not in `/bin/sh`?<br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>> <a href="https://reviews.llvm.org/D25750" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25750</a><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
>><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> lldb-commits mailing list<br class="gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>