<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 10, 2016 at 8:53 PM Jason Molenda via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jmolenda<br class="gmail_msg"><br>Date: Mon Oct 10 22:44:48 2016<br class="gmail_msg"><br>New Revision: 283849<br class="gmail_msg"><br><br class="gmail_msg"><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=283849&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=283849&view=rev</a><br class="gmail_msg"><br>Log:<br class="gmail_msg"><br>Add a second, more complicated, arm64 example program to<br class="gmail_msg"><br>the arm64 assembly unwind tests.<br class="gmail_msg"><br><br class="gmail_msg"><br>Modified:<br class="gmail_msg"><br>    lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp<br class="gmail_msg"><br><br class="gmail_msg"><br>Modified: lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp<br class="gmail_msg"><br>URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp?rev=283849&r1=283848&r2=283849&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp?rev=283849&r1=283848&r2=283849&view=diff</a><br class="gmail_msg"><br>==============================================================================<br class="gmail_msg"><br>--- lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp (original)<br class="gmail_msg"><br>+++ lldb/trunk/unittests/UnwindAssembly/InstEmulation/TestArm64InstEmulation.cpp Mon Oct 10 22:44:48 2016<br class="gmail_msg"><br>@@ -56,7 +56,7 @@ static void terminate() {<br class="gmail_msg"><br>   EmulateInstructionARM64::Terminate();<br class="gmail_msg"><br> }<br class="gmail_msg"><br><br class="gmail_msg"><br>-TEST_F(TestArm64InstEmulation, TestSimpleFunction) {<br class="gmail_msg"><br>+TEST_F(TestArm64InstEmulation, TestSimpleDarwinFunction) {<br class="gmail_msg"><br><br class="gmail_msg"><br>   init();<br class="gmail_msg"><br><br class="gmail_msg"><br>@@ -64,16 +64,14 @@ TEST_F(TestArm64InstEmulation, TestSimpl<br class="gmail_msg"><br>   UnwindAssemblyInstEmulation *engine =<br class="gmail_msg"><br>       static_cast<UnwindAssemblyInstEmulation *>(<br class="gmail_msg"><br>           UnwindAssemblyInstEmulation::CreateInstance(arch));<br class="gmail_msg"><br>-  EXPECT_TRUE(engine != nullptr);<br class="gmail_msg"><br>-  if (engine == nullptr)<br class="gmail_msg"><br>-    return;<br class="gmail_msg"><br>+  ASSERT_NE(engine, nullptr);<br class="gmail_msg"></blockquote><div>I know I'm annoying, but nullptr should come first for the error message.  :)  BTW don't feel obligated to fix everything I point out, just throwing these things out there as minor nits.</div><div> </div></div></div>