If all the tests are being xfailed you should probably just revert the original patch until the tests are fixed<br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 5, 2016 at 8:09 AM Dimitar Vlahovski via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvlahovski<br class="gmail_msg">
Date: Wed Oct 5 10:00:29 2016<br class="gmail_msg">
New Revision: 283324<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=283324&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=283324&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
xfailing minidump tests again ... :(<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py?rev=283324&r1=283323&r2=283324&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py?rev=283324&r1=283323&r2=283324&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py (original)<br class="gmail_msg">
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py Wed Oct 5 10:00:29 2016<br class="gmail_msg">
@@ -18,6 +18,7 @@ class MiniDumpNewTestCase(TestBase):<br class="gmail_msg">
<br class="gmail_msg">
NO_DEBUG_INFO_TESTCASE = True<br class="gmail_msg">
<br class="gmail_msg">
+ @expectedFailureAll<br class="gmail_msg">
def test_process_info_in_minidump(self):<br class="gmail_msg">
"""Test that lldb can read the process information from the Minidump."""<br class="gmail_msg">
# target create -c linux-x86_64.dmp<br class="gmail_msg">
@@ -28,6 +29,7 @@ class MiniDumpNewTestCase(TestBase):<br class="gmail_msg">
self.assertEqual(self.process.GetNumThreads(), 1)<br class="gmail_msg">
self.assertEqual(self.process.GetProcessID(), 16001)<br class="gmail_msg">
<br class="gmail_msg">
+ @expectedFailureAll<br class="gmail_msg">
def test_thread_info_in_minidump(self):<br class="gmail_msg">
"""Test that lldb can read the thread information from the Minidump."""<br class="gmail_msg">
# target create -c linux-x86_64.dmp<br class="gmail_msg">
@@ -42,6 +44,7 @@ class MiniDumpNewTestCase(TestBase):<br class="gmail_msg">
stop_description = thread.GetStopDescription(256)<br class="gmail_msg">
self.assertTrue("SIGSEGV" in stop_description)<br class="gmail_msg">
<br class="gmail_msg">
+ @expectedFailureAll<br class="gmail_msg">
def test_stack_info_in_minidump(self):<br class="gmail_msg">
"""Test that we can see a trivial stack in a breakpad-generated Minidump."""<br class="gmail_msg">
# target create linux-x86_64 -c linux-x86_64.dmp<br class="gmail_msg">
@@ -62,6 +65,7 @@ class MiniDumpNewTestCase(TestBase):<br class="gmail_msg">
self.assertTrue(eip.IsValid())<br class="gmail_msg">
self.assertEqual(pc, eip.GetValueAsUnsigned())<br class="gmail_msg">
<br class="gmail_msg">
+ @expectedFailureAll<br class="gmail_msg">
def test_snapshot_minidump(self):<br class="gmail_msg">
"""Test that if we load a snapshot minidump file (meaning the process did not crash) there is no stop reason."""<br class="gmail_msg">
# target create -c linux-x86_64_not_crashed.dmp<br class="gmail_msg">
@@ -74,6 +78,7 @@ class MiniDumpNewTestCase(TestBase):<br class="gmail_msg">
stop_description = thread.GetStopDescription(256)<br class="gmail_msg">
self.assertEqual(stop_description, None)<br class="gmail_msg">
<br class="gmail_msg">
+ @expectedFailureAll<br class="gmail_msg">
def test_deeper_stack_in_minidump(self):<br class="gmail_msg">
"""Test that we can examine a more interesting stack in a Minidump."""<br class="gmail_msg">
# Launch with the Minidump, and inspect the stack.<br class="gmail_msg">
@@ -90,6 +95,7 @@ class MiniDumpNewTestCase(TestBase):<br class="gmail_msg">
function_name = frame.GetFunctionName()<br class="gmail_msg">
self.assertTrue(name in function_name)<br class="gmail_msg">
<br class="gmail_msg">
+ @expectedFailureAll<br class="gmail_msg">
def test_local_variables_in_minidump(self):<br class="gmail_msg">
"""Test that we can examine local variables in a Minidump."""<br class="gmail_msg">
# Launch with the Minidump, and inspect a local variable.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>