<div dir="ltr">The test fails on remote targets because it tries to set breakpoints based on remote paths. We'll have that fixed shortly.</div><div class="gmail_extra"><br><div class="gmail_quote">On 3 October 2016 at 11:13, Jim Ingham via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These tests were failing for a bogus reason, so I fixed the bogus reason and let them try again.  They succeed on MacOS, but apparently there's another failure reason for these configurations.<br>
<br>
Do you know the configuration for (in terms of the testsuite's "oslist"?  If not, I'll find out what to xfail.<br>
<span class="HOEnZb"><font color="#888888"><br>
Jim<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
> On Oct 3, 2016, at 3:12 AM, Dimitar Vlahovski <<a href="mailto:dvlahovski@google.com">dvlahovski@google.com</a>> wrote:<br>
><br>
> Hi,<br>
> Are these build breakages somehow connected to this commit?<br>
> <a href="http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/8703" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/lldb-windows7-<wbr>android/builds/8703</a><br>
> <a href="http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-android/builds/9655" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/lldb-x86_64-ubuntu-<wbr>14.04-android/builds/9655</a><br>
><br>
> Thanks,<br>
> Dimitar<br>
><br>
> On Fri, Sep 30, 2016 at 11:07 PM, Jim Ingham via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br>
> Author: jingham<br>
> Date: Fri Sep 30 17:07:41 2016<br>
> New Revision: 282966<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282966&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=282966&view=rev</a><br>
> Log:<br>
> IsValid is the way to ask a breakpoint location whether it is valid.<br>
><br>
> Modified:<br>
>     lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/breakpoint/<wbr>breakpoint_case_sensitivity/<wbr>TestBreakpointCaseSensitivity.<wbr>py<br>
><br>
> Modified: lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/breakpoint/<wbr>breakpoint_case_sensitivity/<wbr>TestBreakpointCaseSensitivity.<wbr>py<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py?rev=282966&r1=282965&r2=282966&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/packages/<wbr>Python/lldbsuite/test/<wbr>functionalities/breakpoint/<wbr>breakpoint_case_sensitivity/<wbr>TestBreakpointCaseSensitivity.<wbr>py?rev=282966&r1=282965&r2=<wbr>282966&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/breakpoint/<wbr>breakpoint_case_sensitivity/<wbr>TestBreakpointCaseSensitivity.<wbr>py (original)<br>
> +++ lldb/trunk/packages/Python/<wbr>lldbsuite/test/<wbr>functionalities/breakpoint/<wbr>breakpoint_case_sensitivity/<wbr>TestBreakpointCaseSensitivity.<wbr>py Fri Sep 30 17:07:41 2016<br>
> @@ -27,7 +27,7 @@ class BreakpointCaseSensitivityTestC<wbr>ase(<br>
><br>
>      @skipIf(oslist=['windows'])  # Skip for windows platforms<br>
>      # Failing for unknown reason on non-Windows platforms.<br>
> -    @expectedFailureAll()<br>
> +<br>
>      def test_breakpoint_doesnt_match_<wbr>file_with_different_case(self)<wbr>:<br>
>          """Set breakpoint on file, shouldn't match files with different case on POSIX systems"""<br>
>          self.build()<br>
> @@ -98,7 +98,8 @@ class BreakpointCaseSensitivityTestC<wbr>ase(<br>
>          # Get the breakpoint location from breakpoint after we verified that,<br>
>          # indeed, it has one location.<br>
>          location = breakpoint.GetLocationAtIndex(<wbr>0)<br>
> -        self.assertEqual(location and location.IsEnabled(),<br>
> +<br>
> +        self.assertEqual(location.<wbr>IsValid(),<br>
>                           should_hit,<br>
>                           VALID_BREAKPOINT_LOCATION + desc)<br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> lldb-commits mailing list<br>
> <a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
><br>
<br>
______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</div></div></blockquote></div><br></div>