<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 26, 2016, at 2:50 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Test would be nice, but otoh command line tests are discouraged. Maybe it will be easier to write this kind of test if we had a tool specifically for testing command line options similar to what I proposed with unwinding etc. oh well<br class=""></div></blockquote><div><br class=""></div><div>There already is a test for this - that's how the breakage was caught to begin with :-)</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: enrico<br class="gmail_msg">
Date: Mon Sep 26 16:36:17 2016<br class="gmail_msg">
New Revision: 282445<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282445&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=282445&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring<br class="gmail_msg">
<br class="gmail_msg">
Fixes <a href="rdar://28480275" class="">rdar://28480275</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
lldb/trunk/source/Commands/CommandObjectExpression.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=282445&r1=282444&r2=282445&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=282445&r1=282444&r2=282445&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Commands/CommandObjectExpression.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Commands/CommandObjectExpression.cpp Mon Sep 26 16:36:17 2016<br class="gmail_msg">
@@ -142,7 +142,7 @@ Error CommandObjectExpression::CommandOp<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
case 'v':<br class="gmail_msg">
- if (!option_arg.empty()) {<br class="gmail_msg">
+ if (option_arg.empty()) {<br class="gmail_msg">
m_verbosity = eLanguageRuntimeDescriptionDisplayVerbosityFull;<br class="gmail_msg">
break;<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>
</div></blockquote></div><br class=""><div class="">
<div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class="Apple-interchange-newline">Thanks,</div><div class="" style="color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><i class="">- Enrico</i><br class="">📩 egranata@<font color="#ff2600" class=""></font>.com ☎️ 27683</div>
</div>
<br class=""></body></html>