<div dir="ltr">Thanks I'll take a look.  I only saw the other because I got a buildbot break notification.  I'll go checkout Host.mm</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 23, 2016 at 3:44 PM Jim Ingham <<a href="mailto:jingham@apple.com">jingham@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think you missed some changes in Host.mm on OS X as well.<br class="gmail_msg">
<br class="gmail_msg">
Jim<br class="gmail_msg">
<br class="gmail_msg">
> On Sep 23, 2016, at 3:27 PM, Zachary Turner via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
> Author: zturner<br class="gmail_msg">
> Date: Fri Sep 23 17:27:03 2016<br class="gmail_msg">
> New Revision: 282309<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282309&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=282309&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> Fix build on Ubuntu.<br class="gmail_msg">
><br class="gmail_msg">
> This was in some code that was #ifdef'd out on Windows, so I<br class="gmail_msg">
> didn't see it.<br class="gmail_msg">
><br class="gmail_msg">
> Modified:<br class="gmail_msg">
>    lldb/trunk/source/Host/common/Host.cpp<br class="gmail_msg">
><br class="gmail_msg">
> Modified: lldb/trunk/source/Host/common/Host.cpp<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Host.cpp?rev=282309&r1=282308&r2=282309&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Host.cpp?rev=282309&r1=282308&r2=282309&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- lldb/trunk/source/Host/common/Host.cpp (original)<br class="gmail_msg">
> +++ lldb/trunk/source/Host/common/Host.cpp Fri Sep 23 17:27:03 2016<br class="gmail_msg">
> @@ -942,15 +942,15 @@ bool Host::AddPosixSpawnFileAction(void<br class="gmail_msg">
>       if (oflag & O_CREAT)<br class="gmail_msg">
>         mode = 0640;<br class="gmail_msg">
><br class="gmail_msg">
> -      error.SetError(<br class="gmail_msg">
> -          ::posix_spawn_file_actions_addopen(file_actions, info->GetFD(),<br class="gmail_msg">
> -                                             info->GetPath(), oflag, mode),<br class="gmail_msg">
> -          eErrorTypePOSIX);<br class="gmail_msg">
> +      error.SetError(::posix_spawn_file_actions_addopen(<br class="gmail_msg">
> +                         file_actions, info->GetFD(),<br class="gmail_msg">
> +                         info->GetPath().str().c_str(), oflag, mode),<br class="gmail_msg">
> +                     eErrorTypePOSIX);<br class="gmail_msg">
>       if (error.Fail() || log)<br class="gmail_msg">
>         error.PutToLog(log, "posix_spawn_file_actions_addopen (action=%p, "<br class="gmail_msg">
>                             "fd=%i, path='%s', oflag=%i, mode=%i)",<br class="gmail_msg">
>                        static_cast<void *>(file_actions), info->GetFD(),<br class="gmail_msg">
> -                       info->GetPath(), oflag, mode);<br class="gmail_msg">
> +                       info->GetPath().str().c_str(), oflag, mode);<br class="gmail_msg">
>     }<br class="gmail_msg">
>     break;<br class="gmail_msg">
>   }<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> lldb-commits mailing list<br class="gmail_msg">
> <a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>