<div dir="ltr">That fix doesn't look complete:<div><br></div> for (size_t i = 0; i < column - 1 && i < src_line.length(); ++i)<div><span style="font-size:16px"><br></span></div>`column` is an unsigned integral type, so doing subtraction from it can lead to surprising results.  It's probably best to write it as:<div><br></div><div>  for (size_t i = 0; i  + 1 < column && i < src_line.length(); ++i)</div><div><br></div><div>That will more gracefully handle the case where column is 0.</div><div><br></div><div>Adrian.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 21, 2016 at 2:14 PM, Ed Maste via lldb-commits <span dir="ltr"><<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: emaste<br>
Date: Wed Sep 21 16:14:31 2016<br>
New Revision: 282112<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=282112&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=282112&view=rev</a><br>
Log:<br>
Fix integer sign warning from r282105<br>
<br>
Modified:<br>
    lldb/trunk/source/Core/<wbr>SourceManager.cpp<br>
<br>
Modified: lldb/trunk/source/Core/<wbr>SourceManager.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/SourceManager.cpp?rev=282112&r1=282111&r2=282112&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lldb/trunk/source/<wbr>Core/SourceManager.cpp?rev=<wbr>282112&r1=282111&r2=282112&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lldb/trunk/source/Core/<wbr>SourceManager.cpp (original)<br>
+++ lldb/trunk/source/Core/<wbr>SourceManager.cpp Wed Sep 21 16:14:31 2016<br>
@@ -172,7 +172,7 @@ size_t SourceManager::<wbr>DisplaySourceLines<br>
         m_last_file_sp->GetLine(line, src_line);<br>
         return_value += s->Printf("    \t");<br>
         // Insert a space for every non-tab character in the source line.<br>
-        for (int i = 0; i < column - 1 && i < src_line.length(); ++i)<br>
+        for (size_t i = 0; i < column - 1 && i < src_line.length(); ++i)<br>
           return_value += s->PutChar(src_line[i] == '\t' ? '\t' : ' ');<br>
         // Now add the caret.<br>
         return_value += s->Printf("^\n");<br>
<br>
<br>
______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</blockquote></div><br></div>