<div dir="ltr">Yea, it's too bad about the type.  This is one case where auto isn't just syntactic sugar, it's actually necessary.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 14, 2016 at 2:07 PM Sean Callanan via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spyffe<br class="gmail_msg">
Date: Wed Sep 14 15:58:31 2016<br class="gmail_msg">
New Revision: 281536<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281536&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=281536&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Replaced two instances of std::function with auto.<br class="gmail_msg">
<br class="gmail_msg">
Thanks to Zachary Turner for the suggestion.  It's distasteful that the actual<br class="gmail_msg">
type of the lambda can't be spelled out, but it should be evident from the<br class="gmail_msg">
definition of the lambda body.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    lldb/trunk/source/Expression/DWARFExpression.cpp<br class="gmail_msg">
    lldb/trunk/source/Target/StackFrame.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Expression/DWARFExpression.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/DWARFExpression.cpp?rev=281536&r1=281535&r2=281536&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/DWARFExpression.cpp?rev=281536&r1=281535&r2=281536&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Expression/DWARFExpression.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Expression/DWARFExpression.cpp Wed Sep 14 15:58:31 2016<br class="gmail_msg">
@@ -3335,10 +3335,9 @@ bool DWARFExpression::MatchesOperand(Sta<br class="gmail_msg">
       return false;<br class="gmail_msg">
     }<br class="gmail_msg">
<br class="gmail_msg">
-    std::function<bool(const Instruction::Operand &)> recurse =<br class="gmail_msg">
-        [&frame, fb_expr](const Instruction::Operand &child) {<br class="gmail_msg">
-          return fb_expr->MatchesOperand(frame, child);<br class="gmail_msg">
-        };<br class="gmail_msg">
+    auto recurse = [&frame, fb_expr](const Instruction::Operand &child) {<br class="gmail_msg">
+      return fb_expr->MatchesOperand(frame, child);<br class="gmail_msg">
+    };<br class="gmail_msg">
<br class="gmail_msg">
     if (!offset &&<br class="gmail_msg">
         MatchUnaryOp(MatchOpType(Instruction::Operand::Type::Dereference),<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Target/StackFrame.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=281536&r1=281535&r2=281536&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=281536&r1=281535&r2=281536&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Target/StackFrame.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Target/StackFrame.cpp Wed Sep 14 15:58:31 2016<br class="gmail_msg">
@@ -1608,10 +1608,9 @@ lldb::ValueObjectSP DoGuessValueAt(Stack<br class="gmail_msg">
     }<br class="gmail_msg">
<br class="gmail_msg">
     Instruction::Operand *origin_operand = nullptr;<br class="gmail_msg">
-    std::function<bool(const Instruction::Operand &)> clobbered_reg_matcher =<br class="gmail_msg">
-        [reg_info](const Instruction::Operand &op) {<br class="gmail_msg">
-          return MatchRegOp(*reg_info)(op) && op.m_clobbered;<br class="gmail_msg">
-        };<br class="gmail_msg">
+    auto clobbered_reg_matcher = [reg_info](const Instruction::Operand &op) {<br class="gmail_msg">
+      return MatchRegOp(*reg_info)(op) && op.m_clobbered;<br class="gmail_msg">
+    };<br class="gmail_msg">
<br class="gmail_msg">
     if (clobbered_reg_matcher(operands[0])) {<br class="gmail_msg">
       origin_operand = &operands[1];<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>