<div style="white-space:pre-wrap">I don't think requiring user install of six would work, lldb should just work out of the box.  Renaming it to lldb_six might work.<br><br>Also yes using llvm regex everywhere would be wonderful, I honestly have no idea why mi was developed the way it was with an aversion to using llvm classes</div><br><div class="gmail_quote"><div dir="ltr">On Sat, Sep 10, 2016 at 11:16 PM Michał Górny via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">mgorny added a comment.<br class="gmail_msg">
<br class="gmail_msg">
In <a href="https://reviews.llvm.org/D23883#539442" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D23883#539442</a>, @krytarowski wrote:<br class="gmail_msg">
<br class="gmail_msg">
> It looks good. Remaining TODO for standalone builds:<br class="gmail_msg">
><br class="gmail_msg">
> - sanitize six.py usage (it's installed into system-wide directory, where standard py-six lands)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
How would you prefer handling it? Can we just kill it and rely on user installing it system-wide or via pip?<br class="gmail_msg">
<br class="gmail_msg">
> - bump cmake_minimum_required(VERSION 2.8.12.2) to 3.4.3 in cmake/modules/LLDBStandalone.cmake Final bits for Windows:<br class="gmail_msg">
<br class="gmail_msg">
> - eliminate the usage of ../lib/Support/regex_impl.h in RegularExpression.h<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Wouldn't it be actually better to kill that regex implementation as well, and use the class provided by LLVMSupport everywhere? I started with the other since it caused direct build issues on Linux but I think I could try to kill this one as well.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D23883" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D23883</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>