<div style="white-space:pre-wrap">I'll figure out how to port lldb's use over to yaml</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 9, 2016 at 7:31 PM Mike Aizatsky <<a href="mailto:aizatsky@google.com">aizatsky@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Oh, that's great! Thanks for pointing this out. I'll just upload the cleaned up version in case lldb/ folks would like it. I'll figure out how to use our YAML library.</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"></div><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Fri, Sep 9, 2016 at 6:48 PM Chandler Carruth <<a href="mailto:chandlerc@gmail.com" class="gmail_msg" target="_blank">chandlerc@gmail.com</a>> wrote:<br class="gmail_msg"></div></div><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">chandlerc added a comment.<br class="gmail_msg">
<br class="gmail_msg">
In <a href="https://reviews.llvm.org/D24369#538472" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24369#538472</a>, @zturner wrote:<br class="gmail_msg">
<br class="gmail_msg">
> In <a href="https://reviews.llvm.org/D24369#538422" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24369#538422</a>, @aizatsky wrote:<br class="gmail_msg">
><br class="gmail_msg">
> > > I'm a bit surprised there's not already a json parser in LLVM.  Maybe there's a reason for it.  I think this CL needs a few more reviewers on the LLVM side, so I'm adding a few people.<br class="gmail_msg">
> ><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
There is already a JSON parser in LLVM.<br class="gmail_msg">
<br class="gmail_msg">
> > I can't actually find json parser within clang-tidy. Only references that I see lead eventually to YAML parsing:<br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
> I was thinking of `lib/Tooling/JSONCompilationDatabase`, but looking at it, it seems to be pretty specialized and doesn't support arbitrary JSON.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
It uses the YAML parser because JSON is a strict subset of YAML: <a href="https://en.wikipedia.org/wiki/JSON#YAML" rel="noreferrer" class="gmail_msg" target="_blank">https://en.wikipedia.org/wiki/JSON#YAML</a><br class="gmail_msg">
<br class="gmail_msg">
Please don't add a JSON parser to LLVM. I would much rather teach LLDB to use the YAML parser and improve that parser if and where useful.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D24369" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D24369</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div><div dir="ltr" class="gmail_msg">-- <br class="gmail_msg"></div><div data-smartmail="gmail_signature" class="gmail_msg"><div dir="ltr" class="gmail_msg">Mike<br class="gmail_msg">Sent from phone</div></div>
</blockquote></div>