<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">In general, <sys/*> and <machine/*> headers should be at the top, followed by standard headers such as <stdio.h>, then followed by application-specific headers. IIRC this is also the case for Linux.</div><div class=""><br class=""></div><div class="">-Dimitry</div><br class=""><div><blockquote type="cite" class=""><div class="">On 07 Sep 2016, at 00:02, Zachary Turner via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Why was this causing a problem? The only headers that were re-ordered are system headers. Does FreeBSD's libraries have requirements about certain headers being included before other headers?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, Sep 6, 2016 at 2:33 PM Ed Maste via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: emaste<br class="gmail_msg">
Date: Tue Sep 6 16:25:31 2016<br class="gmail_msg">
New Revision: 280755<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=280755&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=280755&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Reorder FreeBSD Host.cpp #includes to fix build<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
lldb/trunk/source/Host/freebsd/Host.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: lldb/trunk/source/Host/freebsd/Host.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/freebsd/Host.cpp?rev=280755&r1=280754&r2=280755&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/freebsd/Host.cpp?rev=280755&r1=280754&r2=280755&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- lldb/trunk/source/Host/freebsd/Host.cpp (original)<br class="gmail_msg">
+++ lldb/trunk/source/Host/freebsd/Host.cpp Tue Sep 6 16:25:31 2016<br class="gmail_msg">
@@ -9,17 +9,19 @@<br class="gmail_msg">
//===----------------------------------------------------------------------===//<br class="gmail_msg">
<br class="gmail_msg">
// C Includes<br class="gmail_msg">
-#include <dlfcn.h><br class="gmail_msg">
-#include <execinfo.h><br class="gmail_msg">
-#include <stdio.h><br class="gmail_msg">
+#include <sys/types.h><br class="gmail_msg">
+<br class="gmail_msg">
+#include <sys/exec.h><br class="gmail_msg">
#include <sys/proc.h><br class="gmail_msg">
+#include <sys/ptrace.h><br class="gmail_msg">
#include <sys/sysctl.h><br class="gmail_msg">
-#include <sys/types.h><br class="gmail_msg">
#include <sys/user.h><br class="gmail_msg">
<br class="gmail_msg">
#include <machine/elf.h><br class="gmail_msg">
-#include <sys/exec.h><br class="gmail_msg">
-#include <sys/ptrace.h><br class="gmail_msg">
+<br class="gmail_msg">
+#include <dlfcn.h><br class="gmail_msg">
+#include <execinfo.h><br class="gmail_msg">
+#include <stdio.h><br class="gmail_msg">
<br class="gmail_msg">
// C++ Includes<br class="gmail_msg">
// Other libraries and framework includes<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
lldb-commits mailing list<br class="gmail_msg">
<a href="mailto:lldb-commits@lists.llvm.org" class="gmail_msg" target="_blank">lldb-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br class="gmail_msg">
</blockquote></div>
_______________________________________________<br class="">lldb-commits mailing list<br class=""><a href="mailto:lldb-commits@lists.llvm.org" class="">lldb-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits<br class=""></div></blockquote></div><br class=""></body></html>