<div dir="ltr">Also given that the reformat is going to happen today, I wonder if we should wait until after it is complete to put in any more high risk changes.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 6, 2016 at 8:07 AM Pavel Labath via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">labath requested changes to this revision.<br>
labath added a comment.<br>
This revision now requires changes to proceed.<br>
<br>
I have a couple of questions I'd like to be answered before this goes in. Apart from the inline comments, all my questions from the previous version of this commit still stand.<br>
<br>
<br>
================<br>
Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5<br>
@@ +4,3 @@<br>
+<br>
+ifeq "$(ARCH)" "i386"<br>
+       CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32<br>
----------------<br>
This should not be necessary. Makefile.rules already correctly appends -m32 when needed. Maybe CFLAGS_EXTRAS would work instead (?)<br>
<br>
================<br>
Comment at: packages/Python/lldbsuite/test/functionalities/register/register_command/TestRegisters.py:297<br>
@@ -294,4 +296,3 @@<br>
             for registerSet in registerSets:<br>
-                if 'advanced vector extensions' in registerSet.GetName().lower():<br>
-                    has_avx = True<br>
-                    break<br>
+                if registerSet.GetName():<br>
+                    if 'advanced vector extensions' in registerSet.GetName().lower():<br>
----------------<br>
Do we want to allow a register set with no name? It looks like the root of the problem is elsewhere.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D24255" rel="noreferrer" target="_blank">https://reviews.llvm.org/D24255</a><br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>