<div dir="ltr">Ahh right, in that case I can commit it in the morning unless someone else beats me to it.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Aug 30, 2016 at 6:55 PM Taras Tsugrii <<a href="mailto:ttsugrii@fb.com">ttsugrii@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_9091195797782456075WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Calibri">Thanks for the review Zachary, but I don’t have commit privileges, so I hope that someone can commit the change for me.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:Calibri"><u></u> <u></u></span></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-family:Calibri;color:black">From: </span>
</b><span style="font-family:Calibri;color:black">Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>><br>
<b>Date: </b>Tuesday, August 30, 2016 at 6:52 PM<br>
<b>To: </b>"<a href="mailto:reviews%2BD24064%2Bpublic%2B13175c1cba5ef3ba@reviews.llvm.org" target="_blank">reviews+D24064+public+13175c1cba5ef3ba@reviews.llvm.org</a>" <<a href="mailto:reviews%2BD24064%2Bpublic%2B13175c1cba5ef3ba@reviews.llvm.org" target="_blank">reviews+D24064+public+13175c1cba5ef3ba@reviews.llvm.org</a>>, Taras Tsugrii <<a href="mailto:ttsugrii@fb.com" target="_blank">ttsugrii@fb.com</a>><br>
<b>Cc: </b>"<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>" <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: [PATCH] D24064: Fix lldb build on Mac.<u></u><u></u></span></p>
</div></div></div><div bgcolor="white" lang="EN-US" link="blue" vlink="purple"><div class="m_9091195797782456075WordSection1">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<div>
<p class="MsoNormal">Looks good, feel free to commit without review when you're fixing a build<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Aug 30, 2016 at 4:57 PM Taras Tsugrii <<a href="mailto:ttsugrii@fb.com" target="_blank">ttsugrii@fb.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">wttsugrii created this revision.<br>
wttsugrii added a reviewer: zturner.<br>
wttsugrii added a subscriber: lldb-commits.<br>
<br>
<a href="https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308" target="_blank">https://github.com/llvm-mirror/lldb/commit/e80f43fd78fa0fbc04d2d59b5713acb5d06c8308</a><br>
greatly improved an API, but missed one more occurence of legacy usage.<br>
<br>
This leads to:<br>
if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size())<br>
~~~~~~~~~~~~~~~~~~~~~ ^~~~~~<br>
/lldb/include/lldb/Utility/StringExtractor.h:151:5: note: 'GetHexBytes' declared here<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D24064&d=DQMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=jqaYv5aDYHR_MGTz1rkWPg&m=C_-Mt0Q6SBVqzxYJUNfPoBSJcuoC80sFiVFMleZ6laQ&s=gS55VX9ND45mrFYZFa0QZPP3ZA26W7uq8U_m4wUlq_Q&e=" target="_blank">https://reviews.llvm.org/D24064</a><br>
<br>
Files:<br>
source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
<br>
Index: source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
===================================================================<br>
--- source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
+++ source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp<br>
@@ -1099,7 +1099,7 @@<br>
return false;<br>
}<br>
payload_bytes.resize(ascii_hex_bytes_cstr_len/2);<br>
- if (extractor.GetHexBytes(&payload_bytes[0], payload_bytes.size(), '\xdd') != payload_bytes.size())<br>
+ if (extractor.GetHexBytes(payload_bytes, '\xdd') != payload_bytes.size())<br>
{<br>
result.AppendErrorWithFormat ("payload data must only contain ASCII hex characters (no spaces or hex prefixes): '%s'", ascii_hex_bytes_cstr);<br>
result.SetStatus (eReturnStatusFailed);<br>
<br>
<u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div></div></blockquote></div>