<div dir="ltr">Thanks for the comment. Do you have anything particular in mind from the llvm types? Is there something similar to DataExtractor?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 16, 2016 at 4:21 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I would prefer to use llvm types to do the parsing wherever possible.  Why do we need DataExtractor?  If the only reason is to force little endian, just use the types in llvm/Endian.h<br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Tue, Aug 16, 2016 at 8:13 AM Dimitar Vlahovski via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">dvlahovski updated this revision to Diff 68180.<br>
dvlahovski added a comment.<br>
<br>
Fixing a little bug - should get the byteorder<br>
<br>
after calling SignatureMatchAndSetByteOrder<br>
<br>
<br>
<a href="https://reviews.llvm.org/D23545" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D23545</a><br>
<br>
Files:<br>
  cmake/LLDBDependencies.cmake<br>
  source/Plugins/Process/<wbr>CMakeLists.txt<br>
  source/Plugins/Process/<wbr>minidump/CMakeLists.txt<br>
  source/Plugins/Process/<wbr>minidump/MinidumpParser.cpp<br>
  source/Plugins/Process/<wbr>minidump/MinidumpParser.h<br>
  source/Plugins/Process/<wbr>minidump/MinidumpTypes.cpp<br>
  source/Plugins/Process/<wbr>minidump/MinidumpTypes.h<br>
  unittests/Process/CMakeLists.<wbr>txt<br>
  unittests/Process/minidump/<wbr>CMakeLists.txt<br>
  unittests/Process/minidump/<wbr>Inputs/linux-x86_64.dmp<br>
  unittests/Process/minidump/<wbr>MinidumpParserTest.cpp<br>
<br></div></div>
______________________________<wbr>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</blockquote></div><br></div>