Just chiming in to say modules is unsupported on Windows even with clang, so please make sure the gmodules support function takes this into account <br><div class="gmail_quote"><div dir="ltr">On Tue, May 24, 2016 at 9:05 AM Todd Fiala via lldb-commits <<a href="mailto:lldb-commits@lists.llvm.org">lldb-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">tfiala added a comment.<br>
<br>
So at this point, it looks like we're just missing a mechanism to check for gmodules support, and then add it to the supported_categories list if it is available.<br>
<br>
I'll have a look a that.<br>
<br>
This might be the time where we want to break out an apple-clang vs. llvm.org-clang when we talk about version numbers. We're asking for trouble when we treat both as the same, yet they have drastically different version numbers that will eventually collide as <a href="http://llvm.org" rel="noreferrer" target="_blank">llvm.org</a> version numbers increase.<br>
<br>
<br>
================<br>
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1488<br>
@@ +1487,3 @@<br>
+ @wraps(attrvalue)<br>
+ def dwarf_test_method(self, attrvalue=attrvalue):<br>
+ self.debug_info = "gmodules"<br>
----------------<br>
labath wrote:<br>
> Shouldn't this be `gmodules_test_method`?<br>
I agree with @labath<br>
<br>
================<br>
Comment at: packages/Python/lldbsuite/test/plugins/builder_base.py:144<br>
@@ -143,1 +143,3 @@<br>
<br>
+def buildDwarf(sender=None, architecture=None, compiler=None, dictionary=None, clean=True):<br>
+ """Build the binaries with dwarf debug info."""<br>
----------------<br>
labath wrote:<br>
> shouldn't this be `buildModules` or something?<br>
buildGModules() sounds right here, particularly since it matches the define being passed in. And adjust the comment below to reflect.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D19998" rel="noreferrer" target="_blank">http://reviews.llvm.org/D19998</a><br>
<br>
<br>
<br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@lists.llvm.org" target="_blank">lldb-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits</a><br>
</blockquote></div>