<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 29, 2016 at 8:43 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It's night here, so I will have a detailed look tomorrow. But in the meantime, some of the issues don't appear to be addressed. For example the issue about why logging is disabled,</div></blockquote><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline">Fixed with the new patch</div></div><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline"></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"> the disabled code in ProcessWinMiniDump.cpp,</div></blockquote><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline">Fixed</div></div><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small;display:inline"></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"> and a few other things. If you view the diff in Phabricator, you can respond inline to each of those with some kind of explanation if possible.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, Mar 28, 2016 at 10:26 PM Eran Ifrah <<a href="mailto:eran.ifrah@gmail.com" target="_blank">eran.ifrah@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">eran.ifrah updated this revision to Diff 51873.<br>
eran.ifrah marked 21 inline comments as done.<br>
eran.ifrah added a comment.<br>
<br>
An updated patch that fixes all your comments and in includes this one as well: <a href="http://reviews.llvm.org/D18520" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18520</a><br>
I also added new command line argument option to `CMake` : `-DMINGW_DEBUG=1` when passed from the command line, it adds `-g -O0` to the LLDB sources (only LLDB)<br>
Using the standard way `-DCMAKE_BUILD_TYPE=Debug` creates file too large for MinGW to handle<br>
<br>
<br>
<a href="http://reviews.llvm.org/D18519" rel="noreferrer" target="_blank">http://reviews.llvm.org/D18519</a><br>
<br>
Files:<br>
CMakeLists.txt<br>
cmake/modules/AddLLDB.cmake<br>
cmake/modules/LLDBConfig.cmake<br>
include/lldb/Host/windows/win32.h<br>
source/API/SystemInitializerFull.cpp<br>
source/Host/common/OptionParser.cpp<br>
source/Host/windows/EditLineWin.cpp<br>
source/Host/windows/FileSystem.cpp<br>
source/Host/windows/ProcessRunLock.cpp<br>
source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp<br>
source/Plugins/Process/Windows/Common/ProcessWindowsLog.h<br>
source/Target/ProcessLaunchInfo.cpp<br>
source/Utility/PseudoTerminal.cpp<br>
tools/CMakeLists.txt<br>
tools/argdumper/CMakeLists.txt<br>
tools/driver/CMakeLists.txt<br>
tools/driver/Driver.cpp<br>
<br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><font face="verdana, sans-serif">Eran Ifrah,<br>Author of codelite, a cross platform open source C/C++ IDE: <a href="http://www.codelite.org" target="_blank">http://www.codelite.org</a><br></font><div><font face="verdana, sans-serif">CodeLite IDE Blog: <a href="http://codeliteide.blogspot.com/" target="_blank">http://codeliteide.blogspot.com/</a></font></div></div></div>
</div></div>